From: Paul Cercueil <paul@crapouillou.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] memory: jz4780_nemc: Fix an error pointer vs NULL check in probe()
Date: Wed, 05 Aug 2020 02:04:34 +0200 [thread overview]
Message-ID: <MJDKEQ.BWLP6TXTA14J1@crapouillou.net> (raw)
In-Reply-To: <20200803143607.GC346925@mwanda>
Le lun. 3 août 2020 à 17:36, Dan Carpenter <dan.carpenter@oracle.com>
a écrit :
> The devm_ioremap() function returns NULL on error, it doesn't return
> error pointers. This bug could lead to an Oops during probe.
>
> Fixes: f046e4a3f0b9 ("memory: jz4780_nemc: Only request IO memory the
> driver will use")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Thanks!
-Paul
> ---
> drivers/memory/jz4780-nemc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/jz4780-nemc.c
> b/drivers/memory/jz4780-nemc.c
> index 3ec5cb0fce1e..608ae925e641 100644
> --- a/drivers/memory/jz4780-nemc.c
> +++ b/drivers/memory/jz4780-nemc.c
> @@ -304,9 +304,9 @@ static int jz4780_nemc_probe(struct
> platform_device *pdev)
> }
>
> nemc->base = devm_ioremap(dev, res->start, NEMC_REG_LEN);
> - if (IS_ERR(nemc->base)) {
> + if (!nemc->base) {
> dev_err(dev, "failed to get I/O memory\n");
> - return PTR_ERR(nemc->base);
> + return -ENOMEM;
> }
>
> writel(0, nemc->base + NEMC_NFCSR);
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-08-06 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:36 [PATCH] memory: jz4780_nemc: Fix an error pointer vs NULL check in probe() Dan Carpenter
2020-08-04 6:46 ` Krzysztof Kozlowski
2020-08-05 0:04 ` Paul Cercueil [this message]
2020-08-17 12:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MJDKEQ.BWLP6TXTA14J1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).