From: Anup Patel <Anup.Patel@wdc.com>
To: Christoph Hellwig <hch@infradead.org>, Anup Patel <anup@brainfault.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter
Date: Wed, 13 Feb 2019 03:43:06 +0000 [thread overview]
Message-ID: <MN2PR04MB60615E8737B56B1B213B5FA58D660@MN2PR04MB6061.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20190212184505.GA10984@infradead.org>
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Christoph Hellwig
> Sent: Wednesday, February 13, 2019 12:15 AM
> To: Anup Patel <anup@brainfault.org>
> Cc: Christoph Hellwig <hch@infradead.org>; Palmer Dabbelt
> <palmer@sifive.com>; Anup Patel <Anup.Patel@wdc.com>; linux-
> kernel@vger.kernel.org; Atish Patra <Atish.Patra@wdc.com>; Albert Ou
> <aou@eecs.berkeley.edu>; Paul Walmsley <paul.walmsley@sifive.com>;
> linux-riscv@lists.infradead.org
> Subject: Re: [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter
>
> On Tue, Feb 12, 2019 at 03:53:21PM +0530, Anup Patel wrote:
> > If it is initramfs (i.e. CPIO image) then contents of CPIO archive are
> > extracted to create a ramfs instance.
> >
> > If it is initrd (i.e. some filesystem image) then RAM block device is
> > created in-place at initrd location. (Please correct me if I am wrong
> > about initrd here).
>
> No. If it is an initrd image we still copy it into the rootfs first, and then load it
> into a ram disk. Take a look at
> init/initramfs.c:populate_rootfs() and
> init/do_mounts_initrd.c:initrd_load().
>
> > So in case of initrd we might not want to free-up the RAM but we can
> > certainly free-up in case of initramfs.
>
> No, in either case we do not need the original initramfs/initrd memory. I
> suspect arm has this as a workaround for some weird legacy boot issue, but I
> can't see any reason why we would not want to free the memory on riscv.
Sure, the keepinitrd=0 by default so it will always free-up initrd by default.
Please look at v3 patchset.
Of course, we need separate patch to update documentation of keepinitrd.
Regards,
Anup
next prev parent reply other threads:[~2019-02-13 3:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 13:27 [PATCH v2 0/6] Fixmap support and MM cleanups Anup Patel
2019-01-19 13:27 ` [PATCH v2 1/6] RISC-V: Move free_initrd_mem() to kernel/setup.c Anup Patel
2019-01-19 13:28 ` [PATCH v2 2/6] RISC-V: Setup init_mm before parse_early_param() Anup Patel
2019-02-12 7:05 ` Christoph Hellwig
2019-01-19 13:28 ` [PATCH v2 3/6] RISC-V: Move setup_bootmem() to mm/init.c Anup Patel
2019-01-19 13:28 ` [PATCH v2 4/6] RISC-V: Move setup_vm() " Anup Patel
2019-01-19 13:28 ` [PATCH v2 5/6] RISC-V: Implement compile-time fixed mappings Anup Patel
2019-02-12 7:06 ` Christoph Hellwig
2019-01-19 13:28 ` [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter Anup Patel
2019-02-12 7:08 ` Christoph Hellwig
2019-02-12 10:23 ` Anup Patel
2019-02-12 10:37 ` Andreas Schwab
2019-02-12 13:53 ` Anup Patel
2019-02-12 18:45 ` Christoph Hellwig
2019-02-13 3:43 ` Anup Patel [this message]
2019-02-13 5:55 ` Christoph Hellwig
2019-02-13 6:05 ` Anup Patel
2019-02-12 21:59 ` Palmer Dabbelt
2019-02-11 6:27 ` [PATCH v2 0/6] Fixmap support and MM cleanups Anup Patel
2019-02-12 23:15 ` Palmer Dabbelt
2019-02-13 8:21 ` Anup Patel
2019-02-13 9:20 ` Johan Hovold
2019-02-14 0:37 ` Palmer Dabbelt
2019-02-14 8:28 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR04MB60615E8737B56B1B213B5FA58D660@MN2PR04MB6061.namprd04.prod.outlook.com \
--to=anup.patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).