From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E4A8C2D0B1 for ; Thu, 6 Feb 2020 10:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37363206CC for ; Thu, 6 Feb 2020 10:28:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="EV3mY/YA"; dkim=pass (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="SVX6gkDD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728478AbgBFK2V (ORCPT ); Thu, 6 Feb 2020 05:28:21 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:52974 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728261AbgBFK2V (ORCPT ); Thu, 6 Feb 2020 05:28:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1580984901; x=1612520901; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LdIuBX3bmzBk9/z8s0qeMzcqULk+dvpbU83IlnfaRDU=; b=EV3mY/YArvpbbBbJOIH/E3y8FKy1Sm05FId2ikBVIE/cNy/tCyj9b5sp awW+jLPMqJ6useR2hZzsRRcfHy06wppgTHXOibVRvASZDJfdmZ/xlsgeL xj9wrh0BDlVs2QXJ4bBlUPFo71FNQ7CSScU2IWXI2RJKatyftbRiZHVhj 5fOQ7ti32iUCcBwdzhVwXvSb8tBKiNuYHmWo6H5okU5ZozEZcvlMxQRtS UdAbSuMK/XYC6q54UNVlH8m6DAAE85kKscSufJe2iNeBcQazSXn5yCUFE D6HJWkJN2mrlUiXj5SxmV/mkQrbJ8sJkrnBZMXCCHY/lVMyD/EWrys/Zj Q==; IronPort-SDR: 1jQsCQ7TK29pfkz+IiaN+dQoS7phshHxiIFr2xGzcBibu/bJjBDTBhtfZKXik9rdzlexmYpUe6 XBAgo4eqywVfHu68yas8dIt7K3/jUGvvYvWiRTl8sIeNDybEfMI3UdWRPIpEIrd9KC2ud/b5PR uTpqqPjG/6gUbtvoaVzVpcs1NrwwJHMuw3VUvpXdzHz5PgCq82cZOEAmPMj+MP0Kij5IKY9tRI xeuoee1+PQd5hrDHhyC3JBgfmf+o2i9ncEDmHiReWcOmL83CPqidAqLt+9NOPk4GYEiptXkolz AHc= X-IronPort-AV: E=Sophos;i="5.70,409,1574092800"; d="scan'208";a="130698644" Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hgst.iphmx.com with ESMTP; 06 Feb 2020 18:28:18 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/eXQgE5y6VE/2euBN6kdU2NR6lHJYWdVGIXT9JmTITl2nJI+ZvFA/C23TCH+WWifc7TczR/KpY1q7JI6YK8bkXliyFoGPOAvPswpD3C8FsxEbBP/mgRedY12PXxa4U+1N0MtOv9dowkTi84tNuIOo87eg5946crTuhlfD5E8W+papkh63dsna+69WssmeJl/QQVvHsMZ3rBO2jgy9Fcuwu/1Eo244hpmURVqQzD4KChBvtMInBcdIbdB8spQ38U5X3SA1ZRxjxQ1wQWIAyzr96LZFVAdP/gbBexWSmF6vwWxBxVTo2oL4UdvPcHWdg+jxjHlrsI06iSHCui6yjfaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKzvHv811XCtxlWXoPud/utuXzyrON4LErgIUU2/2O8=; b=aDaeLi0arV6cTYA+ZOSNX0SFQQIIvOR44nkf8aJWnXT9YOnbp6sFq/cjBHmHJtCgidI4xoTPlDEyAcR/Bd00/mb4h9Nxul67gSBBvvev/9z6efy5gObZiKdrgyzPFIHWLNKT79hSAqtblc40zvtWmXLY4gPu27Y5cuuDpE1B92pr9dqs4CywOPToxiPuX6EZ3eo+WIYP/OLXRy/NjKKkUm4PIWM2ZehjN9bltIlkgGfCC9x5G/lZ7C4+vQj+0TsB5ei2ZOB9pWYBrfrPeBKpyVmDAksmJTCQ7EacpArHcb+3e9g93ScE53Bkf+LUk1P8hxi2bilVfgUe2Bz5KqzXGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKzvHv811XCtxlWXoPud/utuXzyrON4LErgIUU2/2O8=; b=SVX6gkDDPuTMo4BV5v3qJRGen64nG7FiTRtpeDrcLjb0QGvvF/yIl7SQukJaVMQTBKgYft4f/qe+FNZLjRb7pb3j5ZQvTPB8aU4lBuwJWwOhuwq4L+cCho9zkaAjpnRwBAVtxLsSX2R0ktNBibAZM/uAejheLwZKYDvYDL5/7TQ= Received: from MN2PR04MB6991.namprd04.prod.outlook.com (10.186.144.209) by MN2PR04MB6254.namprd04.prod.outlook.com (20.178.246.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.23; Thu, 6 Feb 2020 10:28:16 +0000 Received: from MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::3885:5fac:44af:5de7]) by MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::3885:5fac:44af:5de7%7]) with mapi id 15.20.2707.020; Thu, 6 Feb 2020 10:28:16 +0000 From: Avri Altman To: Can Guo , "asutoshd@codeaurora.org" , "nguyenb@codeaurora.org" , "hongwus@codeaurora.org" , "rnayak@codeaurora.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , "saravanak@google.com" , "salyzyn@google.com" CC: Alim Akhtar , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , Bean Huo , Stanley Chu , Bart Van Assche , Venkat Gopalakrishnan , Tomas Winkler , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: RE: [PATCH v7 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Thread-Topic: [PATCH v7 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Thread-Index: AQHV3Mg4iYpOiwL+2EGQ9TyFrLdqL6gN6BAQ Date: Thu, 6 Feb 2020 10:28:16 +0000 Message-ID: References: <1580978008-9327-1-git-send-email-cang@codeaurora.org> <1580978008-9327-6-git-send-email-cang@codeaurora.org> In-Reply-To: <1580978008-9327-6-git-send-email-cang@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 05ffbbcd-162f-447a-9b48-08d7aaef4755 x-ms-traffictypediagnostic: MN2PR04MB6254: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0305463112 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(189003)(199004)(8676002)(9686003)(86362001)(7696005)(6506007)(54906003)(110136005)(7416002)(316002)(33656002)(71200400001)(8936002)(81166006)(81156014)(4326008)(52536014)(66446008)(186003)(5660300002)(64756008)(55016002)(2906002)(26005)(76116006)(66556008)(66476007)(66946007)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR04MB6254;H:MN2PR04MB6991.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HQL+DtLawSWU+Ji9b+Huwf9q2PxFN1YSC15Lir0JRQd+orxTw5jgiEBnIPc6GRjkxHnhKt6DKHyrb1cy2IDTqygASiZ/lD2k0v/6Ob7yfESBNb1DVW9sdgGP5mYYuRduUQTXNEsq2syADNuyLMRa5dUz+dmxb4fKmTOFhZp6JeounEuF7ndKfno8IV/Hk2m1v4vbIr0Qe5KSRhkgjCISVkWi1mqDWTHH6ESbQy/w3A1GFJZgDdBxnSFY4zlFvAW2dv0UTRkBG0ZTxP3vJGSyJ8lZrdpCi7CXaPbDKbHjzrxqD4CowD7f3aPJH1UkGmb7+nh4ZVt5myoOjY8OsRV5CNru6AwbyoEqGhhXyU3SUMO90Sh3Nj0n9ObGyoVesQkuzvCIlQBY0mN7fuZcvYR6iAK3rPTCSl7HuZ1O0rrY+xe9grurnf0AWnEA3H1kWek2 x-ms-exchange-antispam-messagedata: pRsWDFCheIllfx10czG0RazCBMIUaHJBXwlwSUyp+49wkKIm8pbqQDb2MSiw7mjLXx1341RT3Wkf84fLKXsjWkkWzSPDQB7l51W+OA46deFA/kjuQZBuASkCEmTu097nVwJf3zaD2PQZFV0y5ZllSQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05ffbbcd-162f-447a-9b48-08d7aaef4755 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2020 10:28:16.5389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hj6DNQf7K2tErGHDyMV+esWRg3zBxw17QJlpbJ1UGJkubYkJbsAm0n1d7zlNRG7y+ar3SfYuhjXW8Y9ZWcKVhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6254 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, >=20 > The async version of ufshcd_hold(async =3D=3D true), which is only called > in queuecommand path as for now, is expected to work in atomic context, > thus it should not sleep or schedule out. When it runs into the condition > that clocks are ON but link is still in hibern8 state, it should bail out > without flushing the clock ungate work. Fixes: f2a785ac2312 (scsi: ufshcd: Fix race between clk scaling and ungate = work) >=20 > Signed-off-by: Can Guo > Reviewed-by: Hongwu Su > Reviewed-by: Asutosh Das > Reviewed-by: Bean Huo > Reviewed-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index bbc2607..e8f7f9d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1518,6 +1518,11 @@ int ufshcd_hold(struct ufs_hba *hba, bool async) > */ > if (ufshcd_can_hibern8_during_gating(hba) && > ufshcd_is_link_hibern8(hba)) { > + if (async) { > + rc =3D -EAGAIN; > + hba->clk_gating.active_reqs--; > + break; > + } > spin_unlock_irqrestore(hba->host->host_lock, flag= s); > flush_work(&hba->clk_gating.ungate_work); > spin_lock_irqsave(hba->host->host_lock, flags); Since now the above code is shared in all cases, Maybe find a more economical way to pack it? Thanks, Avri > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > a Linux Foundation Collaborative Project