* [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 13:04 YueHaibing
2019-09-04 13:39 ` Avri Altman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2019-09-04 13:04 UTC (permalink / raw)
To: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
liwei213, dimitrysh, kjlu, tglx, manivannan.sadhasivam,
yuehaibing, stanley.chu, arnd
Cc: linux-scsi, linux-kernel
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/ufs/ufs-hisi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
index f4d1dca..6bbb167 100644
--- a/drivers/scsi/ufs/ufs-hisi.c
+++ b/drivers/scsi/ufs/ufs-hisi.c
@@ -447,13 +447,11 @@ static int ufs_hisi_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
{
- struct resource *mem_res;
struct device *dev = host->hba->dev;
struct platform_device *pdev = to_platform_device(dev);
/* get resource of ufs sys ctrl */
- mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
+ host->ufs_sys_ctrl = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(host->ufs_sys_ctrl))
return PTR_ERR(host->ufs_sys_ctrl);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code
2019-09-04 13:04 [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-09-04 13:39 ` Avri Altman
2019-09-04 19:49 ` Manivannan Sadhasivam
2019-09-07 20:43 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2019-09-04 13:39 UTC (permalink / raw)
To: YueHaibing, alim.akhtar, pedrom.sousa, jejb, martin.petersen,
liwei213, dimitrysh, kjlu, tglx, manivannan.sadhasivam,
stanley.chu, arnd
Cc: linux-scsi, linux-kernel
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code
2019-09-04 13:04 [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-04 13:39 ` Avri Altman
@ 2019-09-04 19:49 ` Manivannan Sadhasivam
2019-09-07 20:43 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2019-09-04 19:49 UTC (permalink / raw)
To: YueHaibing, alim.akhtar, avri.altman, pedrom.sousa, jejb,
martin.petersen, liwei213, dimitrysh, kjlu, tglx, yuehaibing,
stanley.chu, arnd
Cc: linux-scsi, linux-kernel
On 4 September 2019 6:34:57 PM IST, YueHaibing <yuehaibing@huawei.com> wrote:
>Use devm_platform_ioremap_resource() to simplify the code a bit.
>This is detected by coccinelle.
>
>Reported-by: Hulk Robot <hulkci@huawei.com>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
>---
> drivers/scsi/ufs/ufs-hisi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
>index f4d1dca..6bbb167 100644
>--- a/drivers/scsi/ufs/ufs-hisi.c
>+++ b/drivers/scsi/ufs/ufs-hisi.c
>@@ -447,13 +447,11 @@ static int ufs_hisi_resume(struct ufs_hba *hba,
>enum ufs_pm_op pm_op)
>
> static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
> {
>- struct resource *mem_res;
> struct device *dev = host->hba->dev;
> struct platform_device *pdev = to_platform_device(dev);
>
> /* get resource of ufs sys ctrl */
>- mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>- host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
>+ host->ufs_sys_ctrl = devm_platform_ioremap_resource(pdev, 1);
> if (IS_ERR(host->ufs_sys_ctrl))
> return PTR_ERR(host->ufs_sys_ctrl);
>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code
2019-09-04 13:04 [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-04 13:39 ` Avri Altman
2019-09-04 19:49 ` Manivannan Sadhasivam
@ 2019-09-07 20:43 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-09-07 20:43 UTC (permalink / raw)
To: YueHaibing
Cc: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
liwei213, dimitrysh, kjlu, tglx, manivannan.sadhasivam,
stanley.chu, arnd, linux-scsi, linux-kernel
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-07 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 13:04 [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-04 13:39 ` Avri Altman
2019-09-04 19:49 ` Manivannan Sadhasivam
2019-09-07 20:43 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).