From: Shachar Kagan <skagan@nvidia.com>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Ruben Vestergaard <rubenv@drcmr.dk>,
Torkil Svensgaard <torkil@drcmr.dk>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] nfsd: don't free files unconditionally in __nfsd_file_cache_purge
Date: Mon, 23 Jan 2023 10:57:55 +0000 [thread overview]
Message-ID: <MN2PR12MB44865F3CA7F74F93920B9DFFB9C89@MN2PR12MB4486.namprd12.prod.outlook.com> (raw)
In-Reply-To: <376AEBC5-AC52-424C-9DD0-A70BA73E7FE9@oracle.com>
>> On Jan 22, 2023, at 9:58 AM, Shachar Kagan <skagan@nvidia.com> wrote:
>>
>>> On Sat, 2023-01-21 at 17:04 +0000, Chuck Lever III wrote:
>>>>
>>>>> On Jan 20, 2023, at 3:54 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>>>
>>>>> On Fri, 2023-01-20 at 20:21 +0000, Chuck Lever III wrote:
>>>>>>
>>>>>>> On Jan 20, 2023, at 2:52 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>>>>>
>>>>>>> nfsd_file_cache_purge is called when the server is shutting down,
>>>>>>> in which case, tearing things down is generally fine, but it also
>>>>>>> gets called when the exports cache is flushed.
>>>>>>
>>>>>> Yeah... cache flush is probably the case we've been missing.
>>>>>>
>>>>>>
>>>>>>> Instead of walking the cache and freeing everything
>>>>>>> unconditionally, handle it the same as when we have a notification of conflicting access.
>>>>>>>
>>>>>>> Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
>>>>>>> Reported-by: Ruben Vestergaard <rubenv@drcmr.dk>
>>>>>>> Reported-by: Torkil Svensgaard <torkil@drcmr.dk>
>>>>>>> Reported-by: Shachar Kagan <skagan@nvidia.com>
>>>>>>> Signed-off-by: Jeff Layton <jlayton@kernel.org>
>>
>> I ran our tests with the commit, the issue didn't occur.
>> Thanks for the quick response.
>
> May I add Tested-by: Shachar Kagan <skagan@nvidia.com> ?
>
Yes
> --
> Chuck Lever
--
Shachar Kagan
next prev parent reply other threads:[~2023-01-23 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 19:52 [PATCH] nfsd: don't free files unconditionally in __nfsd_file_cache_purge Jeff Layton
2023-01-20 20:21 ` Chuck Lever III
2023-01-20 20:54 ` Jeff Layton
2023-01-21 17:04 ` Chuck Lever III
2023-01-21 17:20 ` Jeff Layton
2023-01-22 14:58 ` Shachar Kagan
2023-01-22 23:40 ` Chuck Lever III
2023-01-23 10:57 ` Shachar Kagan [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 19:20 Jeff Layton
2023-01-19 22:59 ` Chuck Lever III
2023-01-19 23:29 ` Jeff Layton
2023-01-20 18:36 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB44865F3CA7F74F93920B9DFFB9C89@MN2PR12MB4486.namprd12.prod.outlook.com \
--to=skagan@nvidia.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rubenv@drcmr.dk \
--cc=torkil@drcmr.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).