From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CD2C1B0D8 for ; Thu, 10 Dec 2020 15:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C12723DE5 for ; Thu, 10 Dec 2020 15:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391908AbgLJPmY (ORCPT ); Thu, 10 Dec 2020 10:42:24 -0500 Received: from mail-dm6nam11on2087.outbound.protection.outlook.com ([40.107.223.87]:10618 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389899AbgLJPmO (ORCPT ); Thu, 10 Dec 2020 10:42:14 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fxKJ0uSwN6UFUJi1C4IYQZmVUSu1zzntcnvUIP7kBu1W1OgRmvEF9LrUl2fTTki9QV+Ps71Dcfkj2pxf1MRQu/x7oLJG/qttBaWLSz3ilpzqT1Y3+lxiYPmdIYBP4MPOBJB0dSILYwwS6Bn3QFUGB0EdeFQNisybkp59XZx3HqCmNIfv5UNPGL/LSMycjvFE7PMk/eHgcO9sz/dW2ZAqbR75xEv3YLOFfHkYC9KmzeAHE/c7jdo3VghlMbpIijBnttspDRt9S5mq8J68QsS5rDiHAO9KoXE5UMzigDDqQCuTUGXjQfaV5j0/T9OnF4SbJGme5bk5LGGXbn8omWN0SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bcD5nwKlaNlGVGFDqHGETHTtLBu4puJd3hbotL39m+Y=; b=AXMWJDo1iDSYff3EQ15HbKjt4PRs+9H0CXHhzPGq3nX9JG+h/AH4mtT/xdvqvHt+UdvXWbE4puuB2/uDLzKnW4dohBhNviXDHnJ4oavxH1LrmH4UJ8ymu90SADegYOdd5Yh+Nzx93VkOpqycA/1j6ib+y/fqfu4RHrysk4HIhqbbicgoD+bbd8nox199UZTbfVCHg6EZ5JJhaS7o2FZ655gBgIBi+4Pr+7N3rwV1oLuRQsAPIZ9MIF3xiRKqCrxtxF+HlsLtuaL+j3jlEoqed8697ud6E1FJCwAXqtFR77MM/nAL5n57OMzqw/Uzjf9luuuyYez6bfDnLIaXhkZLDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bcD5nwKlaNlGVGFDqHGETHTtLBu4puJd3hbotL39m+Y=; b=ctJI/PzwcutADySCaD92xUOLbQOT2eMTQCWO9cWIoC11xUQQg7RQoRFaAgG7xeL99/dEsMqx+7cgaRGkOm5O4/vvn+2hcSSDK7PeQ5ffh+bt1wtQ7ANw+L8sE5nOEnniWNQWxy6hDgYlPxfN9dvyULWG06hNSPWRQhfIRDfoqzA= Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by BL0PR12MB4995.namprd12.prod.outlook.com (2603:10b6:208:1c7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 10 Dec 2020 15:36:36 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::fca3:155c:bf43:94af]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::fca3:155c:bf43:94af%5]) with mapi id 15.20.3632.019; Thu, 10 Dec 2020 15:36:36 +0000 From: "Deucher, Alexander" To: "Merger, Edgar [AUTOSOL/MAS/AUGS]" , "Huang, Ray" , "Kuehling, Felix" CC: Will Deacon , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Bjorn Helgaas , Joerg Roedel , "Zhu, Changfeng" Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken Thread-Topic: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken Thread-Index: AQHWwZ6+dZH+wAWtiUyhnWNLDE7tj6nWM/hwgAAaPwCAAATSgIAAg9SAgAAMxACAAH6N8IAA/GuAgAA1X4CAAA1TAIAAY5nQgAEjpACABpYzYIAKZ9UAgAHM64CAAYupgIAAamgAgAFXGACAAFBKAA== Date: Thu, 10 Dec 2020 15:36:36 +0000 Message-ID: References: <20201123134410.10648-1-will@kernel.org> <20201123223356.GC12069@willie-the-truck> <218017ab-defd-c77d-9055-286bf49bee86@amd.com> <20201124064301.GA536919@hr-amd> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-11-24T15:01:54Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=de2f7a10-55c4-48b3-9a56-00005e730a8e; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-12-10T15:36:29Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: ed015714-d465-48f7-829d-00005fcc805d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 dlp-product: dlpe-windows dlp-version: 11.5.0.60 dlp-reaction: no-action authentication-results: emerson.com; dkim=none (message not signed) header.d=none;emerson.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.84.11] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3419f99f-8cc0-4ca1-8dfa-08d89d21613f x-ms-traffictypediagnostic: BL0PR12MB4995: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2g1rcQHry2/0S+SLFbN2OPC47JDBgpBc4i27uElG2fXuB5A1emXKNIjcocJLcn4gb8YEVGgQttVYARmkA+g1hR4pUcmyiRKAAA1KpCovZJZcVdoXfHbBRCCyMQ71N3UimTEeNpi8m8CuYU7CXVnr2EO7DR/UZI7+ImvLDAmoA7qseKflDCbPj3nH3ITnbgaJYTYvKomMeVMG838hWiZyS/8uQeR70qOs688XM3AqTe2W+YRM4nj5ocVJE5CQcD+4PyjSIFnSmpMzTCg2WxF4vItoUOkupCA4rn4zVp63NKaYvOQDAykGpuvudsWUBUDNbFLftVQpkHGX3N1Iz1pZCc2d0At1lShBTHC0dpg6XZIkaMvvIgHgQxMi/6RKbeG6PFrb2JNObNOW0PE5a1j6rO5Vc1X/dCaPv64XphELvyjenCWXXjtKWBLGiHpadvbZMP2g2kSusSMPfrG1D7l2Mg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(136003)(30864003)(8936002)(54906003)(64756008)(86362001)(83380400001)(66476007)(66946007)(26005)(7696005)(5660300002)(76116006)(508600001)(110136005)(186003)(45080400002)(66446008)(19627235002)(33656002)(66556008)(52536014)(6636002)(966005)(4001150100001)(71200400001)(6506007)(53546011)(4326008)(8676002)(2906002)(55016002)(9686003)(579004)(559001)(505234006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?xHeKPhte5F3t3Nm7DALnsG1+qilrzhqYtbZNmio0DpBmcSAxP1gXnCNCs9?= =?iso-8859-1?Q?sDK/VWJNXFckhfOR0ZxjkInKhomVFon2b2jd323sMjqCVvmq4XfN3dNqj/?= =?iso-8859-1?Q?gMu+q6ZohpSgUCTopFu1R5u0M0QwiEH9iyav5fbW4lQIBnZDx8o+RnOPcI?= =?iso-8859-1?Q?HnCQyufx6WzZk2YMSL6dfXET6GrSCfms22gYUz5YQOl1rLdY6EySA8RhZ2?= =?iso-8859-1?Q?nC9Cj1+sM51jupPYV0ZKTHjQD8M1Jb52ywCyawgOresneGnzB4pZHsWDpq?= =?iso-8859-1?Q?M3UgcxQKkKdU5HkyGUQNA8u5K0qpsPcjagNxdY+rx/rGKLdusPE22Notj/?= =?iso-8859-1?Q?7qXgjqvfN3pKXviWFRES0HVKkTNzD/CI4EO4D07uAsPtOaEnWlmMWwf5qb?= =?iso-8859-1?Q?GqlnNwk3fbG3N+vhcrJ477Rc0Ad4E0jttMte1yA7P5xFoAOtsAauq3P9Sl?= =?iso-8859-1?Q?XWdlmZp/i+9L4o32WjEN9w5bxG0t7KihYZqKcftgGgRQdXKpb9tjnX1R5V?= =?iso-8859-1?Q?TC5pgvPsTCP9VQ+24Sp5A/aLfouR/7CiHcBiee3m4FIeT7/vGzCX+JulCu?= =?iso-8859-1?Q?NXfmkKR7SXSstbY5O1CGC3jDjy47N3DdB7q2U0k4962NDO14i8FtRe2ifr?= =?iso-8859-1?Q?LeF7FiD5DrETviBNNSh0YZvBdjHDQXk1RLlPxaPBllnBhfWn8K9351RXad?= =?iso-8859-1?Q?Y0ucbIEf+zv9Ce6Id+bWsSlcJkqMbiXSu+0Ht1+dFvL0g8lqeYR9KNvogF?= =?iso-8859-1?Q?fFigYA5YjyTQ0ofedUnDR8l99II9JNH6JQ5tNKc2u3ajfvaZsXBIt5o+cG?= =?iso-8859-1?Q?POY0S4QDilgx+EH48jochkAlobNw0crlNEtSyTSneinWcJM/1SReqWY5H9?= =?iso-8859-1?Q?9EQ22zH7pLhoBJ3uD7d2DYpq/HBtRNirR5d6J2LvNAiC+9BtZHj0P4mvPS?= =?iso-8859-1?Q?dsLMDf+R7F31AULixbEMAKwRLM06xp/61scauol/zfnyQq/Vjmpr2Y8P87?= =?iso-8859-1?Q?EhqInz7IH9/38Pj8Q=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3419f99f-8cc0-4ca1-8dfa-08d89d21613f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 15:36:36.3195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qaY29FMtVuUscTQYYZ2LLbeUyQIRTI5HOwnhPRvV2ndER/lDUuz1QRyyWJkR7WLweTzdNBdXz7pYPTjCHC79Ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4995 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [AMD Public Use] > -----Original Message----- > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > Sent: Thursday, December 10, 2020 5:48 AM > To: Deucher, Alexander ; Huang, Ray=20 > ; Kuehling, Felix > Cc: Will Deacon ; linux-kernel@vger.kernel.org;=20 > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn=20 > Helgaas ; Joerg Roedel ; Zhu,=20 > Changfeng > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > broken >=20 > Alright. Done that. > This should be it finally I believe. > Which will be the initial kernel-version that incorporates that? Looks good to me. Bjorn, can you pick this up for PCI? Alex >=20 > -----Original Message----- > From: Deucher, Alexander > Sent: Mittwoch, 9. Dezember 2020 15:24 > To: Merger, Edgar [AUTOSOL/MAS/AUGS] ;=20 > Huang, Ray ; Kuehling, Felix=20 > > Cc: Will Deacon ; linux-kernel@vger.kernel.org;=20 > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn=20 > Helgaas ; Joerg Roedel ; Zhu,=20 > Changfeng > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > broken >=20 > [AMD Public Use] >=20 > > -----Original Message----- > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > Sent: Wednesday, December 9, 2020 2:59 AM > > To: Deucher, Alexander ; Huang, Ray=20 > > ; Kuehling, Felix > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn=20 > > Helgaas ; Joerg Roedel ; Zhu,=20 > > Changfeng > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > > broken > > > > Alex, > > > > I had to revise the patch. Please see attachment. It is actually two=20 > > more SSIDs affected to that. >=20 > Other than some minor whitespace issues, the patch looks fine to me. > Please align the subsystem_device lines and put the closing=20 > parenthesis on the same line as the last check. >=20 > Thanks! >=20 > Alex >=20 > > > > Best regards, > > Edgar > > > > -----Original Message----- > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > Sent: Dienstag, 8. Dezember 2020 09:23 > > To: 'Deucher, Alexander' ; 'Huang, Ray' > > ; 'Kuehling, Felix' > > Cc: 'Will Deacon' ; 'linux-kernel@vger.kernel.org' > > ; 'linux-pci@vger.kernel.org' > pci@vger.kernel.org>; 'iommu@lists.linux-foundation.org' > > ; 'Bjorn Helgaas' > > ; 'Joerg Roedel' ; 'Zhu,=20 > > Changfeng' > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > > broken > > > > Applied the patch as in attachment. Verified that ATS for GPU-Device=20 > > had been disabled. See attachment "dmesg_ATS.log". > > > > Was running that build over night successfully. > > > > -----Original Message----- > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > Sent: Montag, 7. Dezember 2020 05:53 > > To: Deucher, Alexander ; Huang, Ray=20 > > ; Kuehling, Felix > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn=20 > > Helgaas ; Joerg Roedel ; Zhu,=20 > > Changfeng > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > > broken > > > > Hi Alex, > > > > I believe in the patch file, this > > + (pdev->subsystem_device =3D=3D 0x0c19 || > > + pdev->subsystem_device =3D=3D 0x0c10)) > > > > Has to be changed to: > > + (pdev->subsystem_device =3D=3D 0xce19 || > > + pdev->subsystem_device =3D=3D 0xcc10)) > > > > Because our SSIDs are "ea50:ce19" and "ea50:cc10" respectively and=20 > > another one would "ea50:cc08". > > > > I will apply that patch and feedback the results soon plus the patch=20 > > file that I actually had applied. > > > > > > -----Original Message----- > > From: Deucher, Alexander > > Sent: Montag, 30. November 2020 19:36 > > To: Merger, Edgar [AUTOSOL/MAS/AUGS] > ; > > Huang, Ray ; Kuehling, Felix=20 > > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn=20 > > Helgaas ; Joerg Roedel ; Zhu,=20 > > Changfeng > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > > broken > > > > [AMD Public Use] > > > > > -----Original Message----- > > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > > > Sent: Thursday, November 26, 2020 4:24 AM > > > To: Deucher, Alexander ; Huang, Ray=20 > > > ; Kuehling, Felix > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > Bjorn Helgaas ; Joerg Roedel=20 > > > ; Zhu, Changfeng > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > as broken > > > > > > Alex, > > > > > > This is pretty much the same patch as what I have received from=20 > > > Joerg previously, except that it is tied to the particular Emerson=20 > > > platform and its derivatives (listed with Subsystem IDs). > > > > Right. As per my original point, I don't want to disable ATS on all=20 > > Picasso chips because doing so would break GPU compute on them, so=20 > > I'd like to apply this quirk as narrowly as possible. > > > > > > > > Below patch was what Joerg provided me and I successfully tested. > > > > > > This diff to the kernel should do that: > > > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index=20 > > > f70692ac79c5..3911b0ec57ba 100644 > > > --- a/drivers/pci/quirks.c > > > +++ b/drivers/pci/quirks.c > > > @@ -5176,6 +5176,8 @@ > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, > > > 0x6900, quirk_amd_harvest_no_ats);=20 > > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7312,=20 > > > quirk_amd_harvest_no_ats); > > > /* AMD Navi14 dGPU */ > > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7340,=20 > > > quirk_amd_harvest_no_ats); > > > +/* AMD Raven platform iGPU */ > > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x15d8,=20 > > > +quirk_amd_harvest_no_ats); > > > #endif /* CONFIG_PCI_ATS */ > > > > > > /* Freescale PCIe doesn't support MSI in RC mode */ > > > > > > So far I have seen this issue on two instances of this chip, but I=20 > > > must admit that I did test only two of them to this extent, so I=20 > > > guess it is not a bad chip in particular, but the chips we use are=20 > > > from the same production lot, so it might be a systematical=20 > > > problem of that > > production lot? > > > > > > UEFI-Setup shows: > > > Processor Family: 17h > > > Procossor Model: 20h - 2Fh > > > CPUID: 00820F01 > > > Microcode Patch Level: 8200103 > > > > > > Looking at the chip-die I found that this is a fully qualified IP=20 > > > Silicon (according to Ryzen Embedded R1000 SOC Interlock). > > > YE1305C9T20FG > > > BI2015SUY > > > 9JB6496P00123 > > > 2016 AMD > > > DIFFUSED IN USA > > > MADE IN CHINA > > > > > > Currently used SBIOS is a branch from "EmbeddedPI-FP5 1.2.0.3RC3". > > > > > > In the future our SBIOS might merge with EmbeddedPI-FP5_1.2.0.5RC3. > > > > > > > I think it's more likely an sbios issue, so hopefully the new release f= ixes it. > > > > Alex > > > > > > > > > > > > > > -----Original Message----- > > > From: Deucher, Alexander > > > Sent: Mittwoch, 25. November 2020 17:08 > > > To: Merger, Edgar [AUTOSOL/MAS/AUGS] > > ; > > > Huang, Ray ; Kuehling, Felix=20 > > > > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > Bjorn Helgaas ; Joerg Roedel=20 > > > ; Zhu, Changfeng > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > as broken > > > > > > [AMD Public Use] > > > > > > > -----Original Message----- > > > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > > > > > Sent: Wednesday, November 25, 2020 5:04 AM > > > > To: Deucher, Alexander ; Huang, Ray=20 > > > > ; Kuehling, Felix > > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > > Bjorn Helgaas ; Joerg Roedel=20 > > > > ; Zhu, Changfeng > > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > > as broken > > > > > > > > I do have also other problems with this unit, when IOMMU is=20 > > > > enabled and pci=3Dnoats is not set as kernel parameter. > > > > > > > > [ 2004.265906] amdgpu 0000:0b:00.0: [drm:amdgpu_ib_ring_tests=20 > > > > [amdgpu]] > > > > *ERROR* IB test failed on gfx (-110). > > > > [ 2004.266024] [drm:amdgpu_device_delayed_init_work_handler > > > [amdgpu]] > > > > *ERROR* ib ring test failed (-110). > > > > > > > > > > Is this seen on all instances of this chip or only specific silicon? > > > I.e., could this be a bad chip? Would it be possible to test a=20 > > > newer sbios? I think the attached patch should work if we can't=20 > > > get it fixed on the platform side. It should only enable the=20 > > > quirk on your > > particular platform. > > > > > > Alex > > > > > > > > > > -----Original Message----- > > > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > > Sent: Mittwoch, 25. November 2020 10:16 > > > > To: 'Deucher, Alexander' ; 'Huang, > Ray' > > > > ; 'Kuehling, Felix' > > > > Cc: 'Will Deacon' ; 'linux-kernel@vger.kernel.org' > > > > ; 'linux-pci@vger.kernel.org' > > > > ; 'iommu@lists.linux-foundation.org' > > > > ; 'Bjorn Helgaas' > > > > ; 'Joerg Roedel' ; 'Zhu,=20 > > > > Changfeng' > > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > > as broken > > > > > > > > Remark: > > > > > > > > Systems with R1305G APU (which show the issue) have the=20 > > > > following > > > > VGA- > > > > Controller: > > > > 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > > > > [AMD/ATI] Picasso (rev cf) > > > > > > > > Systems with V1404I APU (which do not show the issue) have the=20 > > > > following > > > > VGA-Controller: > > > > 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > > > > [AMD/ATI] Raven Ridge [Radeon Vega Series / Radeon Vega Mobile=20 > > > > Series] (rev 83) > > > > > > > > "rev cf" vs. "ref 83" is probably what you where referring to=20 > > > > with PCI Revision ID. > > > > > > > > -----Original Message----- > > > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > > Sent: Mittwoch, 25. November 2020 07:05 > > > > To: 'Deucher, Alexander' ; Huang, Ray=20 > > > > ; Kuehling, Felix > > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > > Bjorn Helgaas ; Joerg Roedel=20 > > > > ; Zhu, Changfeng > > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > > as broken > > > > > > > > I see that problem only on systems that use a R1305G APU > > > > > > > > sudo cat /sys/kernel/debug/dri/0/amdgpu_firmware_info > > > > > > > > shows > > > > > > > > VCE feature version: 0, firmware version: 0x00000000 UVD feature > > > > version: 0, firmware version: 0x00000000 MC feature version: 0,=20 > > > > firmware > > > version: > > > > 0x00000000 ME feature version: 50, firmware version: 0x000000a3=20 > > > > PFP feature version: 50, firmware version: 0x000000bb CE feature > version: > > > > 50, firmware version: 0x0000004f RLC feature version: 1,=20 > > > > firmware > > version: > > > > 0x00000049 RLC SRLC feature version: 1, firmware version: > > > > 0x00000001 RLC SRLG feature version: 1, firmware version: > > > > 0x00000001 RLC SRLS feature > > > > version: 1, firmware version: 0x00000001 MEC feature version:=20 > > > > 50, firmware > > > > version: 0x000001b5 > > > > MEC2 feature version: 50, firmware version: 0x000001b5 SOS=20 > > > > feature > > > version: > > > > 0, firmware version: 0x00000000 ASD feature version: 0, firmware > > version: > > > > 0x21000030 TA XGMI feature version: 0, firmware version: > > > > 0x00000000 TA RAS feature version: 0, firmware version:=20 > > > > 0x00000000 SMC feature > > > > version: 0, firmware version: 0x00002527 > > > > SDMA0 feature version: 41, firmware version: 0x000000a9 VCN=20 > > > > feature > > > > version: 0, firmware version: 0x0110901c DMCU feature version:=20 > > > > 0, firmware > > > > version: 0x00000001 VBIOS version: 113-RAVEN2-117 > > > > > > > > We are also using V1404I APU on the same boards and I haven=B4t=20 > > > > seen the issue on those boards > > > > > > > > These boards give me slightly different info: sudo cat=20 > > > > /sys/kernel/debug/dri/0/amdgpu_firmware_info > > > > > > > > VCE feature version: 0, firmware version: 0x00000000 UVD feature > > > > version: 0, firmware version: 0x00000000 MC feature version: 0,=20 > > > > firmware > > > version: > > > > 0x00000000 ME feature version: 47, firmware version: 0x000000a2=20 > > > > PFP feature version: 47, firmware version: 0x000000b9 CE feature > version: > > > > 47, firmware version: 0x0000004e RLC feature version: 1,=20 > > > > firmware > > version: > > > > 0x00000213 RLC SRLC feature version: 1, firmware version: > > > > 0x00000001 RLC SRLG feature version: 1, firmware version: > > > > 0x00000001 RLC SRLS feature > > > > version: 1, firmware version: 0x00000001 MEC feature version:=20 > > > > 47, firmware > > > > version: 0x000001ab > > > > MEC2 feature version: 47, firmware version: 0x000001ab SOS=20 > > > > feature > > > version: > > > > 0, firmware version: 0x00000000 ASD feature version: 0, firmware > > version: > > > > 0x21000013 TA XGMI feature version: 0, firmware version: > > > > 0x00000000 TA RAS feature version: 0, firmware version:=20 > > > > 0x00000000 SMC feature > > > > version: 0, firmware version: 0x00001e5b > > > > SDMA0 feature version: 41, firmware version: 0x000000a9 VCN=20 > > > > feature > > > > version: 0, firmware version: 0x0110901c DMCU feature version:=20 > > > > 0, firmware > > > > version: 0x00000000 VBIOS version: 113-RAVEN-116 > > > > > > > > > > > > > > > > > > > > 00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Root Complex > > > > 00:00.2 IOMMU: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 > > > IOMMU > > > > 00:01.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family=20 > > > > 17h (Models > > > > 00h-1fh) PCIe Dummy Host Bridge > > > > 00:01.1 PCI bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 PCIe GPP Bridge [6:0] > > > > 00:01.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin=20 > > > > Switch Upstream (PCIE SW.US) > > > > 00:01.4 PCI bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 PCIe GPP Bridge [6:0] > > > > 00:01.5 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin=20 > > > > Switch Upstream (PCIE SW.US) > > > > 00:08.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family=20 > > > > 17h (Models > > > > 00h-1fh) PCIe Dummy Host Bridge > > > > 00:08.1 PCI bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Internal PCIe GPP Bridge 0 to Bus A > > > > 00:08.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Internal PCIe GPP Bridge 0 to Bus B > > > > 00:14.0 SMBus: Advanced Micro Devices, Inc. [AMD] FCH SMBus=20 > > > > Controller (rev 61) > > > > 00:14.3 ISA bridge: Advanced Micro Devices, Inc. [AMD] FCH LPC=20 > > > > Bridge (rev > > > > 51) > > > > 00:18.0 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 0 > > > > 00:18.1 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 1 > > > > 00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 2 > > > > 00:18.3 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 3 > > > > 00:18.4 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 4 > > > > 00:18.5 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 5 > > > > 00:18.6 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 6 > > > > 00:18.7 Host bridge: Advanced Micro Devices, Inc. [AMD] > > > > Raven/Raven2 Device 24: Function 7 > > > > 01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. > > > > RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev=20 > > > > 0e) > > > > 01:00.1 Serial controller: Realtek Semiconductor Co., Ltd.=20 > > > > Device 816a (rev 0e) > > > > 01:00.2 Serial controller: Realtek Semiconductor Co., Ltd.=20 > > > > Device 816b (rev 0e) > > > > 01:00.3 IPMI Interface: Realtek Semiconductor Co., Ltd. Device=20 > > > > 816c (rev 0e) > > > > 01:00.4 USB controller: Realtek Semiconductor Co., Ltd. Device=20 > > > > 816d (rev 0e) > > > > 02:00.0 Ethernet controller: Intel Corporation I210 Gigabit=20 > > > > Network Connection (rev 03) > > > > 03:00.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 04:01.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 04:02.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 04:03.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 04:04.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 04:05.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 > > > > 6-Port/8- Lane Packet Switch > > > > 06:00.0 Serial controller: Asix Electronics Corporation Device > > > > 9100 > > > > 06:00.1 Serial controller: Asix Electronics Corporation Device > > > > 9100 > > > > 07:00.0 Ethernet controller: Intel Corporation I210 Gigabit=20 > > > > Network Connection (rev 03) > > > > 0a:00.0 Ethernet controller: Intel Corporation I210 Gigabit=20 > > > > Network Connection (rev 03) > > > > 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > > > > [AMD/ATI] Picasso (rev cf) > > > > 0b:00.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI]=20 > > > > Raven/Raven2/Fenghuang HDMI/DP Audio Controller > > > > 0b:00.2 Encryption controller: Advanced Micro Devices, Inc.=20 > > > > [AMD] Family 17h (Models 10h-1fh) Platform Security Processor > > > > 0b:00.3 USB controller: Advanced Micro Devices, Inc. [AMD]=20 > > > > Raven2 USB > > > > 3.1 > > > > 0b:00.5 Multimedia controller: Advanced Micro Devices, Inc.=20 > > > > [AMD] Raven/Raven2/FireFlight/Renoir Audio Processor > > > > 0b:00.7 Non-VGA unclassified device: Advanced Micro Devices, Inc. > > > > [AMD] Raven/Raven2/Renoir Non-Sensor Fusion Hub KMDF driver > > > > 0c:00.0 SATA controller: Advanced Micro Devices, Inc. [AMD] FCH=20 > > > > SATA Controller [AHCI mode] (rev 61) > > > > > > > > PCI Revision ID is 06 I believe. Got that from this lspci -xx > > > > > > > > 00:01.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin=20 > > > > Switch Upstream (PCIE SW.US) > > > > 00: 22 10 5d 14 07 04 10 00 00 00 04 06 10 00 81 00 > > > > 10: 00 00 00 00 00 00 00 00 00 02 02 00 f1 01 00 00 > > > > 20: e0 fc e0 fc f1 ff 01 00 00 00 00 00 00 00 00 00 > > > > 30: 00 00 00 00 50 00 00 00 00 00 00 00 ff 00 12 00 > > > > 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > > 50: 01 58 03 c8 00 00 00 00 10 a0 42 01 22 80 00 00 > > > > 60: 1f 29 00 00 13 38 73 03 42 00 11 30 00 00 04 00 > > > > 70: 00 00 40 01 18 00 01 00 00 00 00 00 bf 01 70 00 > > > > 80: 06 00 00 00 0e 00 00 00 03 00 01 00 00 00 00 00 > > > > 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > > a0: 05 c0 81 00 00 00 e0 fe 00 00 00 00 00 00 00 00 > > > > b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > > c0: 0d c8 00 00 22 10 34 12 08 00 03 a8 00 00 00 00 > > > > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > > e0: 00 00 00 00 4c 8a 05 00 00 00 00 00 00 00 00 00 > > > > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > > > > > > > -----Original Message----- > > > > From: Deucher, Alexander > > > > Sent: Dienstag, 24. November 2020 16:06 > > > > To: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > ; > > > > Huang, Ray ; Kuehling, Felix=20 > > > > > > > > Cc: Will Deacon ; linux-kernel@vger.kernel.org; > > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > > Bjorn Helgaas ; Joerg Roedel=20 > > > > ; Zhu, Changfeng > > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > > as broken > > > > > > > > [AMD Public Use] > > > > > > > > > -----Original Message----- > > > > > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > > > > > > > > > Sent: Tuesday, November 24, 2020 2:29 AM > > > > > To: Huang, Ray ; Kuehling, Felix=20 > > > > > > > > > > Cc: Will Deacon ; Deucher, Alexander=20 > > > > > ; linux-kernel@vger.kernel.org; > > > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > > > Bjorn Helgaas ; Joerg Roedel=20 > > > > > ; Zhu, > > > > Changfeng > > > > > > > > > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU=20 > > > > > ATS as broken > > > > > > > > > > Module Version : PiccasoCpu 10 > > > > > AGESA Version : PiccasoPI 100A > > > > > > > > > > I did not try to enter the system in any other way (like via > > > > > ssh) than via Desktop. > > > > > > > > You can get this information from the amdgpu driver. E.g., sudo=20 > > > > cat /sys/kernel/debug/dri/0/amdgpu_firmware_info . Also what is=20 > > > > the PCI revision id of your chip (from lspci)? Also are you=20 > > > > just seeing this on specific versions of the sbios? > > > > > > > > Thanks, > > > > > > > > Alex > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Huang Rui > > > > > Sent: Dienstag, 24. November 2020 07:43 > > > > > To: Kuehling, Felix > > > > > Cc: Will Deacon ; Deucher, Alexander=20 > > > > > ; linux-kernel@vger.kernel.org; > > > > > linux- pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > > > > Bjorn Helgaas ; Merger, Edgar > > [AUTOSOL/MAS/AUGS] > > > > > ; Joerg Roedel ; > > > > Changfeng > > > > > Zhu > > > > > Subject: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS=20 > > > > > as > > > > broken > > > > > > > > > > On Tue, Nov 24, 2020 at 06:51:11AM +0800, Kuehling, Felix wrote: > > > > > > On 2020-11-23 5:33 p.m., Will Deacon wrote: > > > > > > > On Mon, Nov 23, 2020 at 09:04:14PM +0000, Deucher,=20 > > > > > > > Alexander > > > wrote: > > > > > > >> [AMD Public Use] > > > > > > >> > > > > > > >>> -----Original Message----- > > > > > > >>> From: Will Deacon > > > > > > >>> Sent: Monday, November 23, 2020 8:44 AM > > > > > > >>> To: linux-kernel@vger.kernel.org > > > > > > >>> Cc: linux-pci@vger.kernel.org;=20 > > > > > > >>> iommu@lists.linux-foundation.org; Will Deacon=20 > > > > > > >>> ; Bjorn Helgaas ;=20 > > > > > > >>> Deucher, Alexander ; Edgar > > > Merger > > > > > > >>> ; Joerg Roedel > > > > > > > > >>> Subject: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken > > > > > > >>> > > > > > > >>> Edgar Merger reports that the AMD Raven GPU does not=20 > > > > > > >>> work reliably on his system when the IOMMU is enabled: > > > > > > >>> > > > > > > >>> | [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx=20 > > > > > > >>> timeout, signaled seq=3D1, emitted seq=3D3 > > > > > > >>> | [...] > > > > > > >>> | amdgpu 0000:0b:00.0: GPU reset begin! > > > > > > >>> | AMD-Vi: Completion-Wait loop timed out > > > > > > >>> | iommu ivhd0: AMD-Vi: Event logged=20 > > > > > > >>> [IOTLB_INV_TIMEOUT > > > > > > >>> device=3D0b:00.0 address=3D0x38edc0970] > > > > > > >>> > > > > > > >>> This is indicative of a hardware/platform configuration=20 > > > > > > >>> issue so, since disabling ATS has been shown to resolve=20 > > > > > > >>> the problem, add a quirk to match this particular device=20 > > > > > > >>> while Edgar follows-up with AMD > > > > > for more information. > > > > > > >>> > > > > > > >>> Cc: Bjorn Helgaas > > > > > > >>> Cc: Alex Deucher > > > > > > >>> Reported-by: Edgar Merger > > > > > > >>> Suggested-by: Joerg Roedel > > > > > > >>> Link: > > > > > > >>> > > > > > > > > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Furld > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > 3A__nam11.safelinks.p& > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C467e5e31a26440bd4 > c0d08d8 > > > 9cf98a9c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6374319428 > 869349 > > > 36%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > zIiLCJBTiI > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3Dq%2F2XCPX9jAIyCjZbej2q > arLwTai > > vnq3afaZPu%2BzlWp8%3D&reserved=3D0 > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > 252Furld&d=3DDwIFAw&c=3DjOU > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > 862rdSP1 > > > 3_P6LVp7j_9l1xmg&m=3DYkX6enlEevcTFbwL9p9WtRZLfFv4yrkYWGWII8q_ZSo > &s=3Dn3lC5 > > O0SPjN4j09x39L4oAOOQBED0Rc2xBoAmYeK7_o&e=3D > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > 3A__nam11.safelinks.p& > > > > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7Cb29c13165c224c3794 > > 2208d8 > > > > > > 9c185604%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637430975 > > 6442408 > > > > > > 26%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > > zIiLCJBTiI > > > > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D2uB%2FmMkuxi%2Bc2Xb > > MD%2FhKpcw > > > QUxH49QfbCShTd227RDw%3D&reserved=3D0 > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > 252Furld&d=3DDwIFAw&c=3DjOU > > > > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > 862rdSP1 > > > > > > 3_P6LVp7j_9l1xmg&m=3DBIpm40CYGVSJNrmoqPI4DeIayU0tYU2D5NpRwfbkZv > > A&s=3DtmsZ3 > > > ihrSXZ3g6wdJ2maxU9mJ1TGcRxd91z9IQTP00A&e=3D > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > > > 3A__nam11.safelinks.p&data=3D04%7C01%7CAlexander.Deucher%40amd > > > > > > .com%7C9194a443d95c4ffcb7f708d891ed0889%7C3dd8961fe4884e608e11a82 > > > > > > d994e183d%7C0%7C1%7C637419794843309283%7CUnknown%7CTWFpbGZsb > > > > > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > > > > > %3D%7C1000&sdata=3D4JGSwn7au4u%2FBB69mmq0%2BrWfVG12sEyd5H > > > oBUeiut9o%3D&reserved=3D0 > > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > > 252Furld&d=3DDwIFAw&c=3DjOU > > > > > > > > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > > 862rdSP1 > > > > 3_P6LVp7j_9l1xmg&m=3DZhN0Jau6oCc4cnz64IhGK2- > > > XDiD5D_6vW6ZYbifWYF0&s=3DndvE- > > > > ezxTBweMMUjyMWdiCyPB6GDIS_eWs0kmZwqtpY&e=3D > > > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > 3A__nam11.safelinks.p& > > > > > > > > > > > > > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C1d797071822d47ce6 > > > > c9808d8 > > > > > > > > > > > > > > > 9129698f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637418954 > > > > 3633797 > > > > > > > > > > > > > > > 99%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > > > > zIiLCJBTiI > > > > > > > > > > > > > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DVLlzQtS3KWZqQslcJKZYrG > > > > sj6eMk3 > > > > > VWaE%2BXhbNdRx80%3D&reserved=3D0 > > > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > > > 252Furld&d=3DDwIFAw&c=3DjOU > > > > > > > > > > > > > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > > > 862rdSP1 > > > > > 3_P6LVp7j_9l1xmg&m=3DMMI_EgCqeOX4EvIftpL7agRxJ- > > > > udp1CLokf2QWuzFgE&s=3DZLdz6 > > > > > OgavzNn2vSzsgyL1IB6MbK7hPKavOYwbLhyTPU&e=3D > > > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > > > > > > > > > > > > 3A__lore%26d%3DDwIDAw%26c%3DjOURTkCZzT8tVB5xPEYIm3YJGoxoTaQs > > > > > QPzPKJGaWbo%26r%3DBJxhacqqa4K1PJGm6_- > > > > > > > > > > > > > > > 862rdSP13_P6LVp7j_9l1xmg%26m%3DlNXu2xwvyxEZ3PzoVmXMBXXS55jsmf > > > > > > > > > > > > > > > DicuQFJqkIOH4%26s%3D_5VDNCRQdA7AhsvvZ3TJJtQZ2iBp9c9tFHIleTYT_ZM > > > > > > > > > > > > > > > %26e%3D&data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C6d5f > > > > > > > > > > > > > > > a241f9634692c03908d8904a942c%7C3dd8961fe4884e608e11a82d994e183d%7 > > > > > > > > > > > > > > > C0%7C0%7C637417997272974427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > > > > > > > > > > > > > > > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C100 > > > > > > > > > > > > > > > 0&sdata=3DOEgYlw%2F1YP0C%2FnWBRQUxwBH56mGOJxYMWSQ%2Fj1Y > > > > > 9f6Q%3D&reserved=3D0 . > > > > > > >>> kernel.org/linux- > > > > > > >>> > > > > > > iommu/MWHPR10MB1310F042A30661D4158520B589FC0@MWHPR10M > > > > > > >>> B1310.namprd10.prod.outlook.com > > > > > > >>> > > > > > > > > > > > > > > > her%40amd.com%7C1a883fe14d0c408e7d9508d88fb5df4e%7C3dd8961fe488 > > > > > > >>> > > > > > > > > > > > > > > > 4e608e11a82d994e183d%7C0%7C0%7C637417358593629699%7CUnknown%7 > > > > > > >>> > > > > > > > > > > > > > > > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > > > > > > >>> > > > > > > > > > > > > > > > LCJXVCI6Mn0%3D%7C1000&sdata=3DTMgKldWzsX8XZ0l7q3%2BszDWXQJJ > > > > > > >>> LOUfX5oGaoLN8n%2B8%3D&reserved=3D0 > > > > > > >>> Signed-off-by: Will Deacon > > > > > > >>> --- > > > > > > >>> > > > > > > >>> Hi all, > > > > > > >>> > > > > > > >>> Since Joerg is away at the moment, I'm posting this to=20 > > > > > > >>> try to make some progress with the thread in the Link: tag. > > > > > > >> + Felix > > > > > > >> > > > > > > >> What system is this? Can you provide more details? Does=20 > > > > > > >> a sbios update fix this? Disabling ATS for all Ravens=20 > > > > > > >> will break GPU compute for a lot of people. I'd prefer=20 > > > > > > >> to just black list this particular system (e.g., just=20 > > > > > > >> SSIDs or > > > > > > >> revision) if > > possible. > > > > > > > > > > > > +Ray > > > > > > > > > > > > There are already many systems where the IOMMU is disabled=20 > > > > > > in the BIOS, or the CRAT table reporting the APU compute=20 > > > > > > capabilities is broken. Ray has been working on a fallback=20 > > > > > > to make APUs behave like dGPUs on such systems. That should=20 > > > > > > also cover this case where ATS is blacklisted. That said, it=20 > > > > > > affects the programming model, because we don't support the=20 > > > > > > unified and coherent memory model on dGPUs like we do on=20 > > > > > > APUs with > > IOMMUv2. > > > > > > So it would be good to > > > make > > > > > > the conditions for this workaround as narrow as possible. > > > > > > > > > > Yes, besides the comments from Alex and Felix, may we get your=20 > > > > > firmware version (SMC firmware which is from SBIOS) and device id= ? > > > > > > > > > > > >>> | [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx=20 > > > > > > >>> timeout, signaled seq=3D1, emitted seq=3D3 > > > > > > > > > > It looks only gfx ib test passed, and fails to lanuch desktop, am= I right? > > > > > > > > > > We would like to see whether it is Raven, Raven kicker (new=20 > > > > > Raven), or Picasso. In our side, per the internal test result,=20 > > > > > we didn't see the similiar issue on Raven kicker and Picasso plat= form. > > > > > > > > > > Thanks, > > > > > Ray > > > > > > > > > > > > > > > > > These are the relevant changes in KFD and Thunk for reference: > > > > > > > > > > > > ### KFD ### > > > > > > > > > > > > commit 914913ab04dfbcd0226ecb6bc99d276832ea2908 > > > > > > Author: Huang Rui > > > > > > Date:=A0=A0 Tue Aug 18 14:54:23 2020 +0800 > > > > > > > > > > > > =A0=A0=A0 drm/amdkfd: implement the dGPU fallback path for apu= =20 > > > > > > (v6) > > > > > > > > > > > > =A0=A0=A0 We still have a few iommu issues which need to addre= ss,=20 > > > > > > so force raven > > > > > > =A0=A0=A0 as "dgpu" path for the moment. > > > > > > > > > > > > =A0=A0=A0 This is to add the fallback path to bypass IOMMU if= =20 > > > > > > IOMMU > > > > > > v2 is disabled > > > > > > =A0=A0=A0 or ACPI CRAT table not correct. > > > > > > > > > > > > =A0=A0=A0 v2: Use ignore_crat parameter to decide whether it w= ill=20 > > > > > > go with IOMMUv2. > > > > > > =A0=A0=A0 v3: Align with existed thunk, don't change the way o= f=20 > > > > > > raven, only renoir > > > > > > =A0=A0=A0=A0=A0=A0=A0 will use "dgpu" path by default. > > > > > > =A0=A0=A0 v4: don't update global ignore_crat in the driver, a= nd=20 > > > > > > revise fallback > > > > > > =A0=A0=A0=A0=A0=A0=A0 function if CRAT is broken. > > > > > > =A0=A0=A0 v5: refine acpi crat good but no iommu support case,= =20 > > > > > > and rename the > > > > > > =A0=A0=A0=A0=A0=A0=A0 title. > > > > > > =A0=A0=A0 v6: fix the issue of dGPU initialized firstly, just= =20 > > > > > > modify the report > > > > > > =A0=A0=A0=A0=A0=A0=A0 value in the node_show(). > > > > > > > > > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > > > > > =A0=A0=A0 Reviewed-by: Felix Kuehling > > > > > > =A0=A0=A0 Signed-off-by: Alex Deucher > > > > > > > > > > > > ### Thunk ### > > > > > > > > > > > > commit e32482fa4b9ca398c8bdc303920abfd672592764 > > > > > > Author: Huang Rui > > > > > > Date:=A0=A0 Tue Aug 18 18:54:05 2020 +0800 > > > > > > > > > > > > =A0=A0=A0 libhsakmt: remove is_dgpu flag in the hsa_gfxip_tabl= e > > > > > > > > > > > > =A0=A0=A0 Whether use dgpu path will check the props which=20 > > > > > > exposed from > > > > kernel. > > > > > > =A0=A0=A0 We won't need hard code in the ASIC table. > > > > > > > > > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > > > > > =A0=A0=A0 Change-Id: I0c018a26b219914a41197ff36dbec7a75945d452 > > > > > > > > > > > > commit 7c60f6d912034aa67ed27b47a29221422423f5cc > > > > > > Author: Huang Rui > > > > > > Date:=A0=A0 Thu Jul 30 10:22:23 2020 +0800 > > > > > > > > > > > > =A0=A0=A0 libhsakmt: implement the method that using flag whic= h=20 > > > > > > exposed by kfd to configure is_dgpu > > > > > > > > > > > > =A0=A0=A0 KFD already implemented the fallback path for APU.=20 > > > > > > Thunk will use flag > > > > > > =A0=A0=A0 which exposed by kfd to configure is_dgpu instead of= =20 > > > > > > hardcode > > > > before. > > > > > > > > > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > > > > > =A0=A0=A0 Change-Id: I445f6cf668f9484dd06cd9ae1bb3cfe7428ec7eb > > > > > > > > > > > > Regards, > > > > > > =A0 Felix > > > > > > > > > > > > > > > > > > > Cheers, Alex. I'll have to defer to Edgar for the details,=20 > > > > > > > as my understanding from the original thread over at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Furld > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > 3A__nam11.safelinks.p& > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C467e5e31a26440bd4 > c0d08d8 > > > 9cf98a9c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6374319428 > 869349 > > > 36%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > zIiLCJBTiI > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3Dq%2F2XCPX9jAIyCjZbej2q > arLwTai > > vnq3afaZPu%2BzlWp8%3D&reserved=3D0 > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > 252Furld&d=3DDwIFAw&c=3DjOU > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > 862rdSP1 > > > 3_P6LVp7j_9l1xmg&m=3DYkX6enlEevcTFbwL9p9WtRZLfFv4yrkYWGWII8q_ZSo > &s=3Dn3lC5 > > O0SPjN4j09x39L4oAOOQBED0Rc2xBoAmYeK7_o&e=3D > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > 3A__nam11.safelinks.p& > > > > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7Cb29c13165c224c3794 > > 2208d8 > > > > > > 9c185604%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637430975 > > 6442408 > > > > > > 26%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > > zIiLCJBTiI > > > > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D2uB%2FmMkuxi%2Bc2Xb > > MD%2FhKpcw > > > QUxH49QfbCShTd227RDw%3D&reserved=3D0 > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > 252Furld&d=3DDwIFAw&c=3DjOU > > > > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > 862rdSP1 > > > > > > 3_P6LVp7j_9l1xmg&m=3DBIpm40CYGVSJNrmoqPI4DeIayU0tYU2D5NpRwfbkZv > > A&s=3DtmsZ3 > > > ihrSXZ3g6wdJ2maxU9mJ1TGcRxd91z9IQTP00A&e=3D > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > > > 3A__nam11.safelinks.p&data=3D04%7C01%7CAlexander.Deucher%40amd > > > > > > .com%7C9194a443d95c4ffcb7f708d891ed0889%7C3dd8961fe4884e608e11a82 > > > > > > d994e183d%7C0%7C1%7C637419794843309283%7CUnknown%7CTWFpbGZsb > > > > > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > > > > > %3D%7C1000&sdata=3D4JGSwn7au4u%2FBB69mmq0%2BrWfVG12sEyd5H > > > oBUeiut9o%3D&reserved=3D0 > > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > > 252Furld&d=3DDwIFAw&c=3DjOU > > > > > > > > > > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > > 862rdSP1 > > > > 3_P6LVp7j_9l1xmg&m=3DZhN0Jau6oCc4cnz64IhGK2- > > > XDiD5D_6vW6ZYbifWYF0&s=3DndvE- > > > > ezxTBweMMUjyMWdiCyPB6GDIS_eWs0kmZwqtpY&e=3D > > > > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > 3A__nam11.safelinks.p& > > > > > > > > > > > > > > > ;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C1d797071822d47ce6 > > > > c9808d8 > > > > > > > > > > > > > > > 9129698f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637418954 > > > > 3633797 > > > > > > > > > > > > > > > 99%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > > > > zIiLCJBTiI > > > > > > > > > > > > > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DVLlzQtS3KWZqQslcJKZYrG > > > > sj6eMk3 > > > > > VWaE%2BXhbNdRx80%3D&reserved=3D0 > > > > > rotection.outlook.com_-3Furl-3Dhttps-253A-252F- > > > > 252Fur&d=3DDwIFAw&c=3DjOURT > > > > > > > > > kCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > > > 862rdSP13_ > > > > > P6LVp7j_9l1xmg&m=3DMMI_EgCqeOX4EvIftpL7agRxJ- > > > > udp1CLokf2QWuzFgE&s=3DIPZRolk > > > > > y3TYlbWPsOkY37MbDdzwhc1b_LaE6JkaOkOo&e=3D > > > > > > > ldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > > > > > 3A__lore.kernel.org&a > > > > > > > > > > > > > > > > > > > > > > mp;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C6d5fa241f963469 > > > > > 2c039 > > > > > > > > > > > > > > > > > > > > > > 08d8904a942c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63741 > > > > > 79972 > > > > > > > > > > > > > > > > > > > > > > 72974427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi > > > > > V2luMzI > > > > > > > > > > > > > > > > > > > > > > iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DiKTPucGQqcRXET > > > > > QZiQz > > > > > > > j90WdJeCYDytdZHJ1ZiUyR%2FM%3D&reserved=3D0 > > > > > > > _linux- > > 2Diommu_MWHPR10MB1310CDB6829DDCF5EA84A14689150- > > > > > 40MWHPR10MB131 > > > > > > > > > > > > > > > > > > > > > > 0.namprd10.prod.outlook.com_&d=3DDwIDAw&c=3DjOURTkCZzT8tVB5xPEYIm3Y > > > > > JGoxo > > > > > > > TaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > > > > > 862rdSP13_P6LVp7j_9l1xmg&m=3DlNXu > > > > > > > > > > > > > > > > > > > > > > 2xwvyxEZ3PzoVmXMBXXS55jsmfDicuQFJqkIOH4&s=3DdsAVVJbD7gJIj3ctZpnnU > > > > > 60y21 > > > > > > > ijWZmZ8xmOK1cO_O0&e=3D > > > > > > > > > > > > > > is that this is a board developed by his company. > > > > > > > > > > > > > > Edgar -- please can you answer Alex's questions? > > > > > > > > > > > > > > Will