From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Matthew Wilcox <willy@infradead.org>
Cc: Joe Perches <joe@perches.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Ian Kent <raven@themaw.net>,
David Howells <dhowells@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
NetFilter <netfilter-devel@vger.kernel.org>,
David Airlie <airlied@linux.ie>
Subject: RE: clean up kernel_{read,write} & friends v2
Date: Thu, 28 May 2020 20:14:41 +0000 [thread overview]
Message-ID: <MN2PR12MB448898AB31147F34D4E3B3C1F78E0@MN2PR12MB4488.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20200528200600.GS23230@ZenIV.linux.org.uk>
[AMD Official Use Only - Internal Distribution Only]
> -----Original Message-----
> From: Al Viro <viro@ftp.linux.org.uk> On Behalf Of Al Viro
> Sent: Thursday, May 28, 2020 4:06 PM
> To: Matthew Wilcox <willy@infradead.org>
> Cc: Joe Perches <joe@perches.com>; Linus Torvalds <torvalds@linux-
> foundation.org>; Christoph Hellwig <hch@lst.de>; Ian Kent
> <raven@themaw.net>; David Howells <dhowells@redhat.com>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>; linux-fsdevel <linux-
> fsdevel@vger.kernel.org>; LSM List <linux-security-
> module@vger.kernel.org>; NetFilter <netfilter-devel@vger.kernel.org>;
> Deucher, Alexander <Alexander.Deucher@amd.com>; David Airlie
> <airlied@linux.ie>
> Subject: Re: clean up kernel_{read,write} & friends v2
>
> On Thu, May 28, 2020 at 12:44:41PM -0700, Matthew Wilcox wrote:
> > On Thu, May 28, 2020 at 08:33:40PM +0100, Al Viro wrote:
> > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote:
> > >
> > > > Hard limits at 80 really don't work well, especially with some of
> > > > the 25+ character length identifiers used today.
> > >
> > > IMO any such identifier is a good reason for a warning.
> > >
> > > The litmus test is actually very simple: how unpleasant would it be
> > > to mention the identifiers while discussing the code over the phone?
> >
> > Here's a good example of a function which should be taken out and shot:
> >
> > int
> amdgpu_atombios_get_leakage_vddc_based_on_leakage_params(struct
> > amdgpu_devic e *adev, ...
> > switch (frev) {
> > case 2:
> > switch (crev) {
> > ...
> > if (profile->ucElbVDDC_Num > 0) {
> > for (i = 0; i < profile->ucElbVDDC_Num; i++) {
> > if (vddc_id_buf[i] == virtual_voltage_id) {
> > for (j = 0; j < profile->ucLeakageBinNum; j++) {
> > if (vbios_voltage_id <= leakage_bin[j]) {
> > *vddc
> > = vddc_buf[j * profile->ucElbVDDC_Num + i];
> >
> > I mean, I get it that AMD want to show off just how studly a monitor
> > they support, but good grief ...
>
> I must respectfully disagree. It clearly needs to be hanged, drawn and
> quartered...
You found it necessary to add me to a random thread with no context to complain about the coding style? How about sending a patch to clean it up if you find it that unsavory.
Alex
next prev parent reply other threads:[~2020-05-28 20:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 5:40 clean up kernel_{read,write} & friends v2 Christoph Hellwig
2020-05-28 5:40 ` [PATCH 01/14] cachefiles: switch to kernel_write Christoph Hellwig
2020-05-28 5:40 ` [PATCH 02/14] autofs: " Christoph Hellwig
2020-05-28 5:40 ` [PATCH 03/14] bpfilter: " Christoph Hellwig
2020-05-28 5:40 ` [PATCH 04/14] fs: unexport __kernel_write Christoph Hellwig
2020-05-28 5:40 ` [PATCH 05/14] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-05-28 5:40 ` [PATCH 06/14] fs: remove the call_{read,write}_iter functions Christoph Hellwig
2020-05-28 18:56 ` Al Viro
2020-05-29 5:51 ` Christoph Hellwig
2020-05-28 5:40 ` [PATCH 07/14] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-05-28 5:40 ` [PATCH 08/14] fs: remove __vfs_write Christoph Hellwig
2020-05-28 5:40 ` [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-05-28 18:43 ` Linus Torvalds
2020-05-29 12:32 ` Christoph Hellwig
2020-05-31 23:59 ` Logan Gunthorpe
2020-05-28 19:00 ` Al Viro
2020-05-29 5:57 ` Christoph Hellwig
2020-05-29 13:37 ` Christoph Hellwig
2020-05-28 5:40 ` [PATCH 10/14] fs: add a __kernel_read helper Christoph Hellwig
2020-05-28 5:40 ` [PATCH 11/14] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-05-28 5:40 ` [PATCH 12/14] fs: implement kernel_read " Christoph Hellwig
2020-05-28 5:40 ` [PATCH 13/14] fs: remove __vfs_read Christoph Hellwig
2020-05-28 5:40 ` [PATCH 14/14] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
2020-05-28 19:03 ` Al Viro
2020-05-28 18:51 ` clean up kernel_{read,write} & friends v2 Linus Torvalds
2020-05-28 18:57 ` Sedat Dilek
2020-05-28 19:22 ` Joe Perches
2020-05-28 19:33 ` Al Viro
2020-05-28 19:44 ` Matthew Wilcox
2020-05-28 20:06 ` Al Viro
2020-05-28 20:14 ` Deucher, Alexander [this message]
2020-05-28 20:18 ` Joe Perches
2020-05-28 20:29 ` Dave Airlie
2020-05-28 21:03 ` Joe Perches
2020-05-28 20:17 ` David Howells
2020-05-28 21:20 ` Casey Schaufler
2020-05-29 13:08 ` David Laight
2020-05-29 19:19 ` Linus Torvalds
2020-05-29 22:02 ` Casey Schaufler
2020-05-29 23:12 ` [PATCH] checkpatch/coding-style: Allow 100 column lines Joe Perches
2020-05-30 22:14 ` Andreas Dilger
2020-05-30 23:15 ` Joe Perches
2020-06-05 6:36 ` clean up kernel_{read,write} & friends v2 Philippe Mathieu-Daudé
2020-06-05 15:00 ` Nicolas Pitre
-- strict thread matches above, loose matches on Subject: below --
2020-05-13 6:56 Christoph Hellwig
2020-05-20 15:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB448898AB31147F34D4E3B3C1F78E0@MN2PR12MB4488.namprd12.prod.outlook.com \
--to=alexander.deucher@amd.com \
--cc=airlied@linux.ie \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).