RE: mainline/master bisection: baseline.login on peach-pi

["Deucher, Alexander" <Alexander.Deucher@amd.com>]

[AMD Official Use Only - Internal Distribution Only]

> -----Original Message-----
> From: Guillaume Tucker <guillaume.tucker@collabora.com>
> Sent: Friday, April 3, 2020 10:14 AM
> To: Michael J. Ruhl <michael.j.ruhl@intel.com>; Shane Francis
> <bigbeeshane@gmail.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>
> Cc: kernelci@groups.io; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; Tom Murphy <murphyt7@tcd.ie>; Joerg Roedel
> <jroedel@suse.de>; David Airlie <airlied@linux.ie>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Daniel Vetter <daniel@ffwll.ch>;
> Maxime Ripard <mripard@kernel.org>; Enric Balletbo i Serra
> <enric.balletbo@collabora.com>
> Subject: Re: mainline/master bisection: baseline.login on peach-pi
> 
> Please see the bisection report below about a boot failure.
> 
> Reports aren't automatically sent to the public while we're trialing new
> bisection features on kernelci.org but this one looks valid.
> 
> This bisection was run with exynos_defconfig but the issue can also be
> reproduced with multi_v7_defconfig.  It doesn't appear to be affecting any
> other platforms on kernelci.org.  This looks like a DRM driver problem, the
> kernel image boots fine without the modules installed.  It actually started
> failing on Tuesday in mainline.

Fixed with this patch:
https://patchwork.freedesktop.org/patch/359081/
Just trying to get this into 5.7 and stable.  I was waiting for a 5.6 back merge to drm-misc-next-fixes, but I could send it as a separate PR if Dave or Daniel prefer.

Alex


> 
> Guillaume
> 
> On 02/04/2020 19:38, kernelci.org bot wrote:
> > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> > * This automated bisection report was sent to you on the basis  *
> > * that you may be involved with the breaking commit it has      *
> > * found.  No manual investigation has been done to verify it,   *
> > * and the root cause of the problem may be somewhere else.      *
> > *                                                               *
> > * If you do send a fix, please include this trailer:            *
> > *   Reported-by: "kernelci.org bot" <bot@kernelci.org>          *
> > *                                                               *
> > * Hope this helps!                                              *
> > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> >
> > mainline/master bisection: baseline.login on peach-pi
> >
> > Summary:
> >   Start:      56a451b780676 Merge tag 'ntb-5.7' of
> git://github.com/jonmason/ntb
> >   Plain log:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstor
> age.kernelci.org%2F%2Fmainline%2Fmaster%2Fv5.6-3277-
> g56a451b78067%2Farm%2Fexynos_defconfig%2Fgcc-8%2Flab-
> collabora%2Fbaseline-exynos5800-peach-
> pi.txt&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Ca1d322a4
> f72744bfe14208d7d7d9398f%7C3dd8961fe4884e608e11a82d994e183d%7C0%
> 7C0%7C637215200294572061&amp;sdata=pJ%2F8FHi6grBy4aGUuL%2F9%2Bj
> %2FVqrWJfStjBCaDUnBoUMI%3D&amp;reserved=0
> >   HTML log:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstor
> age.kernelci.org%2F%2Fmainline%2Fmaster%2Fv5.6-3277-
> g56a451b78067%2Farm%2Fexynos_defconfig%2Fgcc-8%2Flab-
> collabora%2Fbaseline-exynos5800-peach-
> pi.html&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Ca1d322
> a4f72744bfe14208d7d7d9398f%7C3dd8961fe4884e608e11a82d994e183d%7C0
> %7C0%7C637215200294572061&amp;sdata=pSoe45cMygTcp0UXe3DY%2F6jeI
> EChQ5FwsPO32A4%2Bhh8%3D&amp;reserved=0
> >   Result:     42e67b479eab6 drm/prime: use dma length macro when
> mapping sg
> >
> > Checks:
> >   revert:     PASS
> >   verify:     PASS
> >
> > Parameters:
> >   Tree:       mainline
> >   URL:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.k
> ernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&
> amp;data=02%7C01%7Calexander.deucher%40amd.com%7Ca1d322a4f72744
> bfe14208d7d7d9398f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7
> C637215200294572061&amp;sdata=MW1XaSNAKSVByF8eOG2%2Bv59Mqjwi
> 7Cu6QaU87AZbka8%3D&amp;reserved=0
> >   Branch:     master
> >   Target:     peach-pi
> >   CPU arch:   arm
> >   Lab:        lab-collabora
> >   Compiler:   gcc-8
> >   Config:     exynos_defconfig
> >   Test case:  baseline.login
> >
> > Breaking commit found:
> >
> > ----------------------------------------------------------------------
> > --------- commit 42e67b479eab6d26459b80b4867298232b0435e7
> > Author: Shane Francis <bigbeeshane@gmail.com>
> > Date:   Wed Mar 25 09:07:39 2020 +0000
> >
> >     drm/prime: use dma length macro when mapping sg
> >
> >     As dma_map_sg can reorganize scatter-gather lists in a
> >     way that can cause some later segments to be empty we should
> >     always use the sg_dma_len macro to fetch the actual length.
> >
> >     This could now be 0 and not need to be mapped to a page or
> >     address array
> >
> >     Fixes: be62dbf554c5 ("iommu/amd: Convert AMD iommu driver to the
> dma-iommu api")
> >     Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D206461&amp;data=02%7C01%7Cal
> exander.deucher%40amd.com%7Ca1d322a4f72744bfe14208d7d7d9398f%7C
> 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215200294572061&a
> mp;sdata=5qsATa1dvRx7b4cBDTyjFH13Oz6jpZ%2BynQT6QUe6MkI%3D&amp
> ;reserved=0
> >     Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D206895&amp;data=02%7C01%7Cal
> exander.deucher%40amd.com%7Ca1d322a4f72744bfe14208d7d7d9398f%7C
> 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215200294572061&a
> mp;sdata=hPVjWOqgGd3tpZILyoNJIB%2FrdKGVIbX%2FL5s4GY8M3Gw%3D&
> amp;reserved=0
> >     Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla
> b.freedesktop.org%2Fdrm%2Famd%2Fissues%2F1056&amp;data=02%7C01%
> 7Calexander.deucher%40amd.com%7Ca1d322a4f72744bfe14208d7d7d9398f
> %7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63721520029457206
> 1&amp;sdata=QKsHmktt0%2F8rez459Fid0mEdMeXUlevTENL9OBMK9qE%3D
> &amp;reserved=0
> >     Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> >     Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> >     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> >     Link:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.freedesktop.org%2Fpatch%2Fmsgid%2F20200325090741.21957-2-
> bigbeeshane%40gmail.com&amp;data=02%7C01%7Calexander.deucher%40a
> md.com%7Ca1d322a4f72744bfe14208d7d7d9398f%7C3dd8961fe4884e608e11
> a82d994e183d%7C0%7C0%7C637215200294572061&amp;sdata=7ZxCW%2BfS
> Kyl0flufyP47iN7nFYn0LTMWeJ3iKk9vm6g%3D&amp;reserved=0
> >     Cc: stable@vger.kernel.org
> >
> > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> > index 86d9b0e45c8c6..1de2cde2277ca 100644
> > --- a/drivers/gpu/drm/drm_prime.c
> > +++ b/drivers/gpu/drm/drm_prime.c
> > @@ -967,7 +967,7 @@ int drm_prime_sg_to_page_addr_arrays(struct
> > sg_table *sgt, struct page **pages,
> >
> >  	index = 0;
> >  	for_each_sg(sgt->sgl, sg, sgt->nents, count) {
> > -		len = sg->length;
> > +		len = sg_dma_len(sg);
> >  		page = sg_page(sg);
> >  		addr = sg_dma_address(sg);
> > ----------------------------------------------------------------------
> > ---------
> >
> >
> > Git bisection log:
> >
> > ----------------------------------------------------------------------
> > ---------
> > git bisect start
> > # good: [8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238] Merge tag
> > '5.6-rc4-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6
> > git bisect good 8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238
> > # bad: [56a451b780676bc1cdac011735fe2869fa2e9abf] Merge tag 'ntb-5.7'
> > of git://github.com/jonmason/ntb git bisect bad
> > 56a451b780676bc1cdac011735fe2869fa2e9abf
> > # bad: [59838093be51ee9447f6ad05483d697b6fa0368d] Merge tag
> > 'driver-core-5.7-rc1' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
> > git bisect bad 59838093be51ee9447f6ad05483d697b6fa0368d
> > # bad: [32db9f10d52c97ffc407c7dad81c6fafcad730b2] Merge tag
> > 'arm-soc-fixes-5.6' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
> > git bisect bad 32db9f10d52c97ffc407c7dad81c6fafcad730b2
> > # good: [78511edc2dd4c7b9f74f3b544093c854b7bd7744] Merge tag
> > 'pm-5.6-rc6' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
> > git bisect good 78511edc2dd4c7b9f74f3b544093c854b7bd7744
> > # good: [76ccd234269bd05debdbc12c96eafe62dd9a6180] Merge branch
> > 'perf-urgent-for-linus' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> > git bisect good 76ccd234269bd05debdbc12c96eafe62dd9a6180
> > # good: [81573b18f26defe672a7d960f9af9ac2c97f324d]
> > selftests/net/forwarding: add Makefile to install tests git bisect
> > good 81573b18f26defe672a7d960f9af9ac2c97f324d
> > # good: [9efcc4a129363187c9bf15338692f107c5c9b6f0] afs: Fix unpinned
> > address list during probing git bisect good
> > 9efcc4a129363187c9bf15338692f107c5c9b6f0
> > # bad: [823846c3107197b6eae9fb656a23e986926d6c07] Merge tag
> > 'riscv-for-linus-5.6' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
> > git bisect bad 823846c3107197b6eae9fb656a23e986926d6c07
> > # bad: [7bf8df68cba0536479aead32297e47908922582c] Merge tag
> > 'drm-fixes-2020-03-27' of git://anongit.freedesktop.org/drm/drm
> > git bisect bad 7bf8df68cba0536479aead32297e47908922582c
> > # good: [fbf66796a0aedbaea248c7ade1459ccd0dd4cb44] Input: move the
> new
> > KEY_SELECTIVE_SCREENSHOT keycode git bisect good
> > fbf66796a0aedbaea248c7ade1459ccd0dd4cb44
> > # bad: [5117c363eb213d5503f5b7e39c9bfafd46388184] Merge tag
> > 'drm-misc-fixes-2020-03-26' of
> > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes git bisect
> > bad 5117c363eb213d5503f5b7e39c9bfafd46388184
> > # bad: [0199172f933342d8b1011aae2054a695c25726f4] drm/amdgpu: fix
> > scatter-gather mapping with user pages git bisect bad
> > 0199172f933342d8b1011aae2054a695c25726f4
> > # bad: [42e67b479eab6d26459b80b4867298232b0435e7] drm/prime: use
> dma
> > length macro when mapping sg git bisect bad
> > 42e67b479eab6d26459b80b4867298232b0435e7
> > # first bad commit: [42e67b479eab6d26459b80b4867298232b0435e7]
> > drm/prime: use dma length macro when mapping sg
> > ----------------------------------------------------------------------
> > ---------
> >