From: Rahul Tanwar <rtanwar@maxlinear.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arnd Bergmann <arnd@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adam Borowski <kilobyte@angband.pl>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
John Crispin <john@phrozen.org>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
Cheol Yong Kim <ckim@maxlinear.com>,
Qiming Wu <qwu@maxlinear.com>,
Rahul Tanwar <rtanwar@maxlinear.com>
Subject: [PATCH 1/1] leds: lgm: Improve Kconfig help
Date: Wed, 17 Mar 2021 10:04:41 +0000 [thread overview]
Message-ID: <MN2PR19MB3693EEA37EA1FC18238FE45EB16A9@MN2PR19MB3693.namprd19.prod.outlook.com> (raw)
In-Reply-To: 8ae0456a08ef1a2491fd382b273ff7259e6fcbd0.1615969806.git.rtanwar@maxlinear.com
Remove unnecessary Kconfig symbol LEDS_BLINK
Improve Kconfig help text to make it more useful.
Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
---
drivers/leds/Kconfig | 5 ++---
drivers/leds/Makefile | 2 +-
drivers/leds/blink/Kconfig | 28 +++++++++++++---------------
drivers/leds/blink/Makefile | 2 +-
drivers/leds/blink/leds-lgm-sso.c | 4 ++--
5 files changed, 19 insertions(+), 22 deletions(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index b6742b4231bf..4ca8cd594518 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -928,13 +928,12 @@ config LEDS_ACER_A500
This option enables support for the Power Button LED of
Acer Iconia Tab A500.
+source "drivers/leds/blink/Kconfig"
+
comment "Flash and Torch LED drivers"
source "drivers/leds/flash/Kconfig"
comment "LED Triggers"
source "drivers/leds/trigger/Kconfig"
-comment "LED Blink"
-source "drivers/leds/blink/Kconfig"
-
endif # NEW_LEDS
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index 2a698df9da57..7e604d3028c8 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -110,4 +110,4 @@ obj-$(CONFIG_LEDS_CLASS_FLASH) += flash/
obj-$(CONFIG_LEDS_TRIGGERS) += trigger/
# LED Blink
-obj-$(CONFIG_LEDS_BLINK) += blink/
+obj-y += blink/
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 6dedc58c47b3..2de2973fbc6b 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,21 +1,19 @@
-menuconfig LEDS_BLINK
- bool "LED Blink support"
- depends on LEDS_CLASS
- help
- This option enables blink support for the leds class.
- If unsure, say Y.
-
-if LEDS_BLINK
-
-config LEDS_BLINK_LGM
- tristate "LED support for Intel LGM SoC series"
+config LEDS_LGM
+ tristate "LED support for LGM SoC series"
depends on GPIOLIB
depends on LEDS_CLASS
depends on MFD_SYSCON
depends on OF
help
- Parallel to serial conversion, which is also called SSO
controller,
- can drive external shift register for LED outputs.
- This enables LED support for Serial Shift Output controller(SSO).
+ This option enables support for LEDs connected to GPIO lines on
+ Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
+ Shift Output(SSO) controller. The driver supports hardware
+ blinking with a configurable LED update/blink frequency in two
+ modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 KHz in
+ high speed mode. The LEDs can be configured to be triggered by
+ SW/CPU or by hardware. Say 'Y' here if you are working on LGM
+ SoC based platform.
+
+ To compile this driver as a module, choose M here: the
+ module will be called leds-lgm-sso.
-endif # LEDS_BLINK
diff --git a/drivers/leds/blink/Makefile b/drivers/leds/blink/Makefile
index 2fa6c7b7b67e..fa5d04dccf13 100644
--- a/drivers/leds/blink/Makefile
+++ b/drivers/leds/blink/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_LEDS_BLINK_LGM) += leds-lgm-sso.o
+obj-$(CONFIG_LEDS_LGM) += leds-lgm-sso.o
diff --git a/drivers/leds/blink/leds-lgm-sso.c
b/drivers/leds/blink/leds-lgm-sso.c
index 7d5c9ca007d6..e41143a87e20 100644
--- a/drivers/leds/blink/leds-lgm-sso.c
+++ b/drivers/leds/blink/leds-lgm-sso.c
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Intel Lightning Mountain SoC LED Serial Shift Output Controller driver
+ * Lightning Mountain SoC LED Serial Shift Output Controller driver
*
- * Copyright (c) 2020 Intel Corporation.
+ * Copyright (c) 2021 MaxLinear, Inc.
*/
#include <linux/bitfield.h>
--
2.17.1
next parent reply other threads:[~2021-03-17 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8ae0456a08ef1a2491fd382b273ff7259e6fcbd0.1615969806.git.rtanwar@maxlinear.com>
2021-03-17 10:04 ` Rahul Tanwar [this message]
2021-03-18 1:54 ` [PATCH 1/1] leds: lgm: Improve Kconfig help Randy Dunlap
2021-03-18 9:24 ` Rahul Tanwar
2021-03-18 9:44 ` Arnd Bergmann
2021-03-18 7:55 ` Pavel Machek
2021-03-18 9:49 ` Rahul Tanwar
2021-03-18 20:37 ` Pavel Machek
2021-03-19 5:52 ` Rahul Tanwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR19MB3693EEA37EA1FC18238FE45EB16A9@MN2PR19MB3693.namprd19.prod.outlook.com \
--to=rtanwar@maxlinear.com \
--cc=arnd@kernel.org \
--cc=ckim@maxlinear.com \
--cc=hmehrtens@maxlinear.com \
--cc=john@phrozen.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=qwu@maxlinear.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).