From: Michael Kelley <mikelley@microsoft.com>
To: Matheus Castello <matheus@castello.eng.br>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>
Cc: "sashal@kernel.org" <sashal@kernel.org>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/6] drivers: hv: vmbus: Fix checkpatch LINE_SPACING
Date: Sun, 15 Nov 2020 22:16:34 +0000 [thread overview]
Message-ID: <MW2PR2101MB10521EB5B3FAA2A9EFEE7DCAD7E40@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20201115195734.8338-4-matheus@castello.eng.br>
From: Matheus Castello <matheus@castello.eng.br> Sent: Sunday, November 15, 2020 11:58 AM
>
> Fixed checkpatch warning: Missing a blank line after declarations
> checkpatch(LINE_SPACING)
>
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
> drivers/hv/vmbus_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 52c1407c1849..61d28c743263 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -156,6 +156,7 @@ static u32 channel_conn_id(struct vmbus_channel *channel,
> {
> u8 monitor_group = channel_monitor_group(channel);
> u8 monitor_offset = channel_monitor_offset(channel);
> +
> return monitor_page-
> >parameter[monitor_group][monitor_offset].connectionid.u.id;
> }
>
> @@ -550,6 +551,7 @@ static ssize_t vendor_show(struct device *dev,
> char *buf)
> {
> struct hv_device *hv_dev = device_to_hv_device(dev);
> +
> return sprintf(buf, "0x%x\n", hv_dev->vendor_id);
> }
> static DEVICE_ATTR_RO(vendor);
> @@ -559,6 +561,7 @@ static ssize_t device_show(struct device *dev,
> char *buf)
> {
> struct hv_device *hv_dev = device_to_hv_device(dev);
> +
> return sprintf(buf, "0x%x\n", hv_dev->device_id);
> }
> static DEVICE_ATTR_RO(device);
> --
> 2.28.0
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
next prev parent reply other threads:[~2020-11-15 22:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 19:57 [PATCH 0/6] Add improvements suggested by checkpatch for vmbus_drv Matheus Castello
2020-11-15 19:57 ` [PATCH 1/6] drivers: hv: Fix hyperv_record_panic_msg path on comment Matheus Castello
2020-11-15 22:11 ` Michael Kelley
2020-11-15 19:57 ` [PATCH 2/6] drivers: hv: vmbus: Replace symbolic permissions by octal permissions Matheus Castello
2020-11-15 22:15 ` Michael Kelley
2020-11-15 19:57 ` [PATCH 3/6] drivers: hv: vmbus: Fix checkpatch LINE_SPACING Matheus Castello
2020-11-15 22:16 ` Michael Kelley [this message]
2020-11-15 19:57 ` [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING Matheus Castello
2020-11-15 22:25 ` Michael Kelley
2020-11-25 0:54 ` Matheus Castello
2020-11-25 2:56 ` Joe Perches
2020-11-25 3:14 ` Matheus Castello
2020-11-15 19:57 ` [PATCH 5/6] drivers: hv: vmbus: Fix unnecessary OOM_MESSAGE Matheus Castello
2020-11-16 11:21 ` Wei Liu
2020-11-16 15:58 ` Wei Liu
2020-11-15 19:57 ` [PATCH 6/6] drivers: hv: vmbus: Fix call msleep using < 20ms Matheus Castello
2020-11-15 22:32 ` Michael Kelley
2020-11-17 10:58 ` [PATCH 0/6] Add improvements suggested by checkpatch for vmbus_drv Wei Liu
2020-11-25 0:53 ` Matheus Castello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR2101MB10521EB5B3FAA2A9EFEE7DCAD7E40@MW2PR2101MB1052.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matheus@castello.eng.br \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).