From: Michael Kelley <mikelley@microsoft.com>
To: Andres Beltran <lkmlabelt@gmail.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"parri.andrea@gmail.com" <parri.andrea@gmail.com>
Subject: RE: [PATCH v6 1/3] Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening
Date: Thu, 23 Jul 2020 01:24:03 +0000 [thread overview]
Message-ID: <MW2PR2101MB1052AD4F70F592E57AA20DEAD7760@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200722223904.2801-2-lkmlabelt@gmail.com>
From: Andres Beltran <lkmlabelt@gmail.com> Sent: Wednesday, July 22, 2020 3:39 PM
>
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised Hyper-V, avoid exposing
> guest memory addresses to Hyper-V. Also avoid Hyper-V giving back a
> bad request ID that is then treated as the address of a guest data
> structure with no validation. Instead, encapsulate these memory
> addresses and provide small integers as request IDs.
>
> Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
> ---
> Changes in v6:
> - Offset request IDs by 1 keeping the original initialization
> code.
> Changes in v5:
> - Add support for unsolicited messages sent by the host with a
> request ID of 0.
> Changes in v4:
> - Use channel->rqstor_size to check if rqstor has been
> initialized.
> Changes in v3:
> - Check that requestor has been initialized in
> vmbus_next_request_id() and vmbus_request_addr().
> Changes in v2:
> - Get rid of "rqstor" variable in __vmbus_open().
>
> drivers/hv/channel.c | 170 +++++++++++++++++++++++++++++++++++++++++
> include/linux/hyperv.h | 21 +++++
> 2 files changed, 191 insertions(+)
Tested-by: Michael Kelley <mikelley@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
next prev parent reply other threads:[~2020-07-23 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 22:39 [PATCH v6 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening Andres Beltran
2020-07-22 22:39 ` [PATCH v6 1/3] Drivers: hv: vmbus: Add " Andres Beltran
2020-07-23 1:24 ` Michael Kelley [this message]
2020-07-23 17:58 ` Wei Liu
2020-07-22 22:39 ` [PATCH v6 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs " Andres Beltran
2020-07-22 22:39 ` [PATCH v6 3/3] hv_netvsc: " Andres Beltran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR2101MB1052AD4F70F592E57AA20DEAD7760@MW2PR2101MB1052.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmlabelt@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).