From: Michael Kelley <mikelley@microsoft.com>
To: Dexuan Cui <decui@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
vkuznets <vkuznets@redhat.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2] Drivers: hv: vmbus: Fix Suspend-to-Idle for Generation-2 VM
Date: Sun, 12 Apr 2020 03:33:43 +0000 [thread overview]
Message-ID: <MW2PR2101MB1052F0C6473FA6A433EDFC45D7DC0@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <1586581684-113131-1-git-send-email-decui@microsoft.com>
From: Dexuan Cui <decui@microsoft.com> Sent: Friday, April 10, 2020 10:08 PM
>
> Before the hibernation patchset (e.g. f53335e3289f), in a Generation-2
> Linux VM on Hyper-V, the user can run "echo freeze > /sys/power/state" to
> freeze the system, i.e. Suspend-to-Idle. The user can press the keyboard
> or move the mouse to wake up the VM.
>
> With the hibernation patchset, Linux VM on Hyper-V can hibernate to disk,
> but Suspend-to-Idle is broken: when the synthetic keyboard/mouse are
> suspended, there is no way to wake up the VM.
>
> Fix the issue by not suspending and resuming the vmbus devices upon
> Suspend-to-Idle.
>
> Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for
> hibernation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ---
>
> Changes in v2:
> Added "#define vmbus_suspend NULL", etc. for the case where
> CONFIG_PM_SLEEP is not defined.
> Many thanks to kbuild test robot <lkp@intel.com> for this!
>
> drivers/hv/vmbus_drv.c | 43 ++++++++++++++++++++++++++++++++++---------
> 1 file changed, 34 insertions(+), 9 deletions(-)
>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
prev parent reply other threads:[~2020-04-12 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 5:08 [PATCH v2] Drivers: hv: vmbus: Fix Suspend-to-Idle for Generation-2 VM Dexuan Cui
2020-04-12 3:33 ` Michael Kelley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR2101MB1052F0C6473FA6A433EDFC45D7DC0@MW2PR2101MB1052.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).