From: Radhey Shyam Pandey <radheys@xilinx.com>
To: Vinod Koul <vinod.koul@intel.com>, Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"Appana Durga Kedareswara Rao" <appanad@xilinx.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected
Date: Tue, 17 Apr 2018 10:54:57 +0000 [thread overview]
Message-ID: <MWHPR02MB3293878F33D165B799DB8A96C7B70@MWHPR02MB3293.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20180411090525.GX6014@localhost>
Hi Vinod,
> -----Original Message-----
> From: Vinod Koul [mailto:vinod.koul@intel.com]
> Sent: Wednesday, April 11, 2018 2:35 PM
> To: Radhey Shyam Pandey <radheys@xilinx.com>; Rob Herring
> <robh@kernel.org>; devicetree@vger.kernel.org
> Cc: dan.j.williams@intel.com; michal.simek@xilinx.com; Appana Durga
> Kedareswara Rao <appanad@xilinx.com>; Radhey Shyam Pandey
> <radheys@xilinx.com>; lars@metafoo.de; dmaengine@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property
> has_axieth_connected
>
> On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote:
> > Add an optional AXI DMA property 'has_axieth_connected'. This can be
> > specified to indicate that AXI DMA is connected to AXI Ethernet in
> > hardware design and dma driver needs to do some additional handling.
>
> 1. why are DT people and list not added to this? I have added that
Sorry missed it. I will add in v2. Thanks.
> 2. should we have a property for a specific peripheral? Wouldn't it help to
> have
> a generic property for peripheral connected which can be scaled to more IPs
> being connected in future?
Good point! I will rename this property to xlnx,axistream-connected and
update description. It can then be reused for other usecases as well.
> 3. Please use right subsystem name, it damengine: not dma:
I will fix.
>
> >
> > Signed-off-by: Radhey Shyam Pandey <radheys@xilinx.com>
> > ---
> > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> > index a2b8bfa..5d592e3 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> > @@ -42,6 +42,7 @@ Optional properties:
> > the hardware.
> > Optional properties for AXI DMA:
> > - xlnx,mcdma: Tells whether configured for multi-channel mode in the
> hardware.
> > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI
> Ethernet.
> > Optional properties for VDMA:
> > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync.
> > It takes following values:
> > --
> > 1.7.1
> >
>
> --
> ~Vinod
next prev parent reply other threads:[~2018-04-17 10:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 10:39 [RFC 0/6] Xilinx DMA enhancements and optimization Radhey Shyam Pandey
2018-04-02 10:39 ` [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected Radhey Shyam Pandey
2018-04-11 9:05 ` Vinod Koul
2018-04-17 10:54 ` Radhey Shyam Pandey [this message]
2018-04-02 10:39 ` [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client Radhey Shyam Pandey
2018-04-11 9:08 ` Vinod Koul
2018-04-17 11:43 ` Radhey Shyam Pandey
2018-04-17 12:54 ` Lars-Peter Clausen
2018-04-17 13:46 ` Peter Ujfalusi
2018-04-17 13:58 ` Lars-Peter Clausen
2018-04-17 14:53 ` Peter Ujfalusi
2018-04-17 15:54 ` Lars-Peter Clausen
2018-04-18 6:31 ` Peter Ujfalusi
2018-04-18 13:06 ` Lars-Peter Clausen
2018-04-19 11:40 ` Peter Ujfalusi
2018-04-24 3:55 ` Vinod Koul
2018-04-24 9:50 ` Peter Ujfalusi
2018-05-17 6:39 ` Radhey Shyam Pandey
2018-05-29 15:04 ` Peter Ujfalusi
2018-05-30 17:29 ` Radhey Shyam Pandey
2018-06-01 10:17 ` Peter Ujfalusi
2018-06-01 10:24 ` [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor Peter Ujfalusi
2018-07-02 6:59 ` Radhey Shyam Pandey
2018-07-10 5:52 ` Vinod
2018-07-18 10:06 ` Peter Ujfalusi
2018-07-19 9:22 ` Vinod
2018-07-20 13:42 ` Peter Ujfalusi
2018-07-24 11:14 ` Vinod
2018-07-30 9:46 ` Peter Ujfalusi
2018-07-31 4:29 ` Vinod
2018-04-17 15:42 ` [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client Vinod Koul
2018-04-17 15:44 ` Lars-Peter Clausen
2018-04-18 6:39 ` Peter Ujfalusi
2018-04-18 7:03 ` Peter Ujfalusi
2018-04-02 10:39 ` [RFC 3/6] dmaengine: xilinx_dma: Increase AXI DMA transaction segment count Radhey Shyam Pandey
2018-04-02 10:39 ` [RFC 4/6] dmaengine: xilinx_dma: Freeup active list based on descriptor completion bit Radhey Shyam Pandey
2018-04-11 9:11 ` Vinod Koul
2018-04-17 12:28 ` Radhey Shyam Pandey
2018-04-23 5:23 ` Vinod Koul
2018-04-02 10:39 ` [RFC 5/6] dmaengine: xilinx_dma: Program interrupt delay timeout Radhey Shyam Pandey
2018-04-11 9:11 ` Vinod Koul
2018-04-17 12:48 ` Radhey Shyam Pandey
2018-04-02 10:39 ` [RFC 6/6] dmaengine: xilinx_dma: Use tasklet_hi_schedule for timing critical usecase Radhey Shyam Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR02MB3293878F33D165B799DB8A96C7B70@MWHPR02MB3293.namprd02.prod.outlook.com \
--to=radheys@xilinx.com \
--cc=appanad@xilinx.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).