RE: [PATCH v2 1/3] ACPICA: ACPI 6.4: MADT: add Multiprocessor Wakeup Mailbox Structure

["Kaneda, Erik" <erik.kaneda@intel.com>]

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Friday, April 23, 2021 5:34 AM
> To: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@linux.intel.com>; Kaneda, Erik
> <erik.kaneda@intel.com>
> Cc: Rafael J Wysocki <rjw@rjwysocki.net>; Thomas Gleixner
> <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H . Peter Anvin
> <hpa@zytor.com>; Peter Zijlstra <peterz@infradead.org>; Len Brown
> <lenb@kernel.org>; Moore, Robert <robert.moore@intel.com>; ACPI Devel
> Maling List <linux-acpi@vger.kernel.org>; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) <devel@acpica.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; the arch/x86 maintainers
> <x86@kernel.org>
> Subject: Re: [PATCH v2 1/3] ACPICA: ACPI 6.4: MADT: add Multiprocessor
> Wakeup Mailbox Structure
> 
> On Thu, Apr 22, 2021 at 11:47 PM Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> >
> > ACPICA commit f1ee04207a212f6c519441e7e25397649ebc4cea
> >
> > Add Multiprocessor Wakeup Mailbox Structure definition. It is useful
> > in parsing MADT Wake table.
> >
> > Link: https://github.com/acpica/acpica/commit/f1ee0420
> > Signed-off-by: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@linux.intel.com>
> 
> I'm expecting to receive this patch from Erik at one point, so I'm
> guessing that it's been added to this series for reference.

Hi Rafael,

This patch has been Linux-ized so that you can take this and the SVKL patch. I was told that this was urgent for this merge window. Since they were simple, I thought it would be easier to have Sathya submit to Linux and ACPICA upstream separately. Going through this process made things a little more difficult so I'll be sure to communicate with you ahead of time if I do this again.

Erik
> 
> > ---
> >  include/acpi/actbl2.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
> > index b2362600b9ff..7dce422f6119 100644
> > --- a/include/acpi/actbl2.h
> > +++ b/include/acpi/actbl2.h
> > @@ -733,6 +733,20 @@ struct acpi_madt_multiproc_wakeup {
> >         u64 base_address;
> >  };
> >
> > +#define ACPI_MULTIPROC_WAKEUP_MB_OS_SIZE       2032
> > +#define ACPI_MULTIPROC_WAKEUP_MB_FIRMWARE_SIZE 2048
> > +
> > +struct acpi_madt_multiproc_wakeup_mailbox {
> > +       u16 command;
> > +       u16 reserved;           /* reserved - must be zero */
> > +       u32 apic_id;
> > +       u64 wakeup_vector;
> > +       u8 reserved_os[ACPI_MULTIPROC_WAKEUP_MB_OS_SIZE];       /*
> reserved for OS use */
> > +       u8
> reserved_firmware[ACPI_MULTIPROC_WAKEUP_MB_FIRMWARE_SIZE];   /*
> reserved for firmware use */
> > +};
> > +
> > +#define ACPI_MP_WAKE_COMMAND_WAKEUP    1
> > +
> >  /*
> >   * Common flags fields for MADT subtables
> >   */
> > --
> > 2.25.1
> >