From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, "Will Deacon" <will@kernel.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Kumar, Sanjay K" <sanjay.k.kumar@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] iommu/vt-d: Support asynchronous IOMMU nested capabilities
Date: Wed, 12 May 2021 08:30:12 +0000 [thread overview]
Message-ID: <MWHPR11MB18867DF70AD168ECFB3CC0648C529@MWHPR11MB1886.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210512070421.3472857-1-baolu.lu@linux.intel.com>
> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Wednesday, May 12, 2021 3:04 PM
>
> Current VT-d implementation supports nested translation only if all
> underlying IOMMUs support the nested capability. This is unnecessary
> as the upper layer is allowed to create different containers and set
> them with different type of iommu backend. The IOMMU driver needs to
> guarantee that devices attached to a nested mode iommu_domain should
> support nested capabilility.
so the consistency check is now applied only to the IOMMUs that are
spanned by a given iommu_domain?
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/intel/iommu.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index f1742da42478..1cd4840e6f9f 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4755,6 +4755,13 @@ static int prepare_domain_attach_device(struct
> iommu_domain *domain,
> if (!iommu)
> return -ENODEV;
>
> + if ((dmar_domain->flags & DOMAIN_FLAG_NESTING_MODE) &&
> + !ecap_nest(iommu->ecap)) {
> + dev_err(dev, "%s: iommu not support nested translation\n",
> + iommu->name);
> + return -EINVAL;
> + }
> +
> /* check if this iommu agaw is sufficient for max mapped address */
> addr_width = agaw_to_width(iommu->agaw);
> if (addr_width > cap_mgaw(iommu->cap))
> @@ -5451,11 +5458,21 @@ static int
> intel_iommu_enable_nesting(struct iommu_domain *domain)
> {
> struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> + struct dmar_drhd_unit *drhd;
> + struct intel_iommu *iommu;
> + bool has_nesting = false;
> unsigned long flags;
> - int ret = -ENODEV;
> + int ret = -EINVAL;
> +
> + for_each_active_iommu(iommu, drhd)
> + if (ecap_nest(iommu->ecap))
> + has_nesting = true;
> +
> + if (!has_nesting)
> + return -ENODEV;
Isn't above still doing global consistency check?
>
> spin_lock_irqsave(&device_domain_lock, flags);
> - if (nested_mode_support() && list_empty(&dmar_domain->devices))
> {
> + if (list_empty(&dmar_domain->devices)) {
> dmar_domain->flags |= DOMAIN_FLAG_NESTING_MODE;
> dmar_domain->flags &= ~DOMAIN_FLAG_USE_FIRST_LEVEL;
> ret = 0;
> --
> 2.25.1
next prev parent reply other threads:[~2021-05-12 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 7:04 [PATCH 1/1] iommu/vt-d: Support asynchronous IOMMU nested capabilities Lu Baolu
2021-05-12 8:30 ` Tian, Kevin [this message]
2021-05-12 11:31 ` Lu Baolu
2021-05-13 2:26 ` Tian, Kevin
2021-05-13 3:10 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB18867DF70AD168ECFB3CC0648C529@MWHPR11MB1886.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanjay.k.kumar@intel.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).