From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbdKMOkf (ORCPT ); Mon, 13 Nov 2017 09:40:35 -0500 Received: from mail-co1nam03on0078.outbound.protection.outlook.com ([104.47.40.78]:32597 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752923AbdKMOkc (ORCPT ); Mon, 13 Nov 2017 09:40:32 -0500 From: "Chen, Horace" To: "Liu, Monk" , Colin King , "Deucher, Alexander" , "Koenig, Christian" , David Airlie , "Yu, Xiangliang" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Thread-Topic: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Thread-Index: AQHTWuNhhwwnWvhtmEOZIRvcPk3C/KMRrTywgAC2/4A= Date: Mon, 13 Nov 2017 14:40:29 +0000 Message-ID: References: <20171111115110.3026-1-colin.king@canonical.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Horace.Chen@amd.com; x-originating-ip: [116.228.147.243] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR12MB1312;20:2vBntNzqsCZaBwzXBn+usAIqphCA9rh/8zheVtdUJkVsu3LMIG39IOlq+KTvqeHE0cLV2J3P7ebXcJRyA7A0GjiPuZuWygXt41twIBO2GKpFzgkzPFRTgRV5X5kOc+shF+NhPYxS+hO6gsGkyqg/+BRiE4Q5XS/ugEOnzJ7wULF/zubDSCBar4CXJ20C7y6xXVHa4XzV0OQAs1P2uYFXvPXpEt8OeBsv7H2Sng3rpn3knFrZFu+8mzAepQcHzPjz x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(13464003)(199003)(189002)(2906002)(6506006)(68736007)(3280700002)(77096006)(7736002)(106356001)(3660700001)(25786009)(105586002)(2900100001)(305945005)(5660300001)(6436002)(9686003)(2501003)(2201001)(86362001)(14454004)(99286004)(66066001)(55016002)(53546010)(97736004)(76176999)(54356999)(50986999)(478600001)(110136005)(54906003)(33656002)(189998001)(3846002)(102836003)(6116002)(74316002)(4326008)(53936002)(6246003)(316002)(101416001)(8676002)(8936002)(81166006)(7696004)(229853002)(81156014)(2950100002)(72206003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1312;H:MWHPR12MB1629.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: ced8f974-75bb-4a8e-14c4-08d52aa47c9a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR12MB1312; x-ms-traffictypediagnostic: MWHPR12MB1312: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(767451399110)(217544274631240)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR12MB1312;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR12MB1312; x-forefront-prvs: 0490BBA1F0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ced8f974-75bb-4a8e-14c4-08d52aa47c9a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2017 14:40:29.4550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vADEegrY019773 Reivewed-by: Horace Chen -----Original Message----- From: Liu, Monk Sent: Monday, November 13, 2017 11:43 AM To: Chen, Horace ; Colin King ; Deucher, Alexander ; Koenig, Christian ; David Airlie ; Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Importance: High + Horace -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 2017年11月11日 19:51 To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Liu, Monk ; Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver From: Colin Ian King Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1