From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754933AbdKASjM (ORCPT ); Wed, 1 Nov 2017 14:39:12 -0400 Received: from mail-bn3nam01on0123.outbound.protection.outlook.com ([104.47.33.123]:48832 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752350AbdKASjF (ORCPT ); Wed, 1 Nov 2017 14:39:05 -0400 From: Long Li To: Greg KH CC: KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Paul Meyer Subject: RE: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file Thread-Topic: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file Thread-Index: AQHTUoNdIzuKdhaPbEaiUfz2aklu+aL/Fh0AgADF/pA= Date: Wed, 1 Nov 2017 18:39:00 +0000 Message-ID: References: <20171031200235.9379-1-longli@exchange.microsoft.com> <20171101064932.GA30717@kroah.com> In-Reply-To: <20171101064932.GA30717@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:4898:80e8:7::388] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR21MB0160;6:jXYBi2O1Jdm3f52hwGUaZZ/9Kki5eugQTSOa7fo9zMMTthqgEa2/VbaSjzeZknNCEBRXbzUkY2FUYlEPNGrnq54c0RV9A8i4sCDTc3XHU5jAgkturn/eN56LZUOSzL1LAW+mew2SWSsC73GMZXXEoUAn+tnTasXW0x+89a2UJEaLK3yXXffBx2EEvexWv59ArSfEMd7mOEdSHOl6jbRjZoirbYzE+Nyx9fEA3rwk2ZXRVGd+r3J55+9rW55wJcvxYsa/RUUc0MR/MkmCFHEjq9lRndcwzwlNxa4YqQCnVcq9+/AKEts+zTuS0dbmtHeYdXUtPLcbtp4XfF9jBOamUw==;5:bHTsx8wfWoEL9pMzT8+LY+WIsoRbEC3z6qPuSWVBBZOKGMjwZ1DaQuHMlvOkBsegSxCgJABg770sen11Q8u4bz1QZ7pG4z5TcY2K/o4qvo4ZJgEQn2mvZbYc3WRYm1jV5h9H+Gcty50IVJbpOgqptw==;24:DR1UCtMgIRRZs22+BfM6uiHXjC446QYq07O2JCu7o+q1cn/f+wg/hkOahzB0kTmKKTjQgQ3Nmot1re2WMhN9JrUsOdJNAYRrg9mABMOOmgg=;7:1WPwdAVUnz3jDpVZVqBFs5kYQaVclr/s++LoI2IjLK+AaeV9sOoMz+7F71IjMORAfWMvJ3LgXltSEHkRZsYYPK5caBgpqnHmtnv2wU8ZQ8eCroBUZMK/1bhBasDd9Enn0Zssg/73yrN/wrl9EjJfBEL+vtPRcEnVFSKRajoEsLcX4VWZ3xSi7QYADxvyr/xXf+pxxFuKTQujKh6G8GEUNkc5JCFCAnzL99XE/cSzOjk= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(376002)(346002)(47760400005)(24454002)(189002)(199003)(316002)(22452003)(7696004)(102836003)(6116002)(14454004)(25786009)(2906002)(107886003)(229853002)(54906003)(74316002)(305945005)(7736002)(97736004)(189998001)(99286004)(53546010)(10290500003)(478600001)(2900100001)(5660300001)(53936002)(8676002)(86362001)(68736007)(33656002)(9686003)(10090500001)(81166006)(81156014)(55016002)(86612001)(8936002)(50986999)(54356999)(76176999)(6506006)(106356001)(8990500004)(6246003)(3660700001)(101416001)(77096006)(6436002)(3280700002)(4326008)(105586002)(6916009)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR21MB0160;H:MWHPR21MB0190.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 2330be66-8741-40e1-a8b6-08d52157d1c3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603238);SRVR:MWHPR21MB0160; x-ms-traffictypediagnostic: MWHPR21MB0160: authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231020)(100000703101)(100105400095)(93006095)(93001095)(6055026)(61426038)(61427038)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR21MB0160;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR21MB0160; x-forefront-prvs: 0478C23FE0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2330be66-8741-40e1-a8b6-08d52157d1c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2017 18:39:00.6831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA1Idmu5019948 > From: Greg KH [mailto:greg@kroah.com] > Sent: Tuesday, October 31, 2017 11:50 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; devel@linuxdriverproject.org; linux- > kernel@vger.kernel.org; stable@vger.kernel.org; Paul Meyer > ; Long Li > Subject: Re: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from > KVP file > > On Tue, Oct 31, 2017 at 01:02:35PM -0700, Long Li wrote: > > From: Paul Meyer > > > > While reading in more than one block (50) of KVP records, the > > allocation goes per block, but the reads used the total number of > > allocated records (without resetting the pointer/stream). This causes > > the records buffer to overrun when the refresh reads more than one > > block over the previous capacity (e.g. reading more than 100 KVP > > records whereas the in-memory database was empty before). > > > > Fix this by reading the correct number of KVP records from file each time. > > > > Signed-off-by: Paul Meyer > > Signed-off-by: Long Li > > --- > > tools/hv/hv_kvp_daemon.c | 66 > > ++++++++---------------------------------------- > > 1 file changed, 10 insertions(+), 56 deletions(-) > > When you version a patch, you always have to say what changed below the > --- line, as the documentation states to do... Sorry it was my bad. Can I resend v2 and indicate what has changed? Long > > v3? :) > > thanks, > > greg k-h