From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754261AbdLFBxs (ORCPT ); Tue, 5 Dec 2017 20:53:48 -0500 Received: from mail-dm3nam03on0097.outbound.protection.outlook.com ([104.47.41.97]:29748 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753818AbdLFBxo (ORCPT ); Tue, 5 Dec 2017 20:53:44 -0500 From: Matthew Wilcox To: Dave Chinner , Matthew Wilcox CC: Ross Zwisler , Jens Axboe , Rehas Sachdeva , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-nilfs@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v4 00/73] XArray version 4 Thread-Topic: [PATCH v4 00/73] XArray version 4 Thread-Index: AQHTbisNPIt1fCbZm06BemAYv/5vmqM1i4uAgAABfQCAAABXsA== Date: Wed, 6 Dec 2017 01:53:41 +0000 Message-ID: References: <20171206004159.3755-1-willy@infradead.org> <20171206014536.GA4094@dastard> <20171206015108.GB4094@dastard> In-Reply-To: <20171206015108.GB4094@dastard> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mawilcox@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-12-06T01:53:38.6802002Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [131.107.174.245] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR21MB0640;6:zDK+0lR3YfUiZMcEn7txYDLL5eO4FvejHHcr28OUS5AlWhCZELjTvVy8BFFQw8kx77yYGIU0h2siSKelZPmInAaAnXDQ4ocv9qS9mbwQXhUSHJz7gy91pTxbbQ0sDJyxX2x0y2UunzqCQ1+FT6iZwNQzwGsugTSJh3//sCh2n8n8BoG+FFxz29q8WLhoRlHPEPkjZJGdvMU1dKjQsFBb2NtK4G1i8RoFdtxlFxYU59xr4Bj4efMXHyOPF9OIkPpx7r+lA+n1SG2pl8YZZxvmMSY5QlwSWqaF8hTl/eMV+BjGzMiTrfyLZQnP3KD9LT/6TCqi7r2OF06RNQT5OjK5EtYvNm1ynaDIPo8ZZ+iyMb0=;5:EXy477ZRiXkDfF7MuHCSpYMQivpIhLhI+QIwEmuKQgWPbadZOL0kIG1JoO6j/Ze+YQQcmdQBRTgJ7GZT/ivbubdZ5HLpEknD81/2uw3+GBuDA61TtMTGLiqEQurlqp+o1CPJshHTLvZmdo4OzbzYmY+fF6admIlk+MYOrtAlypg=;24:eWH820wPYhx4ZyS3UVDNdxFY9t3atDk+qdFE5fH4ojQOsU5vW03F8pMY3WK1ItI0K+cHs/wZlf11zKPVSDhSSTNZ5g3C4v7rpvWacIvqEsA=;7:mirgLPsSuf+55o3VuXg5hpf88Fxk9BLkrmYc9VOeQw8cxvdttZhgCyl9wlhxl/LPrYHhnC7AOkOAzNR2rFYTd5QkQUwkHrn6KVvC24F3WyIQj8lSYIHhofDuerTBMW+jT3BI3bmosct0oGxfJodDCD7GBsC+qvNoHm7ZSU3kL17feVPrr0xwjUFOBdwT6qcFOVSLfNB3UoRftnyCsYfcnZGYegiNveEPeW7zG4VkQxV+54yQlcncKb8f23AgmRUf x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 558efe04-b2e3-4357-9a8d-08d53c4c2d0a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:MWHPR21MB0640; x-ms-traffictypediagnostic: MWHPR21MB0640: authentication-results: spf=none (sender IP is ) smtp.mailfrom=mawilcox@microsoft.com; x-o365eop-header: O365_EOP: Allow for Unauthenticated Relay x-o365ent-eop-header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY) x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(143289334528602)(89211679590171)(9452136761055)(189930954265078)(211936372134217)(153496737603132)(219752817060721)(211171220733660)(228905959029699)(42262312472803); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040450)(2401047)(5005006)(8121501046)(3231022)(920507027)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011);SRVR:MWHPR21MB0640;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:MWHPR21MB0640; x-forefront-prvs: 05134F8B4F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(346002)(376002)(47760400005)(24454002)(13464003)(189003)(199004)(39060400002)(966005)(316002)(25786009)(6306002)(6246003)(9686003)(53936002)(101416001)(4326008)(22452003)(10290500003)(66066001)(478600001)(7416002)(106356001)(33656002)(2950100002)(2900100001)(105586002)(68736007)(3846002)(8936002)(8990500004)(2906002)(6116002)(102836003)(3660700001)(10090500001)(81156014)(3280700002)(5660300001)(55016002)(34040400001)(6506006)(6436002)(74316002)(305945005)(14454004)(8676002)(97736004)(81166006)(53546010)(229853002)(76176011)(99286004)(7736002)(77096006)(86362001)(110136005)(575784001)(7696005)(54906003)(86612001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR21MB0640;H:MWHPR21MB0845.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 558efe04-b2e3-4357-9a8d-08d53c4c2d0a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2017 01:53:41.2706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0640 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB61ruPH002540 Huh, you've caught a couple of problems that 0day hasn't sent me yet. Try turning on DAX or TRANSPARENT_HUGEPAGE. Thanks! > -----Original Message----- > From: Dave Chinner [mailto:david@fromorbit.com] > Sent: Tuesday, December 5, 2017 8:51 PM > To: Matthew Wilcox > Cc: Matthew Wilcox ; Ross Zwisler > ; Jens Axboe ; Rehas > Sachdeva ; linux-mm@kvack.org; linux- > fsdevel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; linux- > nilfs@vger.kernel.org; linux-btrfs@vger.kernel.org; linux-xfs@vger.kernel.org; > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 00/73] XArray version 4 > > On Wed, Dec 06, 2017 at 12:45:49PM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > > > I looked through some notes and decided this was version 4 of the XArray. > > > Last posted two weeks ago, this version includes a *lot* of changes. > > > I'd like to thank Dave Chinner for his feedback, encouragement and > > > distracting ideas for improvement, which I'll get to once this is merged. > > > > BTW, you need to fix the "To:" line on your patchbombs: > > > > > To: unlisted-recipients: ;, no To-header on input <@gmail- > pop.l.google.com> > > > > This bad email address getting quoted to the cc line makes some MTAs > > very unhappy. > > > > > > > > Highlights: > > > - Over 2000 words of documentation in patch 8! And lots more kernel-doc. > > > - The page cache is now fully converted to the XArray. > > > - Many more tests in the test-suite. > > > > > > This patch set is not for applying. 0day is still reporting problems, > > > and I'd feel bad for eating someone's data. These patches apply on top > > > of a set of prepatory patches which just aren't interesting. If you > > > want to see the patches applied to a tree, I suggest pulling my git tree: > > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.infrade > ad.org%2Fusers%2Fwilly%2Flinux- > dax.git%2Fshortlog%2Frefs%2Fheads%2Fxarray-2017-12- > 04&data=02%7C01%7Cmawilcox%40microsoft.com%7Ca3e721545f8b4b9dff1 > 608d53c4bd42f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6364 > 81218740341312&sdata=IXNZXXLTf964OQ0eLDpJt2LCv%2BGGWFW%2FQd4Kc > KYu6zo%3D&reserved=0 > > > I also left out the idr_preload removals. They're still in the git tree, > > > but I'm not looking for feedback on them. > > > > I'll give this a quick burn this afternoon and see what catches fire... > > Build warnings/errors: > > ..... > lib/radix-tree.c:700:13: warning: ¿radix_tree_free_nodes¿ defined but not used > [-Wunused-function] > static void radix_tree_free_nodes(struct radix_tree_node *node) > ..... > lib/xarray.c: In function ¿xas_max¿: > lib/xarray.c:291:16: warning: unused variable ¿mask¿ > [-Wunused-variable] > unsigned long mask, max = xas->xa_index; > ^~~~ > ...... > fs/dax.c: In function ¿grab_mapping_entry¿: > fs/dax.c:305:2: error: implicit declaration of function ¿xas_set_order¿; did you > mean ¿xas_set_err¿? [-Werror=implicit-function-declaration] > xas_set_order(&xas, index, size_flag ? PMD_ORDER : 0); > ^~~~~~~~~~~~~ > scripts/Makefile.build:310: recipe for target 'fs/dax.o' failed > make[1]: *** [fs/dax.o] Error 1 > > -Dave. > -- > Dave Chinner > david@fromorbit.com