From: Paul Burton <paul.burton@mips.com>
To: Jun-Ru Chang <jrjang@realtek.com>
Cc: "ralf@linux-mips.org" <ralf@linux-mips.org>,
Paul Burton <pburton@wavecomp.com>,
"jhogan@kernel.org" <jhogan@kernel.org>,
Maciej X Rozycki <maciej.rozycki@mips.com>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tonywu@realtek.com" <tonywu@realtek.com>,
"jrjang@realtek.com" <jrjang@realtek.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] MIPS: Remove function size check in get_frame_info()
Date: Mon, 4 Feb 2019 23:16:41 +0000 [thread overview]
Message-ID: <MWHPR2201MB127706739D6459806203CAC3C16D0@MWHPR2201MB1277.namprd22.prod.outlook.com> (raw)
In-Reply-To: <20190129035607.GA8801@genru-nb>
Hello,
Jun-Ru Chang wrote:
> Patch (b6c7a324df37b "MIPS: Fix get_frame_info() handling of
> microMIPS function size.") introduces additional function size
> check for microMIPS by only checking insn between ip and ip + func_size.
> However, func_size in get_frame_info() is always 0 if KALLSYMS is not
> enabled. This causes get_frame_info() to return immediately without
> calculating correct frame_size, which in turn causes "Can't analyze
> schedule() prologue" warning messages at boot time.
>
> This patch removes func_size check, and let the frame_size check run
> up to 128 insns for both MIPS and microMIPS.
>
> Signed-off-by: Jun-Ru Chang <jrjang@realtek.com>
> Signed-off-by: Tony Wu <tonywu@realtek.com>
> Fixes: b6c7a324df37b ("MIPS: Fix get_frame_info() handling of microMIPS function size.")
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
next prev parent reply other threads:[~2019-02-04 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 3:56 [PATCH] MIPS: Remove function size check in get_frame_info() Jun-Ru Chang
2019-02-04 23:16 ` Paul Burton [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-21 3:45 Jun-Ru Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR2201MB127706739D6459806203CAC3C16D0@MWHPR2201MB1277.namprd22.prod.outlook.com \
--to=paul.burton@mips.com \
--cc=jhogan@kernel.org \
--cc=jrjang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maciej.rozycki@mips.com \
--cc=mingo@kernel.org \
--cc=pburton@wavecomp.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=tonywu@realtek.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).