From: Adam Kandur <rndd@tuta.io>
To: netdev@vger.kernel.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] QLGE: qlge_main: Fix style
Date: Wed, 1 Dec 2021 15:39:08 +0100 (CET) [thread overview]
Message-ID: <MpqQpIa--F-2@tuta.io> (raw)
[-- Attachment #1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #2: 0001-QLGE-qlge_main-Fix-style.patch --]
[-- Type: application/octet-stream, Size: 2626 bytes --]
From 41266a72ae2ad8fb45e96e455c519177bfd23bc0 Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Wed, 1 Dec 2021 17:32:11 +0300
Subject: [PATCH] QLGE: qlge_main: Fix style
---
drivers/staging/qlge/qlge_main.c | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 9873bb2a9..c86e2a936 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -1200,11 +1200,11 @@ static void qlge_unmap_send(struct qlge_adapter *qdev,
* element and there is more than 6 frags,
* then its an OAL.
*/
- if (i == 7) {
+ if (i == 7)
netif_printk(qdev, tx_done, KERN_DEBUG,
qdev->ndev,
"unmapping OAL area.\n");
- }
+
dma_unmap_single(&qdev->pdev->dev,
dma_unmap_addr(&tx_ring_desc->map[i],
mapaddr),
@@ -1236,10 +1236,10 @@ static int qlge_map_send(struct qlge_adapter *qdev,
struct tx_buf_desc *tbd = mac_iocb_ptr->tbd;
int frag_cnt = skb_shinfo(skb)->nr_frags;
- if (frag_cnt) {
+ if (frag_cnt)
netif_printk(qdev, tx_queued, KERN_DEBUG, qdev->ndev,
"frag_cnt = %d.\n", frag_cnt);
- }
+
/*
* Map the skb buffer first.
*/
@@ -3351,12 +3351,11 @@ static void qlge_free_irq(struct qlge_adapter *qdev)
for (i = 0; i < qdev->intr_count; i++, intr_context++) {
if (intr_context->hooked) {
- if (test_bit(QL_MSIX_ENABLED, &qdev->flags)) {
+ if (test_bit(QL_MSIX_ENABLED, &qdev->flags))
free_irq(qdev->msi_x_entry[i].vector,
&qdev->rx_ring[i]);
- } else {
+ else
free_irq(qdev->pdev->irq, &qdev->rx_ring[0]);
- }
}
}
qlge_disable_msix(qdev);
@@ -4128,22 +4127,21 @@ static void qlge_set_multicast_list(struct net_device *ndev)
if (ndev->flags & IFF_PROMISC) {
if (!test_bit(QL_PROMISCUOUS, &qdev->flags)) {
if (qlge_set_routing_reg
- (qdev, RT_IDX_PROMISCUOUS_SLOT, RT_IDX_VALID, 1)) {
+ (qdev, RT_IDX_PROMISCUOUS_SLOT, RT_IDX_VALID, 1))
netif_err(qdev, hw, qdev->ndev,
"Failed to set promiscuous mode.\n");
- } else {
+ else
set_bit(QL_PROMISCUOUS, &qdev->flags);
- }
- }
} else {
if (test_bit(QL_PROMISCUOUS, &qdev->flags)) {
- if (qlge_set_routing_reg
- (qdev, RT_IDX_PROMISCUOUS_SLOT, RT_IDX_VALID, 0)) {
+ if (qlge_set_routing_reg (qdev,
+ RT_IDX_PROMISCUOUS_SLOT,
+ RT_IDX_VALID,
+ 0))
netif_err(qdev, hw, qdev->ndev,
"Failed to clear promiscuous mode.\n");
- } else {
+ else
clear_bit(QL_PROMISCUOUS, &qdev->flags);
- }
}
}
--
2.34.0
next reply other threads:[~2021-12-01 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 14:39 Adam Kandur [this message]
2021-12-01 14:53 ` [PATCH] QLGE: qlge_main: Fix style Greg KH
2021-12-03 8:14 ` Dan Carpenter
2021-12-03 9:06 ` Adam Kandur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MpqQpIa--F-2@tuta.io \
--to=rndd@tuta.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).