From: James Morris <jmorris@intercode.com.au>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, <netdev@oss.sgi.com>,
Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@redhat.com>,
Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Randy Dunlap <rddunlap@osdl.org>
Subject: Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting
Date: Thu, 10 Jul 2003 14:42:44 +1000 (EST) [thread overview]
Message-ID: <Mutt.LNX.4.44.0307101419080.15602-100000@excalibur.intercode.com.au> (raw)
In-Reply-To: <3F0AFFE6.E85FF283@us.ibm.com>
On Tue, 8 Jul 2003, Jim Keniston wrote:
+ kerror_nl = netlink_kernel_create(NETLINK_KERROR, kerror_netlink_rcv);
+ if (kerror_nl == NULL)
+ panic("kerror_init: cannot initialize kerror_nl\n");
You can simply use NULL instead of passing the dummy kerror_netlink_rcv
function.
+struct kern_log_entry {
+ __u16 log_kmagic; /* always LOGREC_KMAGIC */
+ __u16 log_kversion; /* which version of this struct? */
+ char log_facility[FACILITY_MAXLEN]; /* e.g., driver name */
These fields should generally be specified in ascending order to help with
alignment.
It may also be worth looking at how the ULOG code batches messages to
improve peformance.
- James
--
James Morris
<jmorris@intercode.com.au>
next prev parent reply other threads:[~2003-07-10 4:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 17:31 [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting Jim Keniston
2003-07-08 17:59 ` Andrew Morton
2003-07-08 19:22 ` Jim Keniston
2003-07-08 19:45 ` Jim Keniston
2003-07-10 4:42 ` James Morris [this message]
2003-07-10 19:08 ` Jim Keniston
2003-07-11 15:37 ` James Morris
2003-07-12 5:09 ` David S. Miller
2003-07-12 5:41 ` David S. Miller
2003-07-13 1:17 ` James Morris
2003-07-13 5:34 ` David S. Miller
2003-07-15 17:42 ` [PATCH] [1/2] kernel error reporting (revised) Jim Keniston
2003-07-15 17:45 ` [PATCH] [2/2] " Jim Keniston
2003-07-15 19:51 ` [PATCH] [1/2] " Andrew Morton
2003-07-15 23:10 ` kuznet
2003-07-17 19:13 ` Jim Keniston
2003-07-18 1:53 ` James Morris
2003-07-18 17:06 ` Jim Keniston
2003-07-18 23:29 ` Jim Keniston
2003-07-19 23:52 ` James Morris
[not found] <3F0AFFE6.E85FF283@us.ibm.com.suse.lists.linux.kernel>
[not found] ` <20030708105912.57015026.akpm@osdl.org.suse.lists.linux.kernel>
2003-07-08 19:14 ` [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Mutt.LNX.4.44.0307101419080.15602-100000@excalibur.intercode.com.au \
--to=jmorris@intercode.com.au \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).