From: "Bulent Abali" <abali@us.ibm.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Mike Galbraith <mikeg@wen-online.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Derek Glidden <dglidden@illusionary.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: Please test: workaround to help swapoff behaviour
Date: Fri, 8 Jun 2001 19:53:35 -0400 [thread overview]
Message-ID: <OF215A9F3A.3CFF9D00-ON85256A65.007FE32C@watson.ibm.com> (raw)
>> I looked at try_to_unuse in swapfile.c. I believe that the algorithm is
>> broken.
>> For each and every swap entry it is walking the entire process list
>> (for_each_task(p)). It is also grabbing a whole bunch of locks
>> for each swap entry. It might be worthwhile processing swap entries in
>> batches instead of one entry at a time.
>>
>> In any case, I think having this patch is worthwhile as a quick and
dirty
>> remedy.
>
>Bulent,
>
>Could you please check if 2.4.6-pre2+the schedule patch has better
>swapoff behaviour for you?
No problem. I will check it tomorrow. I don't think it can be any worse
than it is now. The patch looks correct in principle.
I believe it should go in to 2.4.6. But I will test it.
On small machines people don't notice it, but otherwise if you have few
GB of memory it really hurts. Shutdowns take forever since swapoff takes
forever.
next reply other threads:[~2001-06-08 23:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-08 23:53 Bulent Abali [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-06-10 13:56 Please test: workaround to help swapoff behaviour Bulent Abali
2001-06-09 20:32 Bulent Abali
2001-06-10 2:12 ` Eric W. Biederman
2001-06-07 20:33 Bulent Abali
2001-06-07 19:40 ` Marcelo Tosatti
2001-06-08 21:11 ` Marcelo Tosatti
2001-06-07 17:10 Break 2.4 VM in five easy steps Marcelo Tosatti
2001-06-07 17:43 ` Please test: workaround to help swapoff behaviour Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF215A9F3A.3CFF9D00-ON85256A65.007FE32C@watson.ibm.com \
--to=abali@us.ibm.com \
--cc=dglidden@illusionary.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=mikeg@wen-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).