linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <Heiko.Carstens@de.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Nathan Lynch <nathanl@austin.ibm.com>,
	paulus@au1.ibm.com, rusty@rustcorp.com.au
Subject: Re: [BUG] mm_struct leak on cpu hotplug (s390/ppc64)
Date: Wed, 5 Jan 2005 15:22:08 +0100	[thread overview]
Message-ID: <OF31A98EFF.23948757-ONC1256F80.004ECB94-C1256F80.004EE553@de.ibm.com> (raw)
In-Reply-To: <20050105110833.GA14956@elte.hu>

> the correct solution i think would be to call back into the scheduler
> from cpu_die():
> 
> void cpu_die(void)
> {
>         if (ppc_md.cpu_die)
>                 ppc_md.cpu_die();
> +   idle_task_exit();
>         local_irq_disable();
>         for (;;);
> }
> 
> and then in idle_task_exit(), do something like:
> 
> void idle_task_exit(void)
> {
>    struct mm_struct *mm = current->active_mm;
> 
>    if (mm != &init_mm)
>       switch_mm(mm, &init_mm, current);
>    mmdrop(mm);
> }
> 
> (completely untested.) This makes sure that the idle task uses the
> init_mm (which always has valid pagetables), and also ensures correct
> reference-counting. Hm?

Looks good and works for me.

Thanks,
Heiko


  reply	other threads:[~2005-01-05 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-04 13:11 [BUG] mm_struct leak on cpu hotplug (s390/ppc64) Heiko Carstens
2005-01-05  2:41 ` Nathan Lynch
2005-01-05 11:08   ` Ingo Molnar
2005-01-05 14:22     ` Heiko Carstens [this message]
2005-01-05 15:44     ` Nathan Lynch
2005-01-07 11:43       ` Ingo Molnar
2005-01-07 21:43         ` [PATCH] introduce idle_task_exit Nathan Lynch
2005-01-07 21:44           ` [PATCH] ppc64: call idle_task_exit from cpu_die Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF31A98EFF.23948757-ONC1256F80.004ECB94-C1256F80.004EE553@de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nathanl@austin.ibm.com \
    --cc=paulus@au1.ibm.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).