From: Michael D Labriola <mlabriol@gdeb.com>
To: Ingo Molnar <mingo@elte.hu>, Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Michael D Labriola <mlabriol@gdeb.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Kushal Koolwal <kushalkoolwal@gmail.com>,
linux-kernel@vger.kernel.org, michael.d.labriola@gmail.com,
support@versalogic.com, Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: [PATCH] x86, reboot: remove VersaLogic Menlow reboot quirk
Date: Tue, 17 Jan 2012 10:16:14 -0500 [thread overview]
Message-ID: <OF403557D6.D9E7AB81-ON85257988.00536641-85257988.0053E284@gdeb.com> (raw)
This commit removes the reboot quirk originally added by commit e19e074
(x86: Fix reboot problem on VersaLogic Menlow boards).
Testing with a VersaLogic Ocelot (VL-EPMs-21a rev 1.00 w/ BIOS 6.5.102)
revealed the following regarding the reboot hang problem:
- v2.6.37 reboot=bios was needed.
- v2.6.38-rc1: behavior changed, reboot=acpi is needed, reboot=kbd and
reboot=bios result in system hang.
- v2.6.38: VersaLogic patch (e19e074 x86: Fix reboot problem on
VersaLogic Menlow boards) was applied prior to v2.6.38-rc7. This
patch sets a quirk for VersaLogic Menlow boards that forces the use
of reboot=bios, which doesn't work anymore.
- v3.2: It seems that commit 660e34c (x86: Reorder reboot method
preferences) changed the default reboot method to acpi prior to
v3.0-rc1, which means the default behavior is appropriate for the
Ocelot. No VersaLogic quirk is required.
The Ocelot board used for testing can successfully reboot w/out having to
pass any reboot= arguments for all 3 current versions of the BIOS.
Signed-off-by: Michael D Labriola <mlabriol@gdeb.com>
---
arch/x86/kernel/reboot.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 4240d58..c584291 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -301,14 +301,6 @@ static struct dmi_system_id __initdata
reboot_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "P4S800"),
},
},
- { /* Handle problems with rebooting on VersaLogic Menlow
boards */
- .callback = set_bios_reboot,
- .ident = "VersaLogic Menlow based board",
- .matches = {
- DMI_MATCH(DMI_BOARD_VENDOR, "VersaLogic
Corporation"),
- DMI_MATCH(DMI_BOARD_NAME, "VersaLogic Menlow
board"),
- },
- },
{ /* Handle reboot issue on Acer Aspire one */
.callback = set_kbd_reboot,
.ident = "Acer Aspire One A110",
--
1.6.0.3
next reply other threads:[~2012-01-17 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 15:16 Michael D Labriola [this message]
2012-01-29 19:21 [PATCH] x86, reboot: remove VersaLogic Menlow reboot quirk Michael D Labriola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF403557D6.D9E7AB81-ON85257988.00536641-85257988.0053E284@gdeb.com \
--to=mlabriol@gdeb.com \
--cc=hpa@zytor.com \
--cc=kushalkoolwal@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.d.labriola@gmail.com \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=support@versalogic.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).