From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8838C19759 for ; Thu, 1 Aug 2019 09:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7412214DA for ; Thu, 1 Aug 2019 09:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731131AbfHAJUc (ORCPT ); Thu, 1 Aug 2019 05:20:32 -0400 Received: from twhmllg4.macronix.com ([211.75.127.132]:15438 "EHLO TWHMLLG4.macronix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729616AbfHAJU2 (ORCPT ); Thu, 1 Aug 2019 05:20:28 -0400 Received: from twhfmnt1.mxic.com.tw (twhfm1p2.macronix.com [172.17.20.92]) by TWHMLLG4.macronix.com with ESMTP id x719HTPb014187; Thu, 1 Aug 2019 17:17:29 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.mxic.com.tw [172.17.14.55]) by Forcepoint Email with ESMTP id E762F2D1C15A92C1395E; Thu, 1 Aug 2019 17:17:29 +0800 (CST) In-Reply-To: <20190801075725.4f23e0f5@collabora.com> References: <1564631710-30276-1-git-send-email-masonccyang@mxic.com.tw> <1564631710-30276-3-git-send-email-masonccyang@mxic.com.tw> <20190801075725.4f23e0f5@collabora.com> To: "Boris Brezillon" Cc: anders.roxell@linaro.org, bbrezillon@kernel.org, christophe.kerello@st.com, computersforpeace@gmail.com, devicetree@vger.kernel.org, dwmw2@infradead.org, juliensu@mxic.com.tw, lee.jones@linaro.org, liang.yang@amlogic.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, mark.rutland@arm.com, miquel.raynal@bootlin.com, paul@crapouillou.net, paul.burton@mips.com, richard@nod.at, robh+dt@kernel.org, stefan@agner.ch, vigneshr@ti.com Subject: Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings MIME-Version: 1.0 X-KeepSent: 42C4D3EC:9549E8DC-48258449:003273A5; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Thu, 1 Aug 2019 17:17:29 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2019/08/01 PM 05:17:29, Serialize complete at 2019/08/01 PM 05:17:29 Content-Type: text/plain; charset="US-ASCII" X-MAIL: TWHMLLG4.macronix.com x719HTPb014187 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, > On Thu, 1 Aug 2019 11:55:10 +0800 > Mason Yang wrote: > > > Document the bindings used by the Macronix raw NAND controller. > > > > Signed-off-by: Mason Yang > > --- > > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/ > Documentation/devicetree/bindings/mtd/mxic-nand.txt > > new file mode 100644 > > index 0000000..de37d60 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt > > @@ -0,0 +1,19 @@ > > +Macronix Raw NAND Controller Device Tree Bindings > > +------------------------------------------------- > > + > > +Required properties: > > +- compatible: should be "mxicy,multi-itfc-v009-nand-morph" > > +- reg: should contain 1 entry for the registers > > +- interrupts: interrupt line connected to this raw NAND controller > > +- clock-names: should contain "ps", "send" and "send_dly" > > +- clocks: should contain 3 phandles for the "ps", "send" and > > + "send_dly" clocks > > + > > +Example: > > + > > + nand: nand-controller@43c30000 { > > + compatible = "mxicy,multi-itfc-v009-nand-morph"; > > + reg = <0x43c30000 0x10000>; > > + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>; > > + clock-names = "send", "send_dly", "ps"; > > You should have subnodes describing the NAND connected to the > controller (see [1]). > > [1] https://elixir.bootlin.com/linux/v5.3-rc2/source/Documentation/devicetree/ > bindings/mtd/nand-controller.yaml#L131 > > > + }; > Do you mean to add patternProperties ? nand: nand-controller@43c30000 { compatible = "mxicy,multi-itfc-v009-nand-morph"; reg = <0x43c30000 0x10000>; clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>; clock-names = "send", "send_dly", "ps"; + nand@0 { + + }; }; something like that. thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================