From: Michael D Labriola <mlabriol@gdeb.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Kushal Koolwal <kushalkoolwal@gmail.com>,
linux-kernel@vger.kernel.org, michael.d.labriola@gmail.com,
Ingo Molnar <mingo@elte.hu>,
Matthew Garrett <mjg59@srcf.ucam.org>,
support@versalogic.com, Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user
Date: Thu, 19 Jan 2012 10:48:53 -0500 [thread overview]
Message-ID: <OF8642E997.5ED041E1-ON8525798A.0056983A-8525798A.0056E05B@gdeb.com> (raw)
In-Reply-To: <20120119154504.710e202e@pyramind.ukuu.org.uk>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote on 01/19/2012 10:45:04 AM:
> > checking if reboot_type's value is anything other than BOOT_ACPI
(which
> > is the default), but that does assume BOOT_ACPI is the default. What
if
> > that's ever changed? Seems likely to me that whoever changes the
default
> > in the future could very easily re-break this at that point.
> >
> > Thoughts?
>
> Fair point - how about a BOOT_DEFAULT define value if it hasn't been set
> and we can just make it do the same as ACPI in the switch ?
Sounds good to me. I'll whip that up and resubmit.
---
Michael D Labriola
Electric Boat
mlabriol@gdeb.com
401-848-8871 (desk)
401-848-8513 (lab)
401-316-9844 (cell)
next prev parent reply other threads:[~2012-01-19 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 15:16 [PATCH] x86, reboot: skip DMI checks if reboot set by user Michael D Labriola
2012-01-17 19:58 ` Alan Cox
2012-01-19 15:32 ` Michael D Labriola
2012-01-19 15:45 ` Alan Cox
2012-01-19 15:48 ` Michael D Labriola [this message]
[not found] ` <OF8642E997.5ED041E1-ON8525798A.0056983A-8525798A.0056E05B@LocalDomain>
2012-01-19 17:46 ` Michael D Labriola
2012-01-19 17:52 ` H. Peter Anvin
2012-01-19 19:14 ` Michael D Labriola
2012-01-19 19:17 ` H. Peter Anvin
2012-01-19 19:34 ` Michael D Labriola
2012-01-19 19:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF8642E997.5ED041E1-ON8525798A.0056983A-8525798A.0056E05B@gdeb.com \
--to=mlabriol@gdeb.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=kushalkoolwal@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.d.labriola@gmail.com \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=support@versalogic.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).