From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1672EC0044D for ; Thu, 12 Mar 2020 01:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2716520739 for ; Thu, 12 Mar 2020 01:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387626AbgCLBp0 convert rfc822-to-8bit (ORCPT ); Wed, 11 Mar 2020 21:45:26 -0400 Received: from twhmllg4.macronix.com ([122.147.135.202]:49061 "EHLO TWHMLLG4.macronix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387571AbgCLBp0 (ORCPT ); Wed, 11 Mar 2020 21:45:26 -0400 Received: from twhfm1p2.macronix.com (twhfmlp2.macronix.com [172.17.20.92]) by TWHMLLG4.macronix.com with ESMTP id 02C1jGWP063299; Thu, 12 Mar 2020 09:45:16 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.mxic.com.tw [172.17.14.55]) by Forcepoint Email with ESMTP id A7DE8C6B7C8838238773; Thu, 12 Mar 2020 09:45:16 +0800 (CST) In-Reply-To: <20200311084304.580bec79@xps13> References: <1583220084-10890-1-git-send-email-masonccyang@mxic.com.tw> <1583220084-10890-4-git-send-email-masonccyang@mxic.com.tw> <20200310203310.5fe74c57@collabora.com> <20200311084304.580bec79@xps13> To: "Miquel Raynal" Cc: allison@lohutok.net, bbrezillon@kernel.org, "Boris Brezillon" , frieder.schrempf@kontron.de, juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, rfontana@redhat.com, richard@nod.at, s.hauer@pengutronix.de, stefan@agner.ch, tglx@linutronix.de, vigneshr@ti.com, yuehaibing@huawei.com Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation MIME-Version: 1.0 X-KeepSent: A42184FE:1BAA0BF4-48258529:000916D9; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Thu, 12 Mar 2020 09:45:16 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2020/03/12 AM 09:45:16, Serialize complete at 2020/03/12 AM 09:45:16 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-MAIL: TWHMLLG4.macronix.com 02C1jGWP063299 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, > > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > > > index bc2fa3c..c0055ed 100644 > > > > --- a/include/linux/mtd/rawnand.h > > > > +++ b/include/linux/mtd/rawnand.h > > > > @@ -1064,6 +1064,8 @@ struct nand_legacy { > > > > * @lock: lock protecting the suspended field. Also used to > > > > * serialize accesses to the NAND device. > > > > * @suspended: set to 1 when the device is suspended, 0 when > > it's not. > > > > + * @_suspend: [REPLACEABLE] specific NAND device suspend > > operation > > > > + * @_resume: [REPLACEABLE] specific NAND device resume operation > > > > * @bbt: [INTERN] bad block table pointer > > > > * @bbt_td: [REPLACEABLE] bad block table descriptor for flash > > > > * lookup. > > > > @@ -1119,6 +1121,8 @@ struct nand_chip { > > > > > > > > struct mutex lock; > > > > unsigned int suspended : 1; > > > > + int (*_suspend)(struct nand_chip *chip); > > > > + void (*_resume)(struct nand_chip *chip); > > > > > > I thought we agreed on not prefixing new hooks with _ ? > > > > For [PATCH v2] series, you mentioned to drop the _ prefix > > of _lock/_unlock only and we finally patched to lock_area/unlock_area. > > > > I missed this _, this is not something we want to add. > > Also, when applying your patches I had several issues because they > where not base on the last -rc1. > > Finally, I think I forgot a line when patching manually so it produces > a warning now. > > I am dropping patch 3 and 4, I keep patch 1 and 2 which seem fine. > > Please send a rebased and edited v4 for these, don't forget to drop the > kbuildtest robot tag and please also follow these slightly edited > commit logs: > > 2/4 > > mtd: rawnand: Add support for manufacturer specific suspend/resume operation > > Patch nand_suspend() & nand_resume() to let manufacturers overwrite > suspend/resume operations. > > 3/4 > > mtd: rawnand: macronix: Add support for deep power down mode > > Macronix AD series support deep power down mode for a minimum > power consumption state. > > Overlaod nand_suspend() & nand_resume() in Macronix specific code to > support deep power down mode. okay, will resend [PATCH v4 xx/2] for suspend/resume operation with these commit logs. > > Thanks, > Miquèl thanks for your review & comments. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================