From: Min Li <min.li.xe@renesas.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 2/2] ptp: idt82p33: implement double dco time correction
Date: Thu, 24 Jun 2021 14:40:52 +0000 [thread overview]
Message-ID: <OS3PR01MB659335F4857D1FD1E8977C24BA079@OS3PR01MB6593.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210624034343.GB6853@hoboy.vegasvil.org>
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: June 23, 2021 11:44 PM
> To: Min Li <min.li.xe@renesas.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net 2/2] ptp: idt82p33: implement double dco time
> correction
>
> On Wed, Jun 23, 2021 at 10:46:25AM -0400, min.li.xe@renesas.com wrote:
> > +static int idt82p33_start_ddco(struct idt82p33_channel *channel, s32
> > +delta_ns) {
> > + s32 current_ppm = channel->current_freq;
> > + u32 duration_ms = MSEC_PER_SEC;
>
> What happens if user space makes a new adjustment before this completes?
>
> After all, some PTP profiles update the clock several times per second.
>
> Thanks,
> Richard
Hi Richard
In that case, adjtime would simply return without doing anything as in
@@ -848,11 +914,15 @@ static int idt82p33_adjtime(struct ptp_clock_info *ptp, s64 delta_ns)
struct idt82p33 *idt82p33 = channel->idt82p33;
int err;
+ if (channel->ddco == true)
+ return 0;
+
next prev parent reply other threads:[~2021-06-24 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:46 [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-06-23 14:46 ` [PATCH net 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-06-24 3:43 ` Richard Cochran
2021-06-24 14:40 ` Min Li [this message]
2021-06-24 16:15 ` Richard Cochran
2021-06-24 3:40 ` [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime Richard Cochran
2021-06-24 14:38 ` Min Li
2021-06-24 16:14 ` Richard Cochran
2021-06-24 16:20 ` Richard Cochran
2021-06-25 14:24 ` Min Li
2021-06-25 16:20 ` Richard Cochran
2021-07-12 14:00 ` Min Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3PR01MB659335F4857D1FD1E8977C24BA079@OS3PR01MB6593.jpnprd01.prod.outlook.com \
--to=min.li.xe@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).