From: DLG Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"rafael@kernel.org" <rafael@kernel.org>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <support.opensource@diasemi.com>,
Amit Kucheria <amitk@kernel.org>
Subject: RE: [PATCH v2 21/26] thermal/drivers/da9062: Use generic thermal_zone_get_trip() function
Date: Wed, 10 Aug 2022 08:57:32 +0000 [thread overview]
Message-ID: <OS3PR01MB8365D21416FB02034E8B214DC2659@OS3PR01MB8365.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20220809220436.711020-22-daniel.lezcano@linaro.org>
On 09 August 2022 23:05, Daniel Lezcano wrote:
> The thermal framework gives the possibility to register the trip
> points with the thermal zone. When that is done, no get_trip_* ops are
> needed and they can be removed.
>
> Convert ops content logic into generic trip points and register them with the
> thermal zone.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
> ---
> drivers/thermal/da9062-thermal.c | 52 +++++---------------------------
> 1 file changed, 8 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-
> thermal.c
> index 180edec34e07..1e163e90d6b6 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -120,44 +120,6 @@ static irqreturn_t da9062_thermal_irq_handler(int
> irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static int da9062_thermal_get_trip_type(struct thermal_zone_device *z,
> - int trip,
> - enum thermal_trip_type *type)
> -{
> - struct da9062_thermal *thermal = z->devdata;
> -
> - switch (trip) {
> - case 0:
> - *type = THERMAL_TRIP_HOT;
> - break;
> - default:
> - dev_err(thermal->dev,
> - "Driver does not support more than 1 trip-wire\n");
> - return -EINVAL;
> - }
> -
> - return 0;
> -}
> -
> -static int da9062_thermal_get_trip_temp(struct thermal_zone_device *z,
> - int trip,
> - int *temp)
> -{
> - struct da9062_thermal *thermal = z->devdata;
> -
> - switch (trip) {
> - case 0:
> - *temp = DA9062_MILLI_CELSIUS(125);
> - break;
> - default:
> - dev_err(thermal->dev,
> - "Driver does not support more than 1 trip-wire\n");
> - return -EINVAL;
> - }
> -
> - return 0;
> -}
> -
> static int da9062_thermal_get_temp(struct thermal_zone_device *z,
> int *temp)
> {
> @@ -172,8 +134,10 @@ static int da9062_thermal_get_temp(struct
> thermal_zone_device *z,
>
> static struct thermal_zone_device_ops da9062_thermal_ops = {
> .get_temp = da9062_thermal_get_temp,
> - .get_trip_type = da9062_thermal_get_trip_type,
> - .get_trip_temp = da9062_thermal_get_trip_temp,
> +};
> +
> +static struct thermal_trip trips[] = {
> + { .temperature = DA9062_MILLI_CELSIUS(125), .type =
> THERMAL_TRIP_HOT },
> };
>
> static const struct da9062_thermal_config da9062_config = {
> @@ -228,10 +192,10 @@ static int da9062_thermal_probe(struct
> platform_device *pdev)
> INIT_DELAYED_WORK(&thermal->work, da9062_thermal_poll_on);
> mutex_init(&thermal->lock);
>
> - thermal->zone = thermal_zone_device_register(thermal->config-
> >name,
> - 1, 0, thermal,
> - &da9062_thermal_ops, NULL,
> pp_tmp,
> - 0);
> + thermal->zone = thermal_zone_device_register_with_trips(thermal-
> >config->name,
> + trips,
> ARRAY_SIZE(trips), 0, thermal,
> +
> &da9062_thermal_ops, NULL, pp_tmp,
> + 0);
> if (IS_ERR(thermal->zone)) {
> dev_err(&pdev->dev, "Cannot register thermal zone
> device\n");
> ret = PTR_ERR(thermal->zone);
> --
> 2.34.1
next prev parent reply other threads:[~2022-08-10 8:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 22:04 [PATCH v2 00/26] Rework the trip points creation Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 01/26] thermal/core: encapsulate ops->get_trip_* ops into a function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 02/26] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 03/26] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 04/26] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 05/26] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 06/26] thermal/drivers/imx: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 07/26] thermal/drivers/exynos: " Daniel Lezcano
2022-08-12 10:01 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 08/26] thermal/drivers/rcar: " Daniel Lezcano
2022-08-16 9:00 ` Niklas Söderlund
2022-08-09 22:04 ` [PATCH v2 09/26] thermal/drivers/uniphier: " Daniel Lezcano
2022-08-15 14:19 ` Kunihiko Hayashi
2022-08-09 22:04 ` [PATCH v2 10/26] thermal/drivers/hisi: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 11/26] thermal/drivers/qcom: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 12/26] thermal/drivers/OF: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 13/26] thermal/drivers/armada: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 14/26] thermal/core/OF: Remove unused functions Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-08-16 9:01 ` Niklas Söderlund
2022-08-09 22:04 ` [PATCH v2 16/26] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-08-12 10:02 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 17/26] thermal/core/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 18/26] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-08-12 10:02 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 19/26] thermal/core/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 20/26] thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 21/26] thermal/drivers/da9062: " Daniel Lezcano
2022-08-10 8:57 ` DLG Adam Ward [this message]
2022-08-09 22:04 ` [PATCH v2 22/26] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 23/26] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 24/26] thermal/drivers/cxgb4: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 25/26] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 26/26] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-12 17:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3PR01MB8365D21416FB02034E8B214DC2659@OS3PR01MB8365.jpnprd01.prod.outlook.com \
--to=dlg-adam.ward.opensource@dm.renesas.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).