linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kobayashi, Kento (Sony)" <Kento.A.Kobayashi@sony.com>
To: "balbi@kernel.org" <balbi@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Cao, Jacky" <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Date: Wed, 4 Sep 2019 06:12:11 +0000	[thread overview]
Message-ID: <OSAPR01MB49300F8CA0956F031CA4B1ECC9B80@OSAPR01MB4930.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>

Hi,

My company's member, Mr.Jacky, sent patch in June 26th.
But we didn't receive comment about our patch.
Could you confirm and tell us this patch is needed or not?

Regards,
Kento Kobayashi



From: Cao, Jacky <Jacky.Cao@sony.com> 
Sent: Monday, July 15, 2019 10:05 AM
To: balbi@kernel.org; gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@sony.com>; Cao, Jacky <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

Hi, 

Since around half month past, let me confirm the status of this issue.
If any comment about the fix patch, would you kind to share with us? 
Thank you.

Best Regards
Jacky

From: Cao, Jacky 
Sent: Wednesday, June 26, 2019 1:48 PM
To: mailto:balbi@kernel.org; mailto:gregkh@linuxfoundation.org; mailto:linux-usb@vger.kernel.org; mailto:linux-kernel@vger.kernel.org
Cc: Kobayashi, Kento (Sony) <mailto:Kento.A.Kobayashi@sony.com>; Cao, Jacky <mailto:Jacky.Cao@sony.com>
Subject: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.

If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.

Signed-off-by: Jacky Cao <mailto:Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"

 #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0  900  /* in mA */

 static const char  driver_name[] = "dummy_hcd";
static const char  driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
     dum_hcd->rh_state = DUMMY_RH_RUNNING;
     dum_hcd->stream_en_ep = 0;
     INIT_LIST_HEAD(&dum_hcd->urbp_list);
-     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
     dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
     dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
-- 
2.7.4

       reply	other threads:[~2019-09-04  6:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>
     [not found] ` <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>
2019-09-04  6:12   ` Kobayashi, Kento (Sony) [this message]
2019-09-04  6:19     ` Felipe Balbi
2019-09-04  6:57       ` Kobayashi, Kento (Sony)
     [not found] <16EA1F625E922C43B00B9D82250220500871C7D7@APYOKXMS108.ap.sony.com>
2019-09-04  7:46 ` Felipe Balbi
2019-09-04  7:54   ` Jacky.Cao
2019-09-04  7:52 Jacky.Cao
2019-09-04  7:54 ` Felipe Balbi
2019-09-04  7:58   ` Greg KH
2019-09-04  8:52     ` Jacky.Cao
2019-09-04 10:01       ` Greg KH
2019-09-04 14:21   ` Alan Stern
2019-09-05  4:18     ` Jacky.Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSAPR01MB49300F8CA0956F031CA4B1ECC9B80@OSAPR01MB4930.jpnprd01.prod.outlook.com \
    --to=kento.a.kobayashi@sony.com \
    --cc=Jacky.Cao@sony.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --subject='RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).