From: DLG Adam Thomson <DLG-Adam.Thomson.Opensource@dm.renesas.com>
To: Benjamin Bara <bbara93@gmail.com>,
"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Benjamin Bara <benjamin.bara@skidata.com>,
Richard Leitner <richard.leitner@skidata.com>
Subject: RE: [PATCH] regulator: da9063: disable unused voltage monitors
Date: Thu, 14 Jul 2022 09:36:01 +0000 [thread overview]
Message-ID: <OSAPR01MB50602133D5009DFE59C93458B0889@OSAPR01MB5060.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20220713124958.3094505-1-bbara93@gmail.com>
On 13 July 2022 13:50, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@skidata.com>
>
> This enables the kernel to disable the voltage monitor of unused regs.
>
> Some boards might use the PWR_OK functionality, which asserts GP_FB2
> if each measured voltage is in-range.
> However, if a regulator (which is enabled and monitored) is disabled,
> also its voltage monitor must be disabled to keep a valid PWR_OK state.
This proposal seemingly doesn't work. If you disable monitoring of a regulator,
and no other regulators are being monitored at that point, then GP_FB2 will no
longer be asserted and you have the same issue. What's more this patch impacts
all users and there's no means to re-enable monitoring. Certainly in the current
state this isn't a valid change.
What exactly is the problem you're attempting to resolve through this patch?
next prev parent reply other threads:[~2022-07-14 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:49 [PATCH] regulator: da9063: disable unused voltage monitors Benjamin Bara
2022-07-14 9:36 ` DLG Adam Thomson [this message]
2022-07-14 19:15 ` Benjamin Bara
2022-07-19 9:21 ` DLG Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB50602133D5009DFE59C93458B0889@OSAPR01MB5060.jpnprd01.prod.outlook.com \
--to=dlg-adam.thomson.opensource@dm.renesas.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).