From: "tarumizu.kohei@fujitsu.com" <tarumizu.kohei@fujitsu.com>
To: 'Dave Hansen' <dave.hansen@intel.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"reinette.chatre@intel.com" <reinette.chatre@intel.com>
Subject: RE: [PATCH v3 6/9] x86: resctrl: pseudo_lock: Fix to restore to original value when re-enabling hardware prefetch register
Date: Fri, 22 Apr 2022 12:01:30 +0000 [thread overview]
Message-ID: <OSBPR01MB20375064F05D713766BF210D80F79@OSBPR01MB2037.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <2eb705cd-8607-4b8c-2c0b-31265d503eed@intel.com>
Thanks for the comment.
> It would be nice to mention that the wrmsr()'s in this patch are only done inside of
> an interrupt-disabled region. Without that little tidbit of information, it's not
> obviously correct that the smp_call_function() in patch 8/9 is correct.
I would like to add description that the wrmsr()'s in this patch are
only done inside of an interrupt-disabled region.
> The x86 code here looks reasonable otherwise. It's a little bit of a shame that
> this is *ONLY* for BROADWELL_X for now, but I assume you were just
> conservative about it because that's all you have to test on.
That's right. It is possible to implement for other models based on
information provided by the Intel SDM. However, I didn't implement it
because I can test immediately with BROADWELL_X only.
next prev parent reply other threads:[~2022-04-22 12:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 3:02 [PATCH v3 0/9] Add hardware prefetch control driver for A64FX and x86 Kohei Tarumizu
2022-04-20 3:02 ` [PATCH v3 1/9] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu
2022-04-20 21:40 ` Thomas Gleixner
2022-04-22 12:10 ` tarumizu.kohei
2022-04-21 6:18 ` Greg KH
2022-04-22 12:30 ` tarumizu.kohei
2022-04-20 3:02 ` [PATCH v3 2/9] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu
2022-04-20 3:02 ` [PATCH v3 3/9] soc: fujitsu: Add hardware prefetch control support for A64FX Kohei Tarumizu
2022-04-20 3:02 ` [PATCH v3 4/9] soc: fujitsu: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-04-20 22:14 ` Thomas Gleixner
2022-04-20 3:02 ` [PATCH v3 5/9] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu
2022-04-20 3:02 ` [PATCH v3 6/9] x86: resctrl: pseudo_lock: Fix to restore to original value when re-enabling hardware prefetch register Kohei Tarumizu
2022-04-20 20:56 ` Dave Hansen
2022-04-22 12:01 ` tarumizu.kohei [this message]
2022-04-25 23:17 ` Reinette Chatre
2022-04-27 2:51 ` tarumizu.kohei
2022-04-20 3:02 ` [PATCH v3 7/9] x86: Add hardware prefetch control support for x86 Kohei Tarumizu
2022-04-20 22:27 ` Thomas Gleixner
2022-04-22 12:16 ` tarumizu.kohei
2022-04-20 3:02 ` [PATCH v3 8/9] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-04-20 3:02 ` [PATCH v3 9/9] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB20375064F05D713766BF210D80F79@OSBPR01MB2037.jpnprd01.prod.outlook.com \
--to=tarumizu.kohei@fujitsu.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).