From: Zhipeng Wang <zhipeng.wang_1@nxp.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module
Date: Wed, 30 Aug 2023 03:09:03 +0000 [thread overview]
Message-ID: <PAXPR04MB8304AA1D331B3DA5B548EE3EEBE6A@PAXPR04MB8304.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ZO4yTQAV9EYA4erZ@aurel32.net>
Hi Aurelien,
I'm not sure why we need to make cpufreq-dt-platdev autoloading, does it make sense? As I understand it we need to actively modprobe cpufreq-dt-platdev, why not?
BRs,
Zhipeng
> -----Original Message-----
> From: Aurelien Jarno <aurelien@aurel32.net>
> Sent: 2023年8月30日 2:01
> To: Zhipeng Wang <zhipeng.wang_1@nxp.com>
> Cc: rafael@kernel.org; viresh.kumar@linaro.org; linux-pm@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq
> platdev driver as module
>
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
>
>
> Hi,
>
> On 2023-05-24 15:34, Zhipeng Wang wrote:
> > Make the cpufreq platdev driver as tristate so that it can be built as
> > loadable module.
> >
> > Signed-off-by: Zhipeng Wang <zhipeng.wang_1@nxp.com>
> > ---
> > drivers/cpufreq/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > 2c839bd2b051..dda3a78bfd5c 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -218,7 +218,7 @@ config CPUFREQ_DT
> > If in doubt, say N.
> >
> > config CPUFREQ_DT_PLATDEV
> > - bool
> > + tristate "Generic DT based cpufreq platdev driver"
> > help
> > This adds a generic DT based cpufreq platdev driver for frequency
> > management. This creates a 'cpufreq-dt' platform device, on
> > the
>
> It seems that this new module is missing support for autoloading, causing issues
> with CPUFREQ_DT=m.
>
> Before that change, CPUFREQ_DT_PLATDEV ended up selected as =y. Now,
> CPUFREQ_DT_PLATDEV ends up selected as =m. As it is not autoloaded, it means
> that cpufreq-dt is not working anymore unless manually running "modprobe
> cpufreq-dt-platdev".
>
> Could you therefore please add support for autoloading?
>
> Thanks,
> Aurelien
>
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Faurel32.
> net%2F&data=05%7C01%7Czhipeng.wang_1%40nxp.com%7C84e6deca09fb4
> e86857608dba8b9df5f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C638289288492430681%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> 7C%7C&sdata=02iXE8HQXHNXRiA7SMtl%2B5ldGiVDF%2F7GtO%2F0DtAP0EQ
> %3D&reserved=0
next prev parent reply other threads:[~2023-08-30 3:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 15:34 [PATCH 1/2] cpufreq: dt-platdev: Add MODULE_LICENSE Zhipeng Wang
2023-05-24 10:45 ` Viresh Kumar
2023-05-24 11:32 ` [EXT] " Zhipeng Wang
2023-05-24 15:34 ` [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module Zhipeng Wang
2023-08-29 18:00 ` Aurelien Jarno
2023-08-30 3:09 ` Zhipeng Wang [this message]
2023-08-30 5:08 ` [EXT] " Aurelien Jarno
2023-08-31 10:50 ` Viresh Kumar
2023-06-02 4:12 ` [PATCH 1/2] cpufreq: dt-platdev: Add MODULE_LICENSE Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR04MB8304AA1D331B3DA5B548EE3EEBE6A@PAXPR04MB8304.eurprd04.prod.outlook.com \
--to=zhipeng.wang_1@nxp.com \
--cc=aurelien@aurel32.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).