From: Tanmay Jagdale <tanmay@marvell.com>
To: James Clark <james.clark@arm.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>,
"mike.leach@linaro.org" <mike.leach@linaro.org>
Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
George Cherian <gcherian@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
"coresight@lists.linaro.org" <coresight@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel timestamps
Date: Fri, 20 Jan 2023 17:44:24 +0000 [thread overview]
Message-ID: <PH0PR18MB50177B0B9AA2578C7F95243ED6C59@PH0PR18MB5017.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230120143702.4035046-1-james.clark@arm.com>
Hi James,
> Changes since v4:
>
> * Rebase onto perf/core
> * Convert new perf_pmu__cpu_slots_per_cycle() function to use
> new helper functions
>
> ===========================
> Changes since v3:
>
> * Scale time estimates by INSTR_PER_NS, rather than assuming 1
> instruction = 1ns
> * Add a new commit that fixes some issues around timestamps going
> backwards
> * Use nanoseconds inside cs-etm-decoder.c, rather than storing the
> raw time values and converting when a sample is synthesized. This
> simplifies some of the code like estimating the first timestamp.
>
> ===========================
> Changes since v2:
>
> * Remove const to non-const change and copy strings where needed
> instead.
> * Use sizeof() instead of PATH_MAX
> * Append "will not be set accurately." to new error message
> * Remove unneeded stat() call
> * Rebase on perf/core
>
> ==========================
>
> Changes since v1:
>
> * Add 3 refactor commits for sysfs reading around pmu.c as suggested
> by Arnaldo here [1]
> * The dependency on [2] has now reached mainline so is no longer
> blocking
> * Rebase on perf/core
>
> [1]: https://lore.kernel.org/all/YnqVqq5QW%2Fb14oPZ@kernel.org/
> [2]: https://lore.kernel.org/all/20220503123537.1003035-1-german.gomez@arm.com/
>
> German Gomez (4):
> perf pmu: Add function to check if a pmu file exists
> perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters
> perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE
> perf cs_etm: Set the time field in the synthetic samples
>
> James Clark (4):
> perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH
> perf: Use perf_pmu__open_file() and perf_pmu__scan_file()
> perf: Remove remaining duplication of bus/event_source/devices/...
> perf: cs-etm: Ensure that Coresight timestamps don't go backwards
>
> tools/perf/arch/arm/util/auxtrace.c | 5 +-
> tools/perf/arch/arm/util/cs-etm.c | 91 ++++++++-
> tools/perf/arch/arm64/util/pmu.c | 4 +-
> tools/perf/arch/x86/util/pmu.c | 12 +-
> tools/perf/util/cputopo.c | 9 +-
> tools/perf/util/cs-etm-base.c | 34 +++-
> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 68 +++++--
> tools/perf/util/cs-etm.c | 95 +++++++++-
> tools/perf/util/cs-etm.h | 16 +-
> tools/perf/util/pmu-hybrid.c | 27 +--
> tools/perf/util/pmu.c | 177 +++++++-----------
> tools/perf/util/pmu.h | 10 +-
> 12 files changed, 351 insertions(+), 197 deletions(-)
>
>
> base-commit: 1962ab6f6e0b39e4216206205bda14aff87705f3
> prerequisite-patch-id: 9722bf86e3e6d16d177ff9a1411992a795a7dcbd
> prerequisite-patch-id: b05dbef439c2ea8465f3321532257b0ca29f21f9
> prerequisite-patch-id: 92680a4781cbcf010fcb007e6ea030f59e9eaefc
> prerequisite-patch-id: 8e3a73a04e4b89b503377b5fac1d89d551159393
> prerequisite-patch-id: 09980d8fedcdaa70b220a7802428109f48448a58
For the series,
Tested-by: Tanmay Jagdale <tanmay@marvell.com>
Thanks,
Tanmay
> --
> 2.25.1
prev parent reply other threads:[~2023-01-20 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 14:36 [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel timestamps James Clark
2023-01-20 14:36 ` [PATCH v5 1/8] perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH James Clark
2023-01-20 14:36 ` [PATCH v5 2/8] perf: Use perf_pmu__open_file() and perf_pmu__scan_file() James Clark
2023-01-20 17:21 ` Arnaldo Carvalho de Melo
2023-01-20 17:32 ` Arnaldo Carvalho de Melo
2023-01-20 17:43 ` Arnaldo Carvalho de Melo
2023-01-23 10:36 ` James Clark
2023-01-20 14:36 ` [PATCH v5 3/8] perf: Remove remaining duplication of bus/event_source/devices/ James Clark
2023-01-20 14:36 ` [PATCH v5 4/8] perf pmu: Add function to check if a pmu file exists James Clark
2023-01-20 14:36 ` [PATCH v5 5/8] perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters James Clark
2023-01-20 14:36 ` [PATCH v5 6/8] perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE James Clark
2023-01-20 14:37 ` [PATCH v5 7/8] perf cs_etm: Set the time field in the synthetic samples James Clark
2023-01-20 14:37 ` [PATCH v5 8/8] perf: cs-etm: Ensure that Coresight timestamps don't go backwards James Clark
2023-01-20 17:12 ` Arnaldo Carvalho de Melo
2023-01-23 10:37 ` James Clark
2023-01-20 14:42 ` [PATCH v5 0/8] perf cs_etm: Basic support for virtual/kernel timestamps Suzuki K Poulose
2023-01-20 17:44 ` Tanmay Jagdale [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB50177B0B9AA2578C7F95243ED6C59@PH0PR18MB5017.namprd18.prod.outlook.com \
--to=tanmay@marvell.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bbhushan2@marvell.com \
--cc=coresight@lists.linaro.org \
--cc=gcherian@marvell.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=lcherian@marvell.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sgoutham@marvell.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).