From: Long Li <longli@microsoft.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
Ajay Sharma <sharmaajay@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [Patch v9 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter
Date: Tue, 1 Nov 2022 18:31:31 +0000 [thread overview]
Message-ID: <PH7PR21MB3263448BCCD27A72891A59F8CE369@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <Y2FW7Ba/krWc4nwP@nvidia.com>
> On Mon, Oct 31, 2022 at 07:32:24PM +0000, Long Li wrote:
> >
> > page_addr_list = create_req->page_addr_list;
> > rdma_umem_for_each_dma_block(umem, &biter, page_sz) {
> > page_addr_list[tail++] = rdma_block_iter_dma_address(&biter);
> > if (tail >= num_pages_to_handle) {
>
> if (tail <= num_pages_to_handle)
> continue
>
>
> And remove a level of indentation
>
> > u32 expected_s = 0;
> >
> > if (num_pages_processed &&
> > num_pages_processed + num_pages_to_handle <
> > num_pages_total) {
> > /* Status indicating more pages are needed */
> > expected_s = GDMA_STATUS_MORE_ENTRIES;
> > }
> >
> > if (!num_pages_processed) {
> > /* First message */
> > err = mana_ib_gd_first_dma_region(dev, gc,
> > create_req,
> > tail,
> > gdma_region);
> > if (err)
> > goto out;
> >
> > page_addr_list = add_req->page_addr_list;
> > } else {
> > err = mana_ib_gd_add_dma_region(dev, gc,
> > add_req, tail,
> > expected_s);
> > if (err) {
> > tail = 0;
> > break;
> > }
> > }
> >
> > num_pages_processed += tail;
> >
> > /* Prepare to send ADD_PAGE requests */
> > num_pages_to_handle =
> > min_t(size_t,
> > num_pages_total - num_pages_processed,
> > max_pgs_add_cmd);
> >
> > tail = 0;
> > }
> > }
> >
> > if (tail) {
> > if (!num_pages_processed) {
> > err = mana_ib_gd_first_dma_region(dev, gc, create_req,
> > tail, gdma_region);
> > if (err)
> > goto out;
> > } else {
> > err = mana_ib_gd_add_dma_region(dev, gc, add_req,
> > tail, 0);
> > }
> > }
>
> Usually this can be folded above by having the first if not continue if the end
> of the list is reached.
>
> Anyhow, this is much better
>
> Thanks,
> Jason
Thank you, I'm changing to those in the next patch.
Long
prev parent reply other threads:[~2022-11-01 18:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 0:01 [Patch v9 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-10-22 0:01 ` [Patch v9 01/12] net: mana: Add support for auxiliary device longli
2022-10-22 0:01 ` [Patch v9 02/12] net: mana: Record the physical address for doorbell page region longli
2022-10-22 0:01 ` [Patch v9 03/12] net: mana: Handle vport sharing between devices longli
2022-10-24 1:20 ` Yunsheng Lin
2022-10-24 18:45 ` Long Li
2022-10-25 1:08 ` Yunsheng Lin
2022-10-25 1:43 ` Long Li
2022-10-22 0:01 ` [Patch v9 04/12] net: mana: Set the DMA device max segment size longli
2022-10-22 0:01 ` [Patch v9 05/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-10-22 0:01 ` [Patch v9 06/12] net: mana: Record port number in netdev longli
2022-10-22 0:01 ` [Patch v9 07/12] net: mana: Move header files to a common location longli
2022-10-22 0:01 ` [Patch v9 08/12] net: mana: Define max values for SGL entries longli
2022-10-22 0:01 ` [Patch v9 09/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-10-22 0:01 ` [Patch v9 10/12] net: mana: Define data structures for allocating doorbell page from GDMA longli
2022-10-22 0:01 ` [Patch v9 11/12] net: mana: Define data structures for protection domain and memory registration longli
2022-10-22 0:01 ` [Patch v9 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-10-28 17:18 ` Jason Gunthorpe
2022-10-31 19:32 ` Long Li
2022-11-01 17:27 ` Jason Gunthorpe
2022-11-01 18:31 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB3263448BCCD27A72891A59F8CE369@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=shiraz.saleem@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).