From: Aditya Garg <gargaditya08@live.com>
To: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.
Date: Mon, 27 Sep 2021 04:35:00 +0000 [thread overview]
Message-ID: <PNZPR01MB4415FE077EAA0C094A8EE6DAB8A79@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <4dae80c3-034c-617b-c766-1858d6ee1220@protonmail.com>
I tried Orlando Chamberlain's patch on 5.14.7 but still the SSD is not being recognised.
________________________________________
From: Orlando Chamberlain <redecorating@protonmail.com>
Sent: Sunday, September 26, 2021 8:44 AM
To: Aditya Garg; sagi@grimberg.me; kbusch@kernel.org
Cc: torvalds@linux-foundation.org; axboe@fb.com; hch@lst.de; linux-nvme@lists.infradead.org; james.smart@broadcom.com; chaitanya.kulkarni@wdc.com; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; trivial@kernel.org
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.
On 26/9/21 18:07, Aditya Garg wrote:
> I checked out the proposal sent by Orlando Chamberlain to replace
> NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
> <http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html>.
> The , still causes panics to the T2 as described before. In the case of |, the
> kernel boots correctly without panicking the T2, but in case we are having Linux
> on an External Drive, which is my case, then the internal SSD doesn't seem to be
> recognised at all. I've tested the patch on 5.14.7. A screenshot of the GNOME
> Disks utility has been attached along with this mail.
I had some issues with the patch not applying automatically as I mixed up tabs and spaces,
(due to me copying stuff directly out of vim), so I had issues with getting patches to apply
automatically. I've checked that this file https://github.com/Redecorating/mbp-16.1-linux-wifi/blob/anbox-bt/1001-apple-t2-disable-nvme-gen-counter-quirk.patch
applies correctly for me (and github ci), so can you see if it still doesn't work with that?
prev parent reply other threads:[~2021-09-27 4:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PNZPR01MB4415600ACD3C8D9944F15058B8A59@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-25 18:47 ` [PATCH] Urgent bug fix causing Apple SSDs to not work Linus Torvalds
2021-09-25 19:54 ` Keith Busch
2021-09-25 20:08 ` Sven Peter
2021-09-25 20:38 ` Keith Busch
2021-09-25 20:48 ` Sven Peter
2021-09-25 20:34 ` Sagi Grimberg
2021-09-25 20:48 ` Keith Busch
[not found] ` <PNZPR01MB4415F5304CAA1A83442549DBB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
[not found] ` <PNZPR01MB4415986CC44AACC100AD1189B8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-26 8:44 ` Orlando Chamberlain
2021-09-27 4:35 ` Aditya Garg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PNZPR01MB4415FE077EAA0C094A8EE6DAB8A79@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM \
--to=gargaditya08@live.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).