From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbbKIPUe (ORCPT ); Mon, 9 Nov 2015 10:20:34 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:22124 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751213AbbKIPUc convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 10:20:32 -0500 X-IronPort-AV: E=Sophos;i="5.20,266,1444662000"; d="scan'208";a="199388587" From: Phil Edworthy To: Bjorn Helgaas CC: Wolfram Sang , Geert Uytterhoeven , Simon Horman , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thierry Reding , Ley Foon Tan , Jingoo Han Subject: RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thread-Topic: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thread-Index: AQHRFhpazS7O4def1E+1x+YbvdM7WJ6T04kg Date: Mon, 9 Nov 2015 15:20:24 +0000 Message-ID: References: <1446542899-25137-1-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1446542899-25137-1-git-send-email-phil.edworthy@renesas.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=phil.edworthy@renesas.com; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;PS1PR06MB1179;5:s8SS0vRZ18guoOAlrCtUXH1fZAuP/vM3+qNRusJqJe1C269NNG0PIAITtp911na55F0CAGWjupHgFJdKSRw3htFXNh4PCMumgU5KWmrAK8J+M1gqsAQh6dZm9Q9YSQ5xeG/F5Fwu/+RmdxEFGlplkg==;24:2F7pGjFbeCY3/C3++T4Fr0y06hyMip/RHJEEvQR5uv4XJCc+j0pWDLcF9hX05oPUsJhqTVG6MuYSMDbKviDEgXQnZjklzgrDEJ6WOINlrqs=;20:Z4V20O7E0UoWj0n3eheeFp20aiKJDORfx76glDc521aCYen8HlfqYA0qeE3zwYh1DllGWx1LW6n/VWga6ETmdCOUYUt573APUrjH5YewBwnmqTdqi2olE2RqcpWIu84FYqpbvtqTtaXe8QXLmlZW4Ivkd7Z9ZeSWlum/pU/teQY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1179; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85106069007906); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046);SRVR:PS1PR06MB1179;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1179; x-forefront-prvs: 0755F54DD9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(24454002)(189998001)(122556002)(5008740100001)(110136002)(33656002)(5007970100001)(19580395003)(76576001)(2900100001)(5001920100001)(81156007)(2950100001)(11100500001)(101416001)(10400500002)(102836002)(5004730100002)(74316001)(54356999)(77096005)(76176999)(5001960100002)(50986999)(87936001)(86362001)(92566002)(5003600100002)(105586002)(40100003)(66066001)(5002640100001)(106356001)(106116001)(97736004)(19580405001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1179;H:PS1PR06MB1180.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2015 15:20:24.7984 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1179 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cc'ing others (Tegra, Altera, Designware) who may have the same bug On 03 November 2015 09:28, Phil Edworthy wrote: > The OF node passed to irq_domain_add_linear() should be a > pointer to interrupt controller's device tree node, or NULL, > but not the PCI controller's node. > > This fixes an oops in msi_domain_alloc_irqs() when it tries > to call msi_check(). > > Signed-off-by: Phil Edworthy > --- > drivers/pci/host/pcie-rcar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index 2377bf0..c6fa562 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -709,7 +709,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie *pcie) > msi->chip.setup_irq = rcar_msi_setup_irq; > msi->chip.teardown_irq = rcar_msi_teardown_irq; > > - msi->domain = irq_domain_add_linear(pcie->dev->of_node, > INT_PCI_MSI_NR, > + msi->domain = irq_domain_add_linear(NULL, INT_PCI_MSI_NR, > &msi_domain_ops, &msi->chip); > if (!msi->domain) { > dev_err(&pdev->dev, "failed to create IRQ domain\n"); > -- > 1.9.1