From: Dexuan Cui <decui@microsoft.com>
To: David Hildenbrand <david@redhat.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"sashal@kernel.org" <sashal@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>
Subject: RE: [PATCH] hv_balloon: Add the support of hibernation
Date: Thu, 26 Sep 2019 17:42:29 +0000 [thread overview]
Message-ID: <PU1P153MB016917228A692F581CEA8C10BF860@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <2134429f-dc6d-06e0-9e4b-9028f62f6666@redhat.com>
> From: David Hildenbrand <david@redhat.com>
> Sent: Thursday, September 26, 2019 12:20 AM
> To: Dexuan Cui <decui@microsoft.com>; KY Srinivasan <kys@microsoft.com>;
> Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; sashal@kernel.org;
> linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Kelley
> <mikelley@microsoft.com>
> Subject: Re: [PATCH] hv_balloon: Add the support of hibernation
>
> On 25.09.19 22:03, Dexuan Cui wrote:
> >> From: linux-hyperv-owner@vger.kernel.org
> >> [... snipped ...]
> >>> Anyhow, just some comments from my side :) I can see how Windows
> Server
> >>> worked around that issue right now by just XOR'ing both features.
> >>>
> >>> David / dhildenb
> >>
> >> Thanks for sharing your thoughts!
> >>
> >> -- Dexuan
> >
> > Hi David,
> > If my explanation sounds good to you, can I have an Acked-by from you?
> >
>
> I do ACK the approach but not the patch in it's current state. I don't
> like the ifdefs - once you can get rid of the ifdefery - e.g., after the
> prerequisite is upstream - you can add my
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
> David / dhildenb
Makes sense. I'll wait for the prerequisite patch (i.e. the patch that implements
hv_is_hibernation_supported(), https://lkml.org/lkml/2019/9/5/1160 ) to be
in upstream first, then I'll be able to get rid of the below "if 0" and post a v2
with your Acked-by. Thanks, David!
+#if 0
+ /*
+ * The patch to implement hv_is_hibernation_supported() is going
+ * through the tip tree. For now, let's hardcode allow_hibernation
+ * to false to keep the current behavior of hv_balloon. If people
+ * want to test hibernation, please blacklist hv_balloon fow now
+ * or do not enable Dynamid Memory and Memory Resizing.
+ *
+ * We'll remove the conditional compilation as soon as
+ * hv_is_hibernation_supported() is available in the mainline tree.
+ */
+ allow_hibernation = hv_is_hibernation_supported();
+#else
+ allow_hibernation = false;
Thanks,
-- Dexuan
prev parent reply other threads:[~2019-09-26 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 23:36 [PATCH] hv_balloon: Add the support of hibernation Dexuan Cui
2019-09-12 10:08 ` David Hildenbrand
2019-09-12 10:11 ` David Hildenbrand
2019-09-12 19:18 ` Dexuan Cui
2019-09-13 7:46 ` David Hildenbrand
2019-09-13 20:54 ` Dexuan Cui
2019-09-13 21:44 ` David Hildenbrand
2019-09-14 0:26 ` Dexuan Cui
2019-09-25 20:03 ` Dexuan Cui
2019-09-26 7:19 ` David Hildenbrand
2019-09-26 17:42 ` Dexuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PU1P153MB016917228A692F581CEA8C10BF860@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=david@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).