From: Alexander Viro <viro@math.psu.edu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] turn device_init() into an initcall
Date: Tue, 15 May 2001 12:36:10 -0400 (EDT) [thread overview]
Message-ID: <Pine.GSO.4.21.0105151231250.21081-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <Pine.GSO.4.21.0105151148580.21081-100000@weyl.math.psu.edu>
On Tue, 15 May 2001, Alexander Viro wrote:
> ramdisks, etc.). Besides, it allows to start turning functions called
> from device_init() into initcalls, thus getting rid of ifdef dungpiles
> in them.
... and here's the next part. Takes parport_init() out of device_init().
Since we have no initcalls in parport/* we don't break the ordering.
Please, apply - it's incremental to previous.
diff -urN S5-pre2-init-0/drivers/Makefile S5-pre2-init/drivers/Makefile
--- S5-pre2-init-0/drivers/Makefile Fri Feb 16 21:09:52 2001
+++ S5-pre2-init/drivers/Makefile Tue May 15 12:15:41 2001
@@ -9,7 +9,7 @@
mod-subdirs := dio mtd sbus video macintosh usb input telephony sgi i2o ide \
scsi md ieee1394 pnp isdn atm fc4 net/hamradio i2c acpi
-subdir-y := block char net parport sound misc media cdrom
+subdir-y := parport block char net sound misc media cdrom
subdir-m := $(subdir-y)
diff -urN S5-pre2-init-0/drivers/block/genhd.c S5-pre2-init/drivers/block/genhd.c
--- S5-pre2-init-0/drivers/block/genhd.c Tue May 15 12:15:13 2001
+++ S5-pre2-init/drivers/block/genhd.c Tue May 15 12:18:29 2001
@@ -17,7 +17,6 @@
#include <linux/blk.h>
#include <linux/init.h>
-extern int parport_init(void);
extern int chr_dev_init(void);
extern int blk_dev_init(void);
#ifdef CONFIG_BLK_DEV_DAC960
@@ -33,9 +32,6 @@
int __init device_init(void)
{
-#ifdef CONFIG_PARPORT
- parport_init();
-#endif
chr_dev_init();
blk_dev_init();
sti();
diff -urN S5-pre2-init-0/drivers/parport/init.c S5-pre2-init/drivers/parport/init.c
--- S5-pre2-init-0/drivers/parport/init.c Fri Feb 16 22:53:48 2001
+++ S5-pre2-init/drivers/parport/init.c Tue May 15 12:26:44 2001
@@ -165,6 +165,8 @@
return 0;
}
+__initcall(parport_init);
+
#endif
/* Exported symbols for modules. */
next prev parent reply other threads:[~2001-05-15 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-15 15:56 [PATCH] turn device_init() into an initcall Alexander Viro
2001-05-15 16:36 ` Alexander Viro [this message]
2001-05-15 17:06 ` Alexander Viro
2001-05-16 11:47 ` Alexander Viro
-- strict thread matches above, loose matches on Subject: below --
2001-05-03 1:21 Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0105151231250.21081-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).