From: Alexander Viro <viro@math.psu.edu>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.10pre11aa1
Date: Wed, 19 Sep 2001 04:49:17 -0400 (EDT) [thread overview]
Message-ID: <Pine.GSO.4.21.0109190420510.28824-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <20010918230242.F720@athlon.random>
On Tue, 18 Sep 2001, Andrea Arcangeli wrote:
> Thanks also to Marcelo for promptly finding a problem in the vm rewrite,
> to Al Viro for having spotted promptly a silly bug in the
> blkdev-pagecache patch (see details on l-k) and for all the people
> who provided feedback over the last day.
I can add one more into the mix: what the hell had happened in rd.c?
a) you reintroduced the crap with rd_inodes[]
b) just try to call ioctl(fd, BLKFLSBUF) twice. Oops...
c) WTF with acrobatics around initrd_bd_op? FWIW, initrd has no business
being a block device and both old and new variants are ugly, but what's
the point of adding extra tricks?
d) call ioctl(fd, BLKFLSBUF) and open the thing one more time before
closing fd. Watch what happens. It's broken by design.
I realize that you had that file modified in your tree, but bloody hell,
it doesn't mean "ignore any changes that happened in mainline kernel
without even looking at them". As for the BLKFLSBUF... How was it supposed
to work?
next parent reply other threads:[~2001-09-19 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010918230242.F720@athlon.random>
2001-09-19 8:49 ` Alexander Viro [this message]
2001-09-19 12:07 ` 2.4.10pre11aa1 Alexander Viro
2001-09-19 12:54 ` 2.4.10pre11aa1 Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0109190420510.28824-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).