From: Alexander Viro <viro@math.psu.edu>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Richard Gooch <rgooch@atnf.csiro.au>,
Rik van Riel <riel@conectiva.com.br>,
Ryan Cumming <bodnar42@phalynx.dhs.org>,
linux-kernel@vger.kernel.org
Subject: Re: more devfs fun (Piled Higher and Deeper)
Date: Sun, 28 Oct 2001 08:16:12 -0500 (EST) [thread overview]
Message-ID: <Pine.GSO.4.21.0110280805220.24880-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <3BDBF9C8.8E1F96AB@linux-m68k.org>
On Sun, 28 Oct 2001, Roman Zippel wrote:
> What about putting them somewhere in a CVS repository, so people can see
> what's going on and maybe even can help out?
Looks like I'll get around to creating a CVS repository starting at the
last known code in a couple of days anyway...
> BTW you should really do something about your coding style, your code is
> very confusing to read. I wouldn't care if it would be just some driver,
> but devfs is supposed to be a very important part, so it would be nice
> to use the same rules that apply to other important parts of the kernel.
Good luck.
BTW, Richard - the last one for tonight:
devfs_unregister() vs. get_vfs_inode(). The latter blocks, so devfs_lookup()
and devfs_d_revalidate() can give you a nasty surprise - entry gets
unregistered while we allocate the inode and there's no connection between
it and inode or dentry at that point. Then we merrily get dentry/inode
tied to unregistered devfs_entry. And that includes reference _to_ dentry.
Enjoy...
next prev parent reply other threads:[~2001-10-28 13:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-27 15:00 Poor floppy performance in kernel 2.4.10 Alain Knaff
2001-10-27 15:15 ` Alexander Viro
2001-10-27 17:12 ` Alain Knaff
2001-10-27 17:42 ` Alexander Viro
2001-10-27 18:00 ` Alain Knaff
2001-10-27 18:13 ` Alexander Viro
2001-10-27 18:26 ` Alexander Viro
2001-10-27 19:02 ` more devfs fun Alexander Viro
2001-10-27 19:16 ` Alexander Viro
2001-10-27 19:50 ` more devfs fun (Piled Higher and Deeper) Alexander Viro
2001-10-27 20:06 ` Alexander Viro
2001-10-27 21:09 ` Ryan Cumming
2001-10-27 21:22 ` Alexander Viro
2001-10-28 1:00 ` Rik van Riel
2001-10-28 8:45 ` Richard Gooch
2001-10-28 9:54 ` Alexander Viro
2001-10-28 12:27 ` Roman Zippel
2001-10-28 13:16 ` Alexander Viro [this message]
2001-10-28 22:31 ` Richard Gooch
2001-10-28 23:11 ` Alexander Viro
2001-10-27 21:01 ` Alexander Viro
2001-11-06 6:35 ` Richard Gooch
2001-11-06 7:10 ` Alexander Viro
2001-11-06 7:14 ` Richard Gooch
2001-11-06 7:17 ` Alexander Viro
2001-11-06 20:14 ` Richard Gooch
2001-10-28 10:06 ` Lorenzo Allegrucci
2001-11-06 5:21 ` Richard Gooch
2001-11-06 5:17 ` more devfs fun Richard Gooch
2001-11-06 5:06 ` Richard Gooch
2001-11-06 7:01 ` Poor floppy performance in kernel 2.4.10 Richard Gooch
2001-11-06 7:03 ` Alexander Viro
2001-12-09 5:38 ` Devfs races with block devices Richard Gooch
2001-11-06 7:19 ` Poor floppy performance in kernel 2.4.10 Richard Gooch
2001-11-06 7:22 ` Alexander Viro
2001-10-27 19:13 ` Alain Knaff
2001-10-27 19:19 ` Alexander Viro
2001-10-27 19:26 ` Alain Knaff
2001-10-28 20:40 ` Alain Knaff
2001-10-28 20:57 ` Peter T. Breuer
2001-10-29 5:38 ` Alain Knaff
2001-10-29 6:07 ` Alexander Viro
2001-10-29 6:34 ` Alain Knaff
2001-10-28 21:42 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0110280805220.24880-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=bodnar42@phalynx.dhs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgooch@atnf.csiro.au \
--cc=riel@conectiva.com.br \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).