From: Alexander Viro <viro@math.psu.edu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CFT][PATCH] ramfs/tmpfs readdir()
Date: Sun, 4 Nov 2001 13:20:58 -0500 (EST) [thread overview]
Message-ID: <Pine.GSO.4.21.0111041314330.21449-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <Pine.LNX.4.33.0111040943160.6919-100000@penguin.transmeta.com>
On Sun, 4 Nov 2001, Linus Torvalds wrote:
> This is better than what we have, though, so I wouldn't object to the
> patch. I wonder why you export the internal dcache functions, though? The
> only thing that _should_ need exporting is "dcache_dir_ops", no? We don't
> want other filesystems mucking with the internals of this, as far as I can
> tell.
I would love to. But autofs4 doesn't allow that, what with ioctls on
root directory... It's the only place that uses individual functions,
though - the rest just uses dcache_dir_ops.
> Admittedly linear traversal is the _common_ case, and arguably the much
> more important of the two. However, right is right, and a true quality
> implementation gets seekdir/telldir right too.
>
> Have you looked at how nasty the d_offset thing would be?
I'll look into that, but frankly, I'm not too optimistic.
next prev parent reply other threads:[~2001-11-04 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-04 15:52 [CFT][PATCH] ramfs/tmpfs readdir() Alexander Viro
2001-11-04 17:55 ` Linus Torvalds
2001-11-04 18:20 ` Alexander Viro [this message]
2001-11-04 18:27 Manfred Spraul
2001-11-05 13:05 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0111041314330.21449-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).