From: Alexander Viro <viro@math.psu.edu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] disk throughput
Date: Mon, 5 Nov 2001 23:21:15 -0500 (EST) [thread overview]
Message-ID: <Pine.GSO.4.21.0111052306150.27713-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <Pine.LNX.4.33.0111051953490.1006-100000@penguin.transmeta.com>
On Mon, 5 Nov 2001, Linus Torvalds wrote:
>
> On Mon, 5 Nov 2001, Alexander Viro wrote:
> >
> > OK, some digging had brought another one:
> >
> > a) if it's first-level directory - get it the fsck out of root's cylinder
> > group.
>
> Hey, now that you've read it in a paper you like it, but when I suggest it
> in email you shoot it down?
>
> <Whiny mode on> I thought you loved me, Al. <Whiny mode off>
Oh, come on. (a) is obvious, but obviously not enough ;-)
> > b) if we just keep creating directories in a cylinder group and do not
> > create any files there - stop, it's no good (i.e. there's a limit on
> > number of back-to-back directory creations in the same group).
>
> The current code actually has some vestiges that _seem_ to be trying to do
> something like this: see the commented-out
>
> if (tmp && le16_to_cpu(tmp->bg_used_dirs_count) << 8) <
> le16_to_cpu(tmp->bg_free_inodes_count)) {
>
> which _seems_ to want to play games with "number of directories allocated
> vs nr of free inodes".
>
> But it's commented out with "I am not yet convinced that this next bit is
> necessary". I don't know if the code has ever been active, or whether it
> showed other problems.
>
> > c) try putting it into the parent's CG, but reserve some number of inodes
> > and data blocks in it. If we can't - tough, get the fsck out of there.
>
> Hmm.. Maybe this is actually closer to what we try to do above..
Yes, but block reservation also makes sense (otherwise we can end up
putting a directory into parent's CG only to have all children
going there _and_ getting far from their data). Which might be the
problem with original code, BTW.
OK, anyway - I've got a bunch of cleanups for ialloc.c (equivalent
transformations, split into small steps and decently tested - I've
used them for almost a year). That stuff moves choice of CG for
directories and non-directories into separate functions, so no
matter which variant we end up doing I think that it's worth doing
first - things will be cleaner after that.
next prev parent reply other threads:[~2001-11-06 4:21 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-05 2:13 disk throughput Andrew Morton
2001-11-05 3:20 ` Mohammad A. Haque
2001-11-05 3:31 ` Andrew Morton
2001-11-05 3:32 ` [Ext2-devel] " Mike Fedyk
2001-11-05 3:45 ` Andrew Morton
2001-11-05 4:39 ` Mike Fedyk
2001-11-05 7:06 ` Jens Axboe
2001-11-05 7:14 ` Andrew Morton
2001-11-05 7:26 ` Jens Axboe
2001-11-05 7:14 ` Mike Fedyk
2001-11-05 7:18 ` Jens Axboe
2001-11-05 7:18 ` Jens Axboe
2001-11-05 9:14 ` Mike Fedyk
2001-11-05 9:20 ` Jens Axboe
2001-11-05 5:54 ` Albert D. Cahalan
2001-11-05 8:04 ` Andrew Morton
2001-11-05 12:28 ` Matthias Andree
2001-11-05 14:23 ` Alexander Viro
2001-11-05 22:22 ` Andrew Morton
2001-11-05 22:41 ` Andreas Dilger
2001-11-05 22:53 ` Andrew Morton
2001-11-08 15:28 ` Constantin Loizides
2001-11-05 23:14 ` Dan Hollis
2001-11-06 10:52 ` Daniel Phillips
2001-11-06 16:17 ` Jeremy Fitzhardinge
2001-11-08 15:24 ` Constantin Loizides
2001-11-08 16:46 ` Jeremy Fitzhardinge
2001-11-09 6:08 ` Andrew Morton
2001-11-09 8:49 ` Jeremy Fitzhardinge
2001-11-06 21:45 ` Stephen Tweedie
2001-11-05 20:16 ` Andreas Dilger
2001-11-05 20:28 ` m
2001-11-05 21:39 ` Andrew Morton
2001-11-05 22:59 ` Linus Torvalds
2001-11-05 23:36 ` Alexander Viro
2001-11-05 23:50 ` Linus Torvalds
2001-11-06 0:03 ` Linus Torvalds
2001-11-06 1:33 ` Alexander Viro
2001-11-06 2:10 ` Linus Torvalds
2001-11-06 3:02 ` Alexander Viro
2001-11-06 8:39 ` Alan Cox
2001-11-06 8:37 ` Alexander Viro
2001-11-06 8:48 ` Andrew Morton
2001-11-06 3:49 ` Alexander Viro
2001-11-06 4:01 ` Linus Torvalds
2001-11-06 4:21 ` Alexander Viro [this message]
2001-11-06 5:01 ` Linus Torvalds
2001-11-06 5:31 ` Andrew Morton
2001-11-06 5:48 ` Linus Torvalds
2001-11-06 7:34 ` Mike Castle
2001-11-06 7:10 ` Kai Henningsen
2001-11-09 22:35 ` Riley Williams
2001-11-06 1:28 ` Alexander Viro
2001-11-06 9:16 ` Wojtek Pilorz
2001-11-06 9:58 ` Alexander Viro
2001-11-08 12:51 ` Pavel Machek
2001-11-06 21:48 ` Stephen Tweedie
2001-11-06 23:17 ` ext2/ialloc.c cleanup Alexander Viro
2001-11-07 19:34 ` [Ext2-devel] " Andreas Dilger
2001-11-07 20:02 ` Alexander Viro
2001-11-08 2:06 ` Andrew Morton
2001-11-08 20:45 ` Andrew Morton
2001-11-08 22:16 ` Alexander Viro
2001-11-08 22:43 ` Andreas Dilger
2001-11-08 23:08 ` Alexander Viro
2001-11-09 6:15 ` Andrew Morton
2001-11-09 6:56 ` Andreas Dilger
2001-11-09 7:09 ` Andrew Morton
2001-11-09 7:12 ` Alexander Viro
2001-11-09 7:18 ` Andrew Morton
2001-11-05 9:45 ` [Ext2-devel] disk throughput Alex Bligh - linux-kernel
2001-11-05 9:58 ` Alex Bligh - linux-kernel
2001-11-05 8:47 ` Jan Kara
2001-11-05 8:50 ` [Ext2-devel] " Mike Fedyk
2001-11-05 9:01 ` Jan Kara
2001-11-05 12:23 ` Matthias Andree
2001-11-05 22:39 ` Andrew Morton
2001-11-05 23:41 ` Matthias Andree
2001-11-12 6:04 [Ext2-devel] " Yan, Noah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0111052306150.27713-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).