From: Alexander Viro <viro@math.psu.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark Peloquin <peloquin@us.ibm.com>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org,
evms-devel@lists.sourceforge.net
Subject: Re: [Evms-devel] Re: [PATCH] EVMS core 3/4: evms_ioctl.h
Date: Mon, 7 Oct 2002 13:50:00 -0400 (EDT) [thread overview]
Message-ID: <Pine.GSO.4.21.0210071340580.29030-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <20021007183415.A22316@infradead.org>
On Mon, 7 Oct 2002, Christoph Hellwig wrote:
> I don't think that basing kernel internal interfaces on ioctl is
> a smart idea. Just add another function pionter to your operations
> vector for every operation you want supported on volumes.
s/every/& generic/. Other than that, seconded. BTW, one of the pending
changes is taking the last more or less generic ioctl (HDIO_GETGEO) into
a separate method...
->ioctl() is for driver-specific crud; stuff that won't be used by
any generic application. "Make a cuckoo jump out of drive and sing
'1000 bottles of beer'" is a valid ioctl. "Get drive size" isn't.
next prev parent reply other threads:[~2002-10-07 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 16:43 [Evms-devel] Re: [PATCH] EVMS core 3/4: evms_ioctl.h Mark Peloquin
2002-10-07 17:34 ` Christoph Hellwig
2002-10-07 17:50 ` Alexander Viro [this message]
2002-10-07 18:40 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2002-10-04 14:44 Mark Peloquin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0210071340580.29030-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=evms-devel@lists.sourceforge.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peloquin@us.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).