linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH] IDE DMA (2.4.x)
Date: Fri, 23 May 2003 15:44:57 +0200 (MEST)	[thread overview]
Message-ID: <Pine.GSO.4.21.0305231542290.26586-100000@vervain.sonytel.be> (raw)

	Hi Alan,

IDE DMA suggestions:
  - Add DMA activity test to ide_raw_build_sglist() (cfr. ide_build_sglist()).
    Does this make sense? Or should the test in ide_build_sglist() be removed?
  - Fix linuxdoc comments
  - Fix typo (probably introduced by the spelling police, thinking that
    `retune' was a typo ;-)

--- linux-2.4.x/drivers/ide/ide-dma.c.orig	Mon May  5 16:26:10 2003
+++ linux-2.4.x/drivers/ide/ide-dma.c	Thu May 15 18:19:11 2003
@@ -320,6 +320,9 @@
 	u8 *virt_addr = rq->buffer;
 	int sector_count = rq->nr_sectors;
 
+	if (hwif->sg_dma_active)
+		BUG();
+
 	if (args->command_type == IDE_DRIVE_TASK_RAW_WRITE)
 		hwif->sg_dma_direction = PCI_DMA_TODEVICE;
 	else
@@ -581,7 +584,7 @@
 EXPORT_SYMBOL(__ide_dma_host_off);
 
 /**
- *	__ide_dma_host_off_quietly	-	Generic DMA kill
+ *	__ide_dma_off_quietly	-	Generic DMA kill
  *	@drive: drive to control
  *
  *	Turn off the current DMA on this IDE controller. 
@@ -597,7 +600,7 @@
 EXPORT_SYMBOL(__ide_dma_off_quietly);
 
 /**
- *	__ide_dma_host_off	-	Generic DMA kill
+ *	__ide_dma_off		-	Generic DMA kill
  *	@drive: drive to control
  *
  *	Turn off the current DMA on this IDE controller. Inform the
@@ -945,7 +948,7 @@
  *	__ide_dma_retune	-	default retune handler
  *	@drive: drive to retune
  *
- *	Default behaviour when we decide to return the IDE DMA setup.
+ *	Default behaviour when we decide to retune the IDE DMA setup.
  *	The default behaviour is "we don't"
  */
  

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


                 reply	other threads:[~2003-05-23 13:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.21.0305231542290.26586-100000@vervain.sonytel.be \
    --to=geert@linux-m68k.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] IDE DMA (2.4.x)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox