From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270212AbTHLKE6 (ORCPT ); Tue, 12 Aug 2003 06:04:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270214AbTHLKE6 (ORCPT ); Tue, 12 Aug 2003 06:04:58 -0400 Received: from mail2.sonytel.be ([195.0.45.172]:15564 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S270212AbTHLKE4 (ORCPT ); Tue, 12 Aug 2003 06:04:56 -0400 Date: Tue, 12 Aug 2003 12:03:21 +0200 (MEST) From: Geert Uytterhoeven To: Maciej Soltysiak cc: Greg KH , Matthew Wilcox , Robert Love , CaT , Linux Kernel Development , kernel-janitor-discuss@lists.sourceforge.net Subject: Re: C99 Initialisers In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Aug 2003, Maciej Soltysiak wrote: > > > static struct pci_device_id tg3_pci_tbl[] __devinitdata = { > > > { > > > .vendor = PCI_VENDOR_ID_BROADCOM, > > > .device = PCI_DEVICE_ID_TIGON3_5700, > > > .subvendor = PCI_ANY_ID, > > > .subdevice = PCI_ANY_ID, > > > .class = 0, > > > .class_mask = 0, > > > .driver_data = 0, > > > }, > > > > I sure would. Oh, you can drop the .class, .class_mask, and > > .driver_data lines, and then it even looks cleaner. > Just a quick question. if we drop these, will they _always_ > be initialised 0 ? I have made a test to see, and it seemed as though, > but I would like to be 100% sure. For globals and static locals: yes. For non-static locals: no. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds