From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] SCSI NCR53C9x.c: some cleanups
Date: Mon, 17 Jan 2005 13:58:56 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.4.61.0501171358230.3299@waterleaf.sonytel.be> (raw)
In-Reply-To: <20050117125449.GP4274@stusta.de>
On Mon, 17 Jan 2005, Adrian Bunk wrote:
> On Mon, Jan 17, 2005 at 01:41:29PM +0100, Geert Uytterhoeven wrote:
> > On Tue, 21 Dec 2004, Linux Kernel Mailing List wrote:
> > > ChangeSet 1.2034.61.36, 2004/12/21 09:41:18-06:00, bunk@stusta.de
> > >
> > > [PATCH] SCSI NCR53C9x.c: some cleanups
> > >
> > > Make two functions static
> >
> > > --- a/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00
> > > +++ b/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00
> > > @@ -505,7 +505,7 @@
> > > }
> > >
> > > /* This places the ESP into a known state at boot time. */
> > > -void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
> > > +static void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
> > > {
> > > volatile unchar trash;
> > >
> >
> > This change breaks the Amiga Oktagon SCSI driver (drivers/scsi/oktagon_esp.c),
> > which calls esp_bootup_reset().
>
> My bad - I did grep for esp_bootup_reset, but I confused the function
> prototype in oktagon_esp.c with a local function in this file.
>
> @Linus:
> Please exclude my buggy patch.
Or better: I'll move the prototype to drivers/scsi/NCR53C9x.h.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2005-01-17 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200412290732.iBT7WifI018047@hera.kernel.org>
2005-01-17 12:41 ` [PATCH] SCSI NCR53C9x.c: some cleanups Geert Uytterhoeven
2005-01-17 12:54 ` Adrian Bunk
2005-01-17 12:58 ` Geert Uytterhoeven [this message]
2005-01-17 19:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.61.0501171358230.3299@waterleaf.sonytel.be \
--to=geert@linux-m68k.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).