From: Linus Torvalds <torvalds@transmeta.com>
To: Jens Axboe <axboe@suse.de>
Cc: Neil Brown <neilb@cse.unsw.edu.au>, linux-kernel@vger.kernel.org
Subject: Re: PATCH: rd - deadlock removal
Date: Thu, 9 Nov 2000 10:02:35 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.10.10011091001030.1909-100000@penguin.transmeta.com> (raw)
In-Reply-To: <20001109103511.G467@suse.de>
On Thu, 9 Nov 2000, Jens Axboe wrote:
>
> > The second is more elegant in that it side steps the problem by
> > giving rd.c a make_request function instead of using the default
> > _make_request. This means that io_request_lock is simply never
> > claimed my rd.
>
> And this solution is much better, even given the freeze I think that
> is the way to go.
I agree, I already applied it. The second approach just makes the problem
go away, and also avoids needlessly merging the request etc. I suspect
that the lack of request-merging could also eventually be used to simplify
the driver a bit, as it now wouldn't need to worry about that issue any
more at all.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-11-09 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-09 0:08 PATCH: rd - deadlock removal Neil Brown
2000-11-09 9:35 ` Jens Axboe
2000-11-09 18:02 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10011091001030.1909-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).