From: Linus Torvalds <torvalds@transmeta.com>
To: Ragnar Hojland Espinosa <ragnar@jazzfree.com>
Cc: Andries.Brouwer@cwi.nl, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: {PATCH} isofs stuff
Date: Thu, 23 Nov 2000 09:20:15 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.10.10011230911200.7992-100000@penguin.transmeta.com> (raw)
In-Reply-To: <20001123175849.A116@macula.net>
On Thu, 23 Nov 2000, Ragnar Hojland Espinosa wrote:
>
> Yup, indeed it solves the dir/namei problem.
Can you check whether the single patch of _just_ removing the extra "f_pos
>= i_size" test in do_isofs_readdir() fixes it? The other changes of
Andries patch look like they should not affect code generation at all, but
I'd still like to verify that it's only that part. If so, it definitely
looks like a gcc-2.95.2 code generation bug - that single if() statement
does not actually matter for the end result, it's just a (misguided)
early-out optimization.
[ Btw, looking at the generated assembly is quite painful. Ugh. It reminds
me again why "long long" is to be avoided with gcc. Getting rid of the
extra test actually improves and speeds up that function probably
simply because the 64-bit arithmetic just cofuses gcc so badly. ]
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-23 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-23 3:50 {PATCH} isofs stuff Andries.Brouwer
2000-11-23 15:37 ` Linus Torvalds
2000-11-23 15:44 ` Andi Kleen
[not found] ` <Pine.LNX.4.10.10011230825380.7992-100000@penguin.transmeta.com>
2000-11-23 17:39 ` Tigran Aivazian
2000-11-23 19:57 ` Andi Kleen
2000-11-23 20:38 ` Linus Torvalds
2000-11-23 20:59 ` Matti Aarnio
2000-11-23 21:31 ` Alexander Viro
2000-11-23 16:58 ` Ragnar Hojland Espinosa
2000-11-23 17:20 ` Linus Torvalds [this message]
2000-11-23 18:20 ` Ragnar Hojland Espinosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10011230911200.7992-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ragnar@jazzfree.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).