linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andre Hedrick <andre@linux-ide.org>
To: "Jürgen Stohr" <juergen.stohr@gmx.de>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: BUG in pdc202xx_old.c
Date: Sun, 20 Jul 2003 13:53:39 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.10.10307201352010.29430-100000@master.linux-ide.org> (raw)
In-Reply-To: <200307202206.21872.juergen.stohr@gmx.de>


Juergen:

I have formally given up on Promise.
If it works somebody take it and stuff it into a kernel tree it is a DGD
for me now.

DGD == Don't Giva Damn

Cheers,

Andre Hedrick
LAD Storage Consulting Group

On Sun, 20 Jul 2003, [utf-8] Jürgen Stohr wrote:

> Hi Andre,
> in pdc202xx_old.c is a bug that prevents the use of "66 Clocking". The driver 
> always falls back to UDMA 33. The reason for this bug is found in function 
> "config_chipset_for_dma" when checking if the "other" drive is capable of 
> UDMA 66. The follwing patch, which should apply against 2.4.22-pre7, solves 
> the problem for me:
> 
> --- pdc202xx_old.c.broken       2003-07-20 20:12:39.000000000 +0200
> +++ pdc202xx_old.c      2003-07-20 20:18:50.000000000 +0200
> @@ -425,7 +425,7 @@
>                          * check to make sure drive on same channel
>                          * is u66 capable
>                          */
> -                       if (hwif->drives[!(drive->dn%2)].id) {
> +                       if (hwif->drives[!(drive->dn%2)].present) {
>                                 if (hwif->drives[!(drive->dn%2)].id->dma_ultra 
> & 0x0078) {
>                                         hwif->OUTB(CLKSPD | mask, 
> (hwif->dma_master + 0x11));
>                                 } else {
> 
> regards,
> Jürgen
> 


  reply	other threads:[~2003-07-20 20:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-20 20:06 BUG in pdc202xx_old.c Jürgen Stohr
2003-07-20 20:53 ` Andre Hedrick [this message]
2003-07-20 23:31 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10307201352010.29430-100000@master.linux-ide.org \
    --to=andre@linux-ide.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=juergen.stohr@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).